| Message ID | 42A05A0C.7080708@cadsoft.de |
|---|---|
| State | New |
| Headers |
Received: from tiger.cadsoft.de ([217.7.101.210]) by www.linuxtv.org with esmtp (Exim 4.34) id 1DeCA3-00014p-Qh for vdr@linuxtv.org; Fri, 03 Jun 2005 15:24:31 +0200 Received: from raven.cadsoft.de (raven.cadsoft.de [217.7.101.211]) by tiger.cadsoft.de (8.12.7/8.12.7) with ESMTP id j53DOUMC017232 for <vdr@linuxtv.org>; Fri, 3 Jun 2005 15:24:30 +0200 Received: from [192.168.100.10] (hawk.cadsoft.de [192.168.100.10]) by raven.cadsoft.de (8.13.3/8.13.3) with ESMTP id j53DOTSM015896 for <vdr@linuxtv.org>; Fri, 3 Jun 2005 15:24:29 +0200 Message-ID: <42A05A0C.7080708@cadsoft.de> Date: Fri, 03 Jun 2005 15:24:28 +0200 From: Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de> Organization: CadSoft Computer GmbH User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050317) X-Accept-Language: en MIME-Version: 1.0 To: vdr@linuxtv.org Subject: Re: [vdr] Problem with Master Timer's summary.conf (was: VDR developer version 1.3.25) References: <FE3A6FEF7560C346ABA908D65A9425E662E56F@SDEHAMEVS01.de.stageholding.com> In-Reply-To: <FE3A6FEF7560C346ABA908D65A9425E662E56F@SDEHAMEVS01.de.stageholding.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by tiger.cadsoft.de id j53DOUMC017232 X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Klaus Schmidinger's VDR <vdr@linuxtv.org> List-Id: Klaus Schmidinger's VDR <vdr.linuxtv.org> List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=unsubscribe> List-Archive: <http://www.linuxtv.org/pipermail/vdr> List-Post: <mailto:vdr@linuxtv.org> List-Help: <mailto:vdr-request@linuxtv.org?subject=help> List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=subscribe> X-List-Received-Date: Fri, 03 Jun 2005 13:24:32 -0000 Status: O X-Status: X-Keywords: X-UID: 2750 |
Commit Message
Klaus Schmidinger
June 3, 2005, 1:24 p.m. UTC
christian jacobsen wrote: > Hallo Klaus Please always start a new thread - don't reply to the release note. >>- The file 'summary.vdr' has been replaced with 'info.vdr' >>and now contains the >> information about a recording, in the same format as the >>events are stored in >> 'epg.data' (see man vdr(5) for details). Existing summary >>files can be converted >> to the new format by running the Perl script >>'summary2info.pl', as in >> >> summary2info.pl /video >> >> (the parameter given has to be the video directory). If >>there is no 'info.vdr' >> file for a recording, an attempt is made to read a 'summary.vdr'. > > > summary.vdr from Master-Timer is not shown correctly. > > Example what they look like (enriched with infos from tvmovie2vdr). > I would not expect that VDR parses Title or Subtitle ;), but it would be nice if it would just show everything in the file : > > ID: "41615360" > > Title: "Bean" > > Subtitle: "Der ultimative Katastrophenfilm" > > Description: "Spielfilm/Komödie, GB/USA, 1997, FSK: 6 > (Bean) [ DolbyDigital ] > > Kurzkritik: Mr. Bean ist voll in seinem Element! > > Action ** / Thrill * / Humor *** / Allgemein *** > > Museumswärter sorgt in L.A. für Chaos. > Nach einer Millionenspende kann endlich ein amerikanisches Kunstwerk vom Pariser Musée D'Orsay freigekauft und in die Grierson Gallery nach Los Angeles zurückgebracht werden. Um dieses Ereignis gebührend zu feiern, hat man einen Kunstexperten von der Royal National Gallery of England eingeladen. Dr. Bean soll eine feierliche Rede halten - ein grober Fehler, wie sich zeigt. Denn Bean, in Wirklichkeit der Museumswärter, sorgt überall nur für Chaos und Katastrophen! > > Regie: Mel Smith > Darsteller: Rowan Atkinson (Mr. Bean), Harris Yulin (George Grierson), Peter MacNicol (David Langley), Pamela Reed (Alison Langley), Burt Reynolds (Gen. Newton), Johnny Galecki (Stingo Wheelie), Peter Egan (Lord Walton), John Mills (Vorsitzender), Peter Capaldi (Gareth)" > > Greetings > Christian Jacobsen Well, I have only tested with VDR's own summary files ;-) Please try if this helps: The first two lines (separated by an empty line) will be used as Title and ShortText, and the rest (again, separated by an empty line) will be put into the Description. With Master Timer's format this will still be somewhat messy, since in your example it would interpret ID: "41615360" as the Title and Title: "Bean" as the ShortText, but at least all the rest should make it into the Description. Maybe Master Timer should have written its summary.conf the way VDR did ;-) Klaus
Comments
Klaus Schmidinger wrote: > ... > Maybe Master Timer should have written its summary.conf the way VDR did ;-) That should have been 'summary.vdr', of course - sorry for the typo. Klaus
Klaus Schmidinger wrote:
> Maybe Master Timer should have written its summary.conf the way VDR did ;-)
I've "invented" that format >4 years ago and as i NEVER ever programmed a Timer via VDR since this >4 years, i can't even remember what format VDR uses. :-)
I guess i should take the time to invent a new format that is compatible with both "old" (1.2.0 - 1.3.24) and "new" (1.3.25 - <x>) VDR.
Btw. Could you/someone provide a few examples of VDR-created timers & info.vdr-files (best including the snipped from epg.data) from 1.3.25?
Matthias Schniedermeyer wrote: > Klaus Schmidinger wrote: > >> Maybe Master Timer should have written its summary.conf the way VDR >> did ;-) > > > I've "invented" that format >4 years ago and as i NEVER ever programmed > a Timer via VDR since this >4 years, i can't even remember what format > VDR uses. :-) > I guess i should take the time to invent a new format that is compatible > with both "old" (1.2.0 - 1.3.24) and "new" (1.3.25 - <x>) VDR. > > Btw. Could you/someone provide a few examples of VDR-created timers & > info.vdr-files (best including the snipped from epg.data) from 1.3.25? The old summary.vdr files were written as --------------------------- Title ShortText Description --------------------------- where Title and ShortText were single lines, and Description could be several lines. Both ShortText and Description were optional. The new info.vdr format is described in vdr.5 and looks like this: --------------------------- C S19.2E-1-1079-28007 T nano S Die Welt von morgen D U.a. mit folgenden Themen: Verbrennen statt verkippen Neues Gesetz für den Restmüll Spritze gegen Schuppenflechte Neuer Wirkstoff blockiert das Immunsystem Formel für den Frühling Die Mathematik des Pflanzenwachstums Deutschland, 2005 X 2 01 deu Mono X 2 01 deu mono/2-Kanal X 1 01 deu 4:3 --------------------------- Klaus
Klaus Schmidinger wrote: > Matthias Schniedermeyer wrote: > >> Klaus Schmidinger wrote: >> >>> Maybe Master Timer should have written its summary.conf the way VDR >>> did ;-) >> >> >> >> I've "invented" that format >4 years ago and as i NEVER ever >> programmed a Timer via VDR since this >4 years, i can't even remember >> what format VDR uses. :-) >> I guess i should take the time to invent a new format that is >> compatible with both "old" (1.2.0 - 1.3.24) and "new" (1.3.25 - <x>) VDR. >> >> Btw. Could you/someone provide a few examples of VDR-created timers & >> info.vdr-files (best including the snipped from epg.data) from 1.3.25? > > > The old summary.vdr files were written as > > --------------------------- > Title > > ShortText > > Description > --------------------------- > > > where Title and ShortText were single lines, and Description > could be several lines. Both ShortText and Description were optional. > > The new info.vdr format is described in vdr.5 and looks like this: > > --------------------------- > C S19.2E-1-1079-28007 > T nano > S Die Welt von morgen > D U.a. mit folgenden Themen: Verbrennen statt verkippen Neues Gesetz für > den Restmüll Spritze gegen Schuppenflechte Neuer Wirkstoff blockiert das > Immunsystem Formel für den Frühling Die Mathematik des Pflanzenwachstums > Deutschland, 2005 > X 2 01 deu Mono > X 2 01 deu mono/2-Kanal > X 1 01 deu 4:3 > --------------------------- (Forword: "Description" is optional in Master-Timer, personally i don't like them in my timers, so i don't have them) So for the timer-(summary/info)-field it should be enough to replace the "||" Between the ID & Title with a " ", resulting in old: ID: "904527872"||Title: "Alias - Die Agentin"||Subtitle: "Erpressung" new: ID: "904527872" Title: "Alias - Die Agentin"||Subtitle: "Erpressung" But maybe i should change to a more "Eyefriendly" and shorter format. What do you think of this? Alias - Die Agentin (MT-ID:904527872)||Erpressung optionally appending: ||<Description> That would match the VDR-Format and be much less intrusive (only difference to VDR-format beeing the "(MT-ID:<id>)"-string) than the current format. :-)
Matthias Schniedermeyer wrote: > ... > But maybe i should change to a more "Eyefriendly" and shorter format. > What do you think of this? > Alias - Die Agentin (MT-ID:904527872)||Erpressung > optionally appending: ||<Description> > > That would match the VDR-Format and be much less intrusive (only > difference to VDR-format beeing the "(MT-ID:<id>)"-string) than the > current format. :-) Certainly a good idea. Klaus
Klaus Schmidinger wrote: > Matthias Schniedermeyer wrote: > >> ... >> But maybe i should change to a more "Eyefriendly" and shorter format. >> What do you think of this? >> Alias - Die Agentin (MT-ID:904527872)||Erpressung >> optionally appending: ||<Description> >> >> That would match the VDR-Format and be much less intrusive (only >> difference to VDR-format beeing the "(MT-ID:<id>)"-string) than the >> current format. :-) > > Certainly a good idea. Any Master-Timer Users already using a 1.3.25 VDR and using the "done" functionality that want's to beta-test this change? Bis denn
--- recording.c 2005/05/29 11:16:57 1.107 +++ recording.c 2005/06/03 13:15:54 @@ -480,7 +480,7 @@ char *data[3] = { NULL }; cReadLine ReadLine; char *s; - while ((s = ReadLine.Read(f)) != NULL && line < 3) { + while ((s = ReadLine.Read(f)) != NULL) { if (*s) { if (data[line]) { int len = strlen(s); @@ -492,7 +492,7 @@ else data[line] = strdup(s); } - else + else if (line < 2) line++; } fclose(f);