Summary missing when using Text2skin

Message ID 429C9980.8010304@ventoso.org
State New
Headers

Commit Message

Luca Olivetti May 31, 2005, 5:06 p.m. UTC
  En/na C.Y.M ha escrit:

> 
> It appears that text2skin now has support for vdr-1.3.25 in cvs.  Thanks!
> 
> 2005-06-xx: Version 1.1
> 
> - fixed a race condition (thanks to Reinhard Nissl for pointing this out)
> - updated finnish translations (thanks to Rolf Ahrenberg)
> - added tokens for Recording Info Display
>   (RecordingName, RecordingDateTime, RecordingTitle, RecordingShortText,
>   RecordingDescription, RecordingLanguageCode, RecordingLanguageDescription)

It appears they didn't apply the patch I sent to fix icons display
for menu items after the 9th (i.e. without a number in front) :-(
  

Comments

C.Y.M May 31, 2005, 5:23 p.m. UTC | #1
Luca Olivetti wrote:
> En/na C.Y.M ha escrit:
> 
>>
>> It appears that text2skin now has support for vdr-1.3.25 in cvs.  Thanks!
>>
>> 2005-06-xx: Version 1.1
>>
>> - fixed a race condition (thanks to Reinhard Nissl for pointing this out)
>> - updated finnish translations (thanks to Rolf Ahrenberg)
>> - added tokens for Recording Info Display
>>   (RecordingName, RecordingDateTime, RecordingTitle, RecordingShortText,
>>   RecordingDescription, RecordingLanguageCode,
>> RecordingLanguageDescription)
> 
> 
> It appears they didn't apply the patch I sent to fix icons display
> for menu items after the 9th (i.e. without a number in front) :-(
> 

I did not apply this patch, yet the icons are still displayed after the 9th
position when I select the main menu.  Can you please explain what this patch does?

Best Regards,
  
C.Y.M May 31, 2005, 5:55 p.m. UTC | #2
C.Y.M wrote:
> Luca Olivetti wrote:
> 
>>En/na C.Y.M ha escrit:
>>
>>
>>>It appears that text2skin now has support for vdr-1.3.25 in cvs.  Thanks!
>>>
>>>2005-06-xx: Version 1.1
>>>
>>>- fixed a race condition (thanks to Reinhard Nissl for pointing this out)
>>>- updated finnish translations (thanks to Rolf Ahrenberg)
>>>- added tokens for Recording Info Display
>>>  (RecordingName, RecordingDateTime, RecordingTitle, RecordingShortText,
>>>  RecordingDescription, RecordingLanguageCode,
>>>RecordingLanguageDescription)
>>
>>
>>It appears they didn't apply the patch I sent to fix icons display
>>for menu items after the 9th (i.e. without a number in front) :-(
>>
> 
> 
> I did not apply this patch, yet the icons are still displayed after the 9th
> position when I select the main menu.  Can you please explain what this patch does?
> 

Maybe the reason I am not seeing this problem is because I'm using a patch for
vdr that adds circular scrolling to the menu (ie; if i scroll all the way down
in the menu, it returns back to the top, and vice versa).  The menu items here
do not stop numbering after "9" (ie; I have 20 menu items and vdr numbers them
all the way up to 20).

Best Regards,
  
Luca Olivetti May 31, 2005, 5:56 p.m. UTC | #3
C.Y.M wrote:

>>It appears they didn't apply the patch I sent to fix icons display
>>for menu items after the 9th (i.e. without a number in front) :-(
>>
> 
> 
> I did not apply this patch, yet the icons are still displayed after the 9th
> position when I select the main menu.  Can you please explain what this patch does?

With enigma the icon in the upper right changes based on the selected 
item of the menu. If it finds a match will show a specific icon, 
otherwise it will show the generic vdr icon. Without the patch a menu 
item after the 9th never matches because it has a space in front (just 
checked).

Bye
  

Patch

--- render.c.orig	2005-04-18 14:52:23.514081534 +0200
+++ render.c	2005-04-18 14:52:44.115775906 +0200
@@ -591,7 +591,7 @@ 
 				if (n != 0)
 					res = skipspace(end);
 				else
-					res = ptr;
+					res = skipspace(ptr);
 				Dprintf("MenuCurrent result: |%s|\n", res.String().c_str());
 			}
 			else if (Token.Type == tMenuTitle) {