From patchwork Mon Apr 4 16:49:49 2005 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Cap X-Patchwork-Id: 11845 Received: from smtp.compuserve.de ([62.52.27.101] helo=lnxc-641.srv.mediaways.net) by www.linuxtv.org with smtp (Exim 4.34) id 1DIUlZ-0000ER-HX for vdr@linuxtv.org; Mon, 04 Apr 2005 18:49:33 +0200 Received: (qmail 16441 invoked by uid 501); 4 Apr 2005 16:49:43 -0000 X-Authenticated-Sender: macap20001 Received: from dsl-084-058-020-001.arcor-ip.net (dsl-084-058-020-001.arcor-ip.net [84.58.20.1]) by compuserve.de ([10.228.3.105]) with ESMTP via TCP; 04 Apr 2005 16:49:43 -0000 Message-ID: <4251702D.7040504@compuserve.de> Date: Mon, 04 Apr 2005 18:49:49 +0200 From: Martin Cap User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040616 Thunderbird/0.7 Mnenhy/0.6.0.101 X-Accept-Language: de-de, en-us, en MIME-Version: 1.0 To: Klaus Schmidinger's VDR Subject: Re: [vdr] Patch: dxr3plugin OSD don't turn pink References: <424A9224.4000608@compuserve.de> <1112217417.31596.17.camel@bobcat.mine.nu> <424E66B0.1030901@ventoso.org> <424E6E6E.9000307@compuserve.de> <424E72B6.8000903@ventoso.org> <424E757F.2040804@ventoso.org> <424E7743.8060801@ventoso.org> <424E7852.60808@ventoso.org> <424E793E.9040202@ventoso.org> <1112448795.23456.48.camel@bobcat.mine.nu> <424ECCA5.1030309@ventoso.org> <1112461894.12964.1.camel@bobcat.mine.nu> <424FD272.2050808@ventoso.org> <424FEA9E.1050207@ventoso.org> <42501BA4.8070902@compuserve.de> <42502096.7030109@ventoso.org> <425022ED.7060008@compuserve.de> <1112556049.24368.75.camel@bobcat.mine.nu> <42505F40.90201@ventoso.org> <42516694.9070900@ventoso.org> In-Reply-To: <42516694.9070900@ventoso.org> X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Klaus Schmidinger's VDR List-Id: Klaus Schmidinger's VDR List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2005 16:49:33 -0000 Status: O X-Status: X-Keywords: X-UID: 1414 Luca Olivetti wrote: > > well, it doesn't harm (it was in Martin's source withot me realizing it) > but it works well even without it. I also set the palette to 16 colors > now (not that it changes much, but...). > > Bye > > ------------------------------------------------------------------------ > > --- dxr3interface_spu_encoder.c.orig 2005-04-04 17:53:35.966868390 +0200 > +++ dxr3interface_spu_encoder.c 2005-04-04 17:57:36.107254910 +0200 > @@ -270,6 +270,8 @@ > > // set active area to 0 > //m_x0 = m_x1 = m_y0 = m_y1 = 0; > + //16 Colors max. > + m_palManager.SetBpp(4); You're right, that's the way it should be done. Another thing I made wrong is "dxr3tools.h" only gets included, if one sets -DUSE_XINE_SCALER in eg. the Makefile, otherwise not. Thus, the include-statement is at the wrong place (I don't think anyone wants to use the old scaling-algorithm, but you never know...) : ---- --- dxr3interface_spu_encoder.c 2005-04-04 18:45:09.526439552 +0200 +++ dxr3interface_spu_encoder.c.orig 2005-04-04 18:44:16.120558480 +0200 @@ -28,7 +28,7 @@ #include "dxr3interface_spu_encoder.h" #include "dxr3memcpy.h" -#include "dxr3tools.h" + /* ToDo: @@ -47,6 +47,7 @@ #include #include +#include "dxr3tools.h" #include namespace XineScaler