security patch for vdradmin-0.97-am1

Message ID 423EB037.8020104@syphir.sytes.net
State New
Headers

Commit Message

C.Y.M March 21, 2005, 11:29 a.m. UTC
  C.Y.M wrote:
> Andreas Mair wrote:
> 
>>Hi,
>>
>>thanks for the patch, I've already included it in the release I will put out 
>>today.
>>
>>Regards,
>>Andreas
>>
>>On Monday 21 March 2005 11:01, C.Y.M wrote:
>>
>>
>>>I noticed the following patch was missing from vdradmin-0.97-am1.
>>>
> 
> 
> No problem..
> 
> I know this is unrelated to the security patch, but I also noticed that if I
> change the start page in the configuration options from the default "Channels"
> to "What's On", then it fails to display upon login.
> 

It appears that if I set the configuration to show the "Timers" screen on login,
then it shows me "What's on".

Also, I have attached another patch that looks like it was for vdr-1.3.x
compatability way back. Im not sure if it is necessary or not..

Best Regards,
  

Comments

Andreas Mair March 21, 2005, 11:58 a.m. UTC | #1
Hi,

> > I know this is unrelated to the security patch, but I also noticed that
> > if I change the start page in the configuration options from the
> > default "Channels" to "What's On", then it fails to display upon login.
>
> It appears that if I set the configuration to show the "Timers" screen on
> login, then it shows me "What's on".

I'll have a look at this.

> Also, I have attached another patch that looks like it was for vdr-1.3.x
> compatability way back. Im not sure if it is necessary or not..

Thanks for the patch. Where does it origin?
How can I test wether it is needed an works?

Regards,
Andreas
  
C.Y.M March 21, 2005, 1:05 p.m. UTC | #2
Andreas Mair wrote:
> Hi,
> 
> 
>>>I know this is unrelated to the security patch, but I also noticed that
>>>if I change the start page in the configuration options from the
>>>default "Channels" to "What's On", then it fails to display upon login.
>>
>>It appears that if I set the configuration to show the "Timers" screen on
>>login, then it shows me "What's on".
> 
> 
> I'll have a look at this.
> 

Ah, I just figured it out. I had changed the language to English, then I noticed
that all the features were missing and the drop down windows did not contain the
same choices.  What really needs to be done is for the English templates to be
updated.

Best Regards,
  

Patch

diff -u --recursive /tmp/vdradmin-0.95/vdradmind.pl vdradmin-0.95/vdradmind.pl
--- /tmp/vdradmin-0.95/vdradmind.pl	2003-12-13 18:26:37.000000000 +0200
+++ vdradmin-0.95/vdradmind.pl	2004-03-17 20:40:13.000000000 +0200
@@ -452,7 +452,7 @@ 
 		for my $channel (@CHAN) {
 			if($channel->{source} eq $1 &&
 			   $channel->{nid} == $2 &&
-			   ($channel->{nid} ? $channel->{tid} : $channel->{frequency}) == $3 &&
+			   ($channel->{nid} || $channel->{tid} ? $channel->{tid} : $channel->{frequency}) == $3 &&
 			   $channel->{service_id} == $4) {
 				return($channel->{vdr_id});
 			}