diff mbox

Re: DXR3, which versions to select?

Message ID 423D7CED.7070208@iki.fi
State New
Headers

Commit Message

Antti Järvinen March 20, 2005, 1:38 p.m. UTC 
  Ville Skyttä wrote:
> 
> The most glaring DXR3 plugin problems I'm aware of are:

> - No sound with the MP3 or DVD plugins with VDR >= 1.3.18

The attached patch should resolve the problem with the MP3-plugin. The 
patch is against cvs-version in vdr-dxr3-stable branch.

BR, Antti

Comments

Markku Tavasti March 26, 2005, 6:19 p.m. UTC | #1 
Antti Järvinen <ajj@iki.fi> writes:

>> - No sound with the MP3 or DVD plugins with VDR >= 1.3.18
>
> The attached patch should resolve the problem with the MP3-plugin. The
> patch is against cvs-version in vdr-dxr3-stable branch.

Nearly works. MP3 plugin works if I press 3s forward on beginning of
every track. Without that press player is jammed on beginning of each
track forever.
Markku Tavasti March 29, 2005, 8:02 a.m. UTC | #2 
Markku Tavasti <tavasti@iki.fi> writes:

>> The attached patch should resolve the problem with the MP3-plugin. The
>> patch is against cvs-version in vdr-dxr3-stable branch.
>
> Nearly works. MP3 plugin works if I press 3s forward on beginning of
> every track. Without that press player is jammed on beginning of each
> track forever.

MP3 plugin seem unusable with my setup:

- With DXR3 audio out needs that 3s forward press for every track
- With OSS audio output no volume control available, or have I missed
  some part of setup?

And to finalize unusability, vdr stops working after 5-300 minutes
with mp3 plugin. At some point there comes silence, and remote does
not do anything. Don't really know what is problem, but VDR seems to
be dead. And this happens only with mp3 plugin. 

I am using:
vdr-1.3.22
vdr-mp3-0.9.11
em8300-0.15.0-cvs20050308-patched-20050307      (From cachalot.mine.nu )
vdr-dxr3-0.2.3-pre3-cvs20040913-patched-2005030 (From cachalot.mine.nu )

Anybody having properly working vdr-1.3.23 + dxr3 + vdr-mp3? Switching
to 1.3.23 would be nice since there is timer date-format fixed.
Luca Olivetti March 29, 2005, 9:04 a.m. UTC | #3 
Markku Tavasti wrote:
> Markku Tavasti <tavasti@iki.fi> writes:
> 
> 
>>>The attached patch should resolve the problem with the MP3-plugin. The
>>>patch is against cvs-version in vdr-dxr3-stable branch.
>>
>>Nearly works. MP3 plugin works if I press 3s forward on beginning of
>>every track. Without that press player is jammed on beginning of each
>>track forever.
> 
> 
> MP3 plugin seem unusable with my setup:
> 
> - With DXR3 audio out needs that 3s forward press for every track

With vdr-1.3.23, the cvs vdr-dxr3-stable branch and this patch (didn't
check if it's been applied in cvs) I don't see this. Cannot comment on
the other issues since I just installed the mp3 plugin for testing.

Bye
Stefan Huelswitt March 29, 2005, 5:27 p.m. UTC | #4 
On 29 Mar 2005 Markku Tavasti <tavasti@iki.fi> wrote:

> - With OSS audio output no volume control available, or have I missed
>   some part of setup?

Correct, I think most (err, most are using DVB, but anyways)
people have the soundcard connected to their amplifier and use
the volumen control there.

> And to finalize unusability, vdr stops working after 5-300 minutes
> with mp3 plugin. At some point there comes silence, and remote does
> not do anything. Don't really know what is problem, but VDR seems to
> be dead. And this happens only with mp3 plugin. 

Sorry, I can only comment on MP3 plugin on DVB and in this case I
can play hours of music without any problem.

Regards.
Ville Skyttä April 1, 2005, 6:16 p.m. UTC | #5 
On Sun, 2005-03-20 at 15:38 +0200, Antti Järvinen wrote:
> Ville Skyttä wrote:
> > 
> > The most glaring DXR3 plugin problems I'm aware of are:
> 
> > - No sound with the MP3 or DVD plugins with VDR >= 1.3.18
> 
> The attached patch should resolve the problem with the MP3-plugin. The 
> patch is against cvs-version in vdr-dxr3-stable branch.

Oops, I seem to have missed this mail, but... wow, great!  Works for me,
no April fools here :).  I have applied it to the vdr-dxr3-0-2 branch in
CVS.  Thanks a bunch!

BTW, note that the "vdr-dxr3-stable" branch in CVS was a temporary name;
it has been renamed to "vdr-dxr3-0-2".
diff mbox

Patch

Index: dxr3device.c
===================================================================
RCS file: /cvsroot/dxr3plugin/dxr3/dxr3device.c,v
retrieving revision 1.2.2.8
diff -w -b -u -r1.2.2.8 dxr3device.c
--- dxr3device.c	18 Mar 2005 22:31:55 -0000	1.2.2.8
+++ dxr3device.c	20 Mar 2005 13:22:15 -0000
@@ -383,12 +383,19 @@ 
     if (m_strBuf.length()) 
 	{
         m_strBuf.append((const char*)Data, Length);
+        if (m_PlayMode == pmAudioOnly) {
+		retLength = m_DemuxDevice.DemuxAudioPes((const uint8_t*)m_strBuf.data(), m_strBuf.length());
+	} else {	        
         retLength = m_DemuxDevice.DemuxPes((const uint8_t*)m_strBuf.data(), m_strBuf.length(), true);
     } 
-	else 
-	{
+    	 
+    } else { 
+	if (m_PlayMode == pmAudioOnly) {
+		retLength = m_DemuxDevice.DemuxAudioPes((const uint8_t*)Data, Length);
+	} else {
         retLength = m_DemuxDevice.DemuxPes((const uint8_t*)Data, Length, true);
     }
+    }
 	
     Length -= retLength;