From patchwork Sat Feb 26 16:21:01 2005 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "C.Y.M" X-Patchwork-Id: 11791 Received: from dialup-4.245.112.245.dial1.sanjose1.level3.net ([4.245.112.245] helo=nofear.bounceme.net) by www.linuxtv.org with esmtp (Exim 4.34) id 1D54eM-0006S4-93 for vdr@linuxtv.org; Sat, 26 Feb 2005 17:18:39 +0100 Received: from [10.1.1.66] (hades [10.1.1.66]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by nofear.bounceme.net (Postfix) with ESMTP id 01F5B73526 for ; Sat, 26 Feb 2005 08:18:28 -0800 (PST) Message-ID: <4220A1ED.20003@syphir.sytes.net> Date: Sat, 26 Feb 2005 08:21:01 -0800 From: "C.Y.M" Organization: CooLNeT User-Agent: Mozilla Thunderbird 0.8 (Windows/20040913) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Klaus Schmidinger's VDR Subject: [vdr] Problems with 20 Timers References: <421F60D5.90702@cadsoft.de> In-Reply-To: <421F60D5.90702@cadsoft.de> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: syphir@syphir.sytes.net, Klaus Schmidinger's VDR List-Id: Klaus Schmidinger's VDR List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Feb 2005 16:18:39 -0000 Status: O X-Status: X-Keywords: X-UID: 356 Klaus Schmidinger wrote: > Chris Warren wrote: > >>> -----Original Message----- >>> From: vdr-bounces@linuxtv.org [mailto:vdr-bounces@linuxtv.org] On >>> Behalf Of C.Y.M >>> >>> Have you noticed that the show summaries (Recordings descriptions) >>> are wrong on recorded events when you use a timer? I am curious if >>> this behavior has to do with what you are describing. The only way I >>> can get the summaries to display the correct information is if I >>> record a minute longer after the show ends. For example, lets say a >>> show starts at 1:00 and ends at 2:00. If you set a timer for 1:00 to >>> 2:00, then in the schedule will show a little "t" next to the show >>> you have set to record. But, if you set a timer for 1:00 to 2:01, >>> then the schedule shows a capital "T" next to the show being recorded >>> and two little "t"'s before and after the scheduled show. The first >>> method will use the Summary of the previously scheduled show and the >>> second method seems to use the correct information. >>> >> >> Yes, I get this too - it's because of the following line in >> cTimer::Matches(time_t, bool) of timers.c: >> >> return startTime <= t && t < stopTime; // must stop *before* >> stopTime >> to allow adjacent timers >> >> If your end time is exactly the same as the end of the event, it will >> match >> the start time, but not the end time. It'll only get marked as a partial >> match. > > > Since I always add a few minutes before and after a recording I guess > I don't have that problem. I'll look into this when I refine the VPS > handling, for which I also need to improve the event assignment. > This seems to fix setting adjacent timers.. Regards, --- vdr-1.3.21/timers.c.orig 2005-02-26 08:09:45.000000000 -0800 +++ vdr-1.3.21/timers.c 2005-02-26 08:11:59.000000000 -0800 @@ -348,7 +348,7 @@ stopTime = event->EndTime(); return event->IsRunning(true); } - return startTime <= t && t < stopTime; // must stop *before* stopTime to allow adjacent timers + return startTime <= t && t <= stopTime; // must stop *before* stopTime to allow adjacent timers } return false; }