| Message ID | 420F9632.9030205@ventoso.org |
|---|---|
| State | New |
| Headers |
Received: from 232.red-213-97-27.pooles.rima-tde.net ([213.97.27.232]) by www.linuxtv.org with esmtp (Exim 4.34) id 1D0O5H-0004vP-3T for vdr@linuxtv.org; Sun, 13 Feb 2005 19:03:03 +0100 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by 232.Red-213-97-27.pooles.rima-tde.net (Postfix) with ESMTP id 0EA52189FBA2 for <vdr@linuxtv.org>; Sun, 13 Feb 2005 19:02:33 +0100 (CET) Message-ID: <420F9632.9030205@ventoso.org> Date: Sun, 13 Feb 2005 19:02:26 +0100 From: Luca Olivetti <luca@ventoso.org> User-Agent: Mozilla Thunderbird 0.9 (X11/20041103) X-Accept-Language: en-us, en MIME-Version: 1.0 To: vdr@linuxtv.org Subject: Re: [vdr] [PATCH] vdr-1.3.21: keep language name on audio menu in transfer mode References: <420F8E43.6070908@ventoso.org> <200502131843.40121.wolfgang@rohdewald.de> In-Reply-To: <200502131843.40121.wolfgang@rohdewald.de> X-Enigmail-Version: 0.89.0.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig9B7F46B543FD7EC2666A3E47" X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Klaus Schmidinger's VDR <vdr.linuxtv.org> List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=unsubscribe> List-Archive: <http://www.linuxtv.org/pipermail/vdr> List-Post: <mailto:vdr@linuxtv.org> List-Help: <mailto:vdr-request@linuxtv.org?subject=help> List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=subscribe> X-List-Received-Date: Sun, 13 Feb 2005 18:03:03 -0000 Status: O X-Status: X-Keywords: X-UID: 42 |
Commit Message
Luca Olivetti
Feb. 13, 2005, 6:02 p.m. UTC
Wolfgang Rohdewald wrote: > On Sonntag 13 Februar 2005 18:28, Luca Olivetti wrote: > >>if not Player is cTransferControl > > > if (!dynamic_cast<cTransferControl>(Player)) close, it's "if (!dynamic_cast<cTransfer*>(Player))" (my fault in using cTransferControl instead of cTransfer). Attached is the new patch that only modifies device.c Thank you. Bye
Comments
Luca Olivetti wrote: > Wolfgang Rohdewald wrote: > >> On Sonntag 13 Februar 2005 18:28, Luca Olivetti wrote: >> >>> if not Player is cTransferControl >> >> >> >> if (!dynamic_cast<cTransferControl>(Player)) > > > close, it's "if (!dynamic_cast<cTransfer*>(Player))" (my fault in using > cTransferControl instead of cTransfer). > Attached is the new patch that only modifies device.c I'm afraid I don't quite see the problem. When I switch to a channel that is received in Transfer Mode, and then open the "Audio" menu, I very well see the descriptions of the audio tracks. Klaus
On Sat, 19 Feb 2005, Klaus Schmidinger wrote: > I'm afraid I don't quite see the problem. > When I switch to a channel that is received in Transfer Mode, > and then open the "Audio" menu, I very well see the descriptions > of the audio tracks. Well, in my setup (Airstar2 + FF DVB-S) audio tracks of the finnish terrestial channels are shown only as numbers ("1"), but after the patch the correct language code is finally shown as description ("fin"). So there's a problem lying somewhere... -- rofa
Rolf Ahrenberg wrote: > On Sat, 19 Feb 2005, Klaus Schmidinger wrote: > >> I'm afraid I don't quite see the problem. >> When I switch to a channel that is received in Transfer Mode, >> and then open the "Audio" menu, I very well see the descriptions >> of the audio tracks. > > > Well, in my setup (Airstar2 + FF DVB-S) audio tracks of the finnish > terrestial channels are shown only as numbers ("1"), but after the > patch the correct language code is finally shown as description > ("fin"). So there's a problem lying somewhere... Ah, I guess I was looking at channels that actually _have_ descriptions for the audio tracks (in the EPG data!) ;-) Ok, on channels that don't have such descriptions you are probably right. I'll look into this when building in handling of track descriptions for recordings. Klaus
Klaus Schmidinger wrote: > Luca Olivetti wrote: > >> Wolfgang Rohdewald wrote: >> >>> On Sonntag 13 Februar 2005 18:28, Luca Olivetti wrote: >>> >>>> if not Player is cTransferControl >>> >>> >>> >>> >>> if (!dynamic_cast<cTransferControl>(Player)) >> >> >> >> close, it's "if (!dynamic_cast<cTransfer*>(Player))" (my fault in >> using cTransferControl instead of cTransfer). >> Attached is the new patch that only modifies device.c > > > I'm afraid I don't quite see the problem. > When I switch to a channel that is received in Transfer Mode, > and then open the "Audio" menu, I very well see the descriptions > of the audio tracks. > To reproduce the bug, switch to a channel and select the audio menu. Close the menu, then go back to the audio menu again and instead of descriptions of the audio selections, vdr just displays numbers. Regards,
--- device.c.orig 2005-02-13 17:38:45.009642660 +0100 +++ device.c 2005-02-13 19:00:20.160941034 +0100 @@ -818,7 +818,7 @@ if (CanReplay()) { if (player) Detach(player); - ClrAvailableTracks(); + if (!dynamic_cast<cTransfer*>(Player)) ClrAvailableTracks(); pesAssembler->Reset(); player = Player; SetPlayMode(player->playMode);