demuxing subtitles with projectx

Message ID 3e063bbf0802110513g6c53314fvf01f6a9495936753@mail.gmail.com
State New
Headers

Commit Message

Petri Helin Feb. 11, 2008, 1:13 p.m. UTC
  On Feb 10, 2008 3:20 PM, Stefan Wagner <stefanwag@gmx.at> wrote:

> "Petri Helin" <phelin@googlemail.com> schrieb im Newsbeitrag
> news:4763C547.1080009@googlemail.com...
> > Has there been any progress regarding this issue? It looks like ProjectX
> >  will fail in case there are subtitles in a VDR recording made with
> > version 1.5.10 or later, because ProjectX does not recognize them being
> > subtitles and will eventually get stuck to an unending loop. What might
> > be the major difference between the old subtitles plugin's way of saving
> > subtitles and the way they are saved now?
>
> ProjectX 0.90.4.b22 works with vdr 1.5.x recordings.
>
> but with burn 0.1.0-pre21 i have problems with naming of audio files.
> projectx beta named files other than old projectx.
>
> have anyone a fix for that?
>

Thanks for informing about the update. Seems to work now with recordings
with dvb-subtitles from the Finnish broadcaster, YLE, too.

Regarding the renaming of the audio files, I made a few changes in the
Project-X in order to fix that:


Don't know whether it is "the right way" but with a quick test it seems to
work at least.

-Petri
  

Comments

Stefan Wagner Feb. 11, 2008, 8:26 p.m. UTC | #1
Petri Helin <phelin@googlemail.com> wrote:
> Thanks for informing about the update. Seems to work now with recordings
> with dvb-subtitles from the Finnish broadcaster, YLE, too.
> 
> Regarding the renaming of the audio files, I made a few changes in the
> Project-X in order to fix that:
> 
> --- parser/StreamProcessAudio.java.old  2008-02-11 15:09:21.000000000 +0200
> +++ parser/StreamProcessAudio.java      2008-02-11 15:08:29.000000000 +0200
> @@ -1861,8 +1861,8 @@
>        {
>                for (int i = 1; i < 4; i++)
>                {
> -                       str[0][i] += new_str_1;
> -                       str[1][i] += new_str_2;
> +                       str[0][i] = new_str_1;
> +                       str[1][i] = new_str_2;
>                }
>        }
> 
> 
> Don't know whether it is "the right way" but with a quick test it seems to
> work at least.

hm, with a recording from zdf with 2 mpa streams i become this:

-rw-rw-r-- 1 vdr vdr 3638016 11. Feb 21:13 vdrsync-02.mpa
prw-rw-r-- 1 vdr vdr       0 11. Feb 21:12 vdrsync0.mpa
prw-rw-r-- 1 vdr vdr       0 11. Feb 21:12 vdrsync1.mpa
-rw-rw-r-- 1 vdr vdr 1819008 11. Feb 21:13 vdrsync.mpa

vdrsync0.mpa and vdrsync1.mpa only 0 byte, and burn waits for anything.

with 1 audio stream:
prw-rw-r-- 1 vdr vdr       0 11. Feb 21:24 vdrsync1.mpa
-rw-rw-r-- 1 vdr vdr 3638016 11. Feb 21:24 vdrsync.mpa

and the dvd will be created.

Stefan
  

Patch

--- parser/StreamProcessAudio.java.old  2008-02-11 15:09:21.000000000 +0200
+++ parser/StreamProcessAudio.java      2008-02-11 15:08:29.000000000 +0200
@@ -1861,8 +1861,8 @@ 
        {
                for (int i = 1; i < 4; i++)
                {
-                       str[0][i] += new_str_1;
-                       str[1][i] += new_str_2;
+                       str[0][i] = new_str_1;
+                       str[1][i] = new_str_2;
                }
        }