From patchwork Sun Dec 2 20:06:26 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Lock X-Patchwork-Id: 15766 Received: from localhost ([127.0.0.1] helo=www.linuxtv.org) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1TfFoR-0001yM-TL; Sun, 02 Dec 2012 21:06:51 +0100 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1TfFoM-0001vv-Lv for vdr@linuxtv.org; Sun, 02 Dec 2012 21:06:50 +0100 X-tubIT-Incoming-IP: 78.46.108.116 Received: from gelbbaer.kn-bremen.de ([78.46.108.116] helo=smtp.kn-bremen.de) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp for id 1TfFoM-0004m6-HE; Sun, 02 Dec 2012 21:06:46 +0100 Received: by smtp.kn-bremen.de (Postfix, from userid 10) id D94281E000DF; Sun, 2 Dec 2012 21:06:45 +0100 (CET) Received: from triton8.kn-bremen.de (noident@localhost [127.0.0.1]) by triton8.kn-bremen.de (8.14.4/8.14.4) with ESMTP id qB2K6QUu021910; Sun, 2 Dec 2012 21:06:26 +0100 (CET) (envelope-from vdr-l@triton8.kn-bremen.de) Received: (from vdr-l@localhost) by triton8.kn-bremen.de (8.14.4/8.14.3/Submit) id qB2K6QVZ021909; Sun, 2 Dec 2012 21:06:26 +0100 (CET) (envelope-from vdr-l) From: Juergen Lock Date: Sun, 2 Dec 2012 21:06:26 +0100 To: Juergen Lock Message-ID: <20121202200626.GA21883@triton8.kn-bremen.de> References: <20121129151710.GA1460@bloms.de> <50B879A1.9020103@flensrocker.de> <201212012014.qB1KE19O084002@triton8.kn-bremen.de> <50BB5570.6040002@tvdr.de> <20121202195831.GA20331@triton8.kn-bremen.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20121202195831.GA20331@triton8.kn-bremen.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.12.2.195416 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' FROM_SAME_AS_TO 0.05, HTML_00_01 0.05, HTML_00_10 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CD 0, __CT 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_SAME_AS_FROM2 0, __URI_NO_PATH 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0' X-LSpam-Score: -1.1 (-) X-LSpam-Report: No, score=-1.1 required=5.0 tests=BAYES_00=-1.9, RDNS_NONE=0.793 autolearn=no Cc: VDR Mailing List Subject: Re: [vdr] *scanf %a, patches... X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: vdr-bounces@linuxtv.org Errors-To: vdr-bounces@linuxtv.org On Sun, Dec 02, 2012 at 08:58:31PM +0100, Juergen Lock wrote: > On Sun, Dec 02, 2012 at 02:19:44PM +0100, Klaus Schmidinger wrote: > > On 01.12.2012 21:14, Juergen Lock wrote: > > > In article <50BA09CC.2040104@flensrocker.de> you write: > > >> Am 30.11.2012 11:32, schrieb Gerald Dachs: > > >>> Am 2012-11-30 10:17, schrieb Lars Hanisch: > [...] And the tools.c patch for the > cCharSetConv destructor looks like an actual bug, iconv_close() > shouldn't be called with (iconv_t)-1. > Ah sorry that patch isn't in ports yet, and now that I think of it it only occured when testing the epgfixer plugin which doesn't quite work properly yet anyway. But I guess it wouldn't hurt applying anyway so here it is: Thanx again, :) Juergen --- tools.c.orig +++ tools.c @@ -842,7 +842,8 @@ cCharSetConv::cCharSetConv(const char *F cCharSetConv::~cCharSetConv() { free(result); - iconv_close(cd); + if (cd != (iconv_t)-1) + iconv_close(cd); } void cCharSetConv::SetSystemCharacterTable(const char *CharacterTable)