diff mbox

vdr-1.7.31 & small improvement for last viewed recording

Message ID 20121003103637.5ecb55c3@aspire4935G
State New
Headers

Commit Message

hondansx@gmx.de Oct. 3, 2012, 8:36 a.m. UTC 
  Hi,

attached is a small patch which I find very useful. 

It extends the (Re)PlayButton.
If no last viewed recording was set (mostly after restart of vdr) and
you press the Play Button all Recordings will be shown.

Would be nice, if it find's a way into the main vdr.

BR,
Alex

Comments

Udo Richter Oct. 3, 2012, 10:22 a.m. UTC | #1 
Am 03.10.2012 10:36, schrieb AlexW:
> If no last viewed recording was set (mostly after restart of vdr) and
> you press the Play Button all Recordings will be shown.

Nice idea. But I think the idea of having the play button have more 
functionality can be improved further.

For one thing, a feature that I always wanted to implement, but never 
got to, is to remember the last playback across restarts, so you can 
easily stop watching, shut down, restart later, and just hit play to 
continue. Shouldn't be too difficult. Obviously, this would make your 
idea mostly useless.

On a second thought however, VDR could react differently when reaching 
the end of a recording, compared to stopping in the middle. When played 
back to the end, hitting play would show the last 10 seconds again, 
something you probably don't want. Instead, VDR could show the 
recordings folder the recording was in, so you can for example pick the 
next following recording. Or if you really want to see that recording, 
just hit play again.

I really like the idea of starting up VDR, hit play, and either continue 
to watch the last recording I've seen, or to start watching the next 
following recording.


Thoughts on that?

Cheers,

Udo
Klaus Schmidinger Oct. 3, 2012, 10:28 a.m. UTC | #2 
On 03.10.2012 12:22, Udo Richter wrote:
> Am 03.10.2012 10:36, schrieb AlexW:
>> If no last viewed recording was set (mostly after restart of vdr) and
>> you press the Play Button all Recordings will be shown.
>
> Nice idea. But I think the idea of having the play button have more functionality can be improved further.
>
> For one thing, a feature that I always wanted to implement, but never got to, is to remember the last playback across restarts, so you can easily stop watching, shut down, restart later, and just hit play to continue. Shouldn't be too difficult.

This could be done by simply storing the name of the last viewed recording
in setup.conf.

> Obviously, this would make your idea mostly useless.

Not really. If the last viewed recording has been deleted, this new
functionality could still kick in (and it will, since I've already
adopted this patch for verison1.7.32 ;-).
Besides, I have added the same functionality to the Blue key in the
main menu.

> On a second thought however, VDR could react differently when reaching the end of a recording, compared to stopping in the middle. When played back to the end, hitting play would show the last 10 seconds again, something you probably don't want. Instead, VDR could show the recordings folder the
> recording was in, so you can for example pick the next following recording. Or if you really want to see that recording, just hit play again.
>
> I really like the idea of starting up VDR, hit play, and either continue to watch the last recording I've seen, or to start watching the next following recording.
>
>
> Thoughts on that?

Sounds way too complex for my taste.

Klaus
Udo Richter Oct. 3, 2012, 11:29 a.m. UTC | #3 
Am 03.10.2012 12:28, schrieb Klaus Schmidinger:
> Not really. If the last viewed recording has been deleted, this new
> functionality could still kick in

The patch above just checks the string presence. It should also check 
whether the string is an existing recording then.

> Sounds way too complex for my taste.

Not necessarily. One way: When hitting play, check whether LastReplay 
exists, is a recording, and check whether the replay index is far from 
the file end. If not, show recordings menu.


Another way: When writing index->StoreResume() in dvbplayer, check for 
file end and set a flag remembering that. Maybe together with 
LastReplayed file. Then, when hitting play, check for that flag and show 
recordings menu instead.

Cheers,

Udo
Klaus Schmidinger Oct. 3, 2012, 12:46 p.m. UTC | #4 
On 03.10.2012 13:29, Udo Richter wrote:
> Am 03.10.2012 12:28, schrieb Klaus Schmidinger:
>> Not really. If the last viewed recording has been deleted, this new
>> functionality could still kick in
>
> The patch above just checks the string presence. It should also check whether the string is an existing recording then.

When a recording is deleted, cReplayControl::ClearLastReplayed() sets that string to NULL
in case it is the deleted recording.

>> Sounds way too complex for my taste.
>
> Not necessarily. One way: When hitting play, check whether LastReplay exists, is a recording, and check whether the replay index is far from the file end. If not, show recordings menu.
>
>
> Another way: When writing index->StoreResume() in dvbplayer, check for file end and set a flag remembering that. Maybe together with LastReplayed file. Then, when hitting play, check for that flag and show recordings menu instead.

Don't like it.

Klaus
diff mbox

Patch

--- vdr.c.orig	2012-09-24 14:43:04.000000000 +0200
+++ vdr.c	2012-10-03 10:11:26.775120496 +0200
@@ -1238,6 +1238,9 @@ 
                      cControl::Shutdown();
                      cControl::Launch(new cReplayControl);
                      }
+		  else {
+		     DirectMainFunction(osRecordings);
+		  }
                   break;
              default:    break;
              }