From patchwork Thu Sep 30 20:51:34 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: dplu X-Patchwork-Id: 12837 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.69) (envelope-from ) id 1P1Q6K-0001oX-GU for vdr@linuxtv.org; Thu, 30 Sep 2010 22:51:37 +0200 X-tubIT-Incoming-IP: 93.17.128.3 Received: from smtp21.services.sfr.fr ([93.17.128.3]) by mail.tu-berlin.de (exim-4.69/mailfrontend-d) with esmtp for id 1P1Q6J-0001xG-2c; Thu, 30 Sep 2010 22:51:36 +0200 Received: from filter.sfr.fr (localhost [127.0.0.1]) by msfrf2111.sfr.fr (SMTP Server) with ESMTP id 8E7BE7000091 for ; Thu, 30 Sep 2010 22:51:35 +0200 (CEST) Received: from [192.168.0.26] (unknown [88.141.211.247]) by msfrf2111.sfr.fr (SMTP Server) with ESMTP id 2B47B700008D for ; Thu, 30 Sep 2010 22:51:35 +0200 (CEST) X-SFR-UUID: 20100930205135177.2B47B700008D@msfrf2111.sfr.fr From: dplu To: VDR Mailing List Date: Thu, 30 Sep 2010 22:51:34 +0200 User-Agent: KMail/1.9.7 References: <4BAA4EBA.4030406@free.fr> <201009302227.52837.jareguero@telefonica.net> <201009302240.34264.dplu@free.fr> In-Reply-To: <201009302240.34264.dplu@free.fr> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <201009302251.34816.dplu@free.fr> X-tubIT-Score: 0.0 () X-PMX-Version: 5.5.5.374460, Antispam-Engine: 2.7.1.369594, Antispam-Data: 2010.9.30.204215 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' FROM_NAME_ONE_WORD 0.05, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CD 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_MSGID 0, __INT_PROD_TV 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __PHISH_FROM 0, __PHISH_FROM1 0, __PHISH_FROM_F 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __USER_AGENT 0' X-LSpam-Score: -3.6 (---) X-LSpam-Report: No, score=-3.6 required=5.0 tests=BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1 autolearn=ham Subject: Re: [vdr] vdr xine-lib eac3 X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Sep 2010 20:51:37 -0000 Status: O X-Status: X-Keywords: X-UID: 23594 Here is the result of my colleague using vdr-sxfe verbose and changing the audio track [9665] [demux_vdr] audio stream changed: 03410000 -> 03410001 Erreur de segmentation (=segfault error) As you can see this is the same error , he use this patch We continue to investigate thanks for your help Le Thursday 30 September 2010 22:40:34 dplu, vous avez écrit : > I will add this patch to my xine-lib and rebuild all > > Here are two more samples to test given by colleague, I will also wait the > answer from Karim Afifi to have comparative tests > > http://dl.free.fr/mE6yTLPnx > http://dl.free.fr/u2dWSU5R8 > > Other idea : may it comes from my xine-ui version ? did you use a fresh one > from http://hg.debian.org/hg/xine-lib/xine-ui/ > > Many thanks for your help and have a nice evening > > Le Thursday 30 September 2010 22:27:52 Jose Alberto Reguero, vous avez écrit : > > The error you report doesn't matter. It is because there is no case for > > EAC3. I have an additional patch to use only two channels, and I don't > > have this error. You can use the patch and comment the line: > > this->context->request_channels = 2; > > and then you don't have the error. > > I try with the sample you give to me. If you want you can give me another > > sample. > > > > Jose Alberto > > > > El Jueves 30 Septiembre 2010, dplu escribió: > > > Hi > > > > > > In fact, I use a very recent ffmpeg (less than one month) and the very > > > latest xine-lib 1.2 with no patch except yours > > > > > > I found my error message in combined/ffmpeg/ff_audio_decoder.c > > > > > > This is strange that you cannot reproduce as long we (my colleague + > > > me) are able to have it every time and other user report this problem > > > using xlo plugin + sxfe (on French DVB forum) > > > > > > I can update my ffmpeg to the very latest release but not sure it will > > > change something (ffplay or mplayer works fine) > > > > > > Nobody else can test our sample please ? > > > > > > Have a nive evening > > > > > > Le Thursday 30 September 2010 20:10:54 Jose Alberto Reguero, vous avez > > > > écrit : > > > > I can change eac3 audio channel without problem. Perhaps you have > > > > additional patches that cause that. > > > > > > > > Jose Alberto > > > > > > > > El Miércoles 29 Septiembre 2010, Karim Afifi escribió: > > > > > Hello, > > > > > > > > > > Just to confirm that I've the same crash that dplu is talking > > > > > about, with xineliboutput here. It occurs : > > > > > - **Every time** I try to change audio track on "HD e-ac3" channel. > > > > > - Many time when I zap from "SD" to on "HD e-ac3" channel. > > > > > - Many time when I zap from HD "e-ac3" to on HD "e-ac3" channel. > > > > > - No problem when using "SD" and "HD no e-ac3" channels. > > > > > > > > > > Guys, many thanks for your job, I hope vdr will soon remain as > > > > > stable on "HD e-ac3" that with "SD" and "HD non e-ac3" channels. > > > > > > > > > > > > > > > Karim > > > > > > > > > > -----Message d'origine----- > > > > > De : vdr-bounces@linuxtv.org [mailto:vdr-bounces@linuxtv.org] De la > > > > > part de dplu > > > > > Envoyé : mercredi 29 septembre 2010 15:05 > > > > > À : VDR Mailing List > > > > > Objet : Re: [vdr] vdr xine-lib eac3 > > > > > > > > > > > > > > > Hi > > > > > > > > > > Thanks for the patch, works nice now. Did you try to change audio > > > > > channel ? I > > > > > have a strange error reported also by french colleague : > > > > > > > > > > ffmpeg_audio_dec: augmentation du buffer à 98304 pour éviter sa > > > > > saturation. (translation) => Increasing buffer size to 98304 to > > > > > prevent overflow ffmpeg_audio_dec: unknown header with buf type > > > > > 0x3410000 > > > > > > > > > > and xine-ui crash ... error in xiTK > > > > > > > > > > It happen when switching from fra to qaa (both e-ac3) and also when > > > > > switching > > > > > from ac3 live channels (like Einfestival HD or ITV HD) to records > > > > > having e-ac3 tracks. It is Ok when coming from a mpeg audio channel > > > > > (SD broadcast) > > > > > > > > > > I don't know if it is a xine problem sending bad information to > > > > > ffmpeg or a bug in ffmpeg ... changing audio track (with # key) do > > > > > not crash mplayer when > > > > > playing the TS file > > > > > > > > > > By the way, many thanks for your work ;o)) > > > > > > > > > > Best regards > > > > > > > > > > > > > > > Le Wednesday 29 September 2010 02:07:11 Jose Alberto Reguero, vous > > > > > avez > > > > > > > > > > écrit : > > > > > > Here is a new version of the patch. Now it works with the sample. > > > > > > There > > > > > > > > > > was > > > > > > > > > > > a bug in the last patch. > > > > > > > > > > > > Jose Alberto > > > > > > > > > > > > El Lunes 27 Septiembre 2010, dplu escribió: > > > > > > > Thanks for the test, In fact I am not in covered area so I work > > > > > > > with sample given by a colleague who live in good area on our > > > > > > > forum > > > > > > > > > > > > > > The sample is very fresh and works perfectly with xineliboutput > > > > > > > + vdr-sxfe with patch xineliboutputeac3_4.diff plus patch > > > > > > > ff_audio_decoder to downmix 5.1 to 2.0 > > > > > > > > > > > > > > Maybe is there "something" in TS who is different from your > > > > > > > country. It should be also interesting to have report from > > > > > > > Italian users who experiment this audio encoding (not all are > > > > > > > xbmc user I hope) > > > > > > > > > > > > > > Have a nice evening > > > > > > > > > > > > > > Best regards > > > > > > > > > > > > > > Le Monday 27 September 2010 22:42:06 Jose Alberto Reguero, vous > > > > > > > avez > > > > > > > > > > écrit : > > > > > > > > I try the sample and don't work. I look into it. But you must > > > > > > > > try live tv or samples made with the patches, to see if it > > > > > > > > work. I try here > > > > > > > > > > with > > > > > > > > > > > > > a channel whith eac3 with spectral extention and it work > > > > > > > > well. > > > > > > > > > > > > > > > > Jose Alberto > > > > > > > > > > > > > > _______________________________________________ > > > > > > > vdr mailing list > > > > > > > vdr@linuxtv.org > > > > > > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > > > > > > > _______________________________________________ > > > > > vdr mailing list > > > > > vdr@linuxtv.org > > > > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > > > > > > > > > > > > __________ Information provenant d'ESET Smart Security, version de > > > > > la base des signatures de virus 5488 (20100929) __________ > > > > > > > > > > Le message a été vérifié par ESET Smart Security. > > > > > > > > > > http://www.eset.com > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > vdr mailing list > > > > > vdr@linuxtv.org > > > > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > > > > > _______________________________________________ > > > > vdr mailing list > > > > vdr@linuxtv.org > > > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > > > _______________________________________________ > > > vdr mailing list > > > vdr@linuxtv.org > > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > _______________________________________________ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr diff -r cb99a1abe986 src/combined/ffmpeg/ff_audio_decoder.c --- a/src/combined/ffmpeg/ff_audio_decoder.c Fri Apr 09 18:55:47 2010 +0200 +++ b/src/combined/ffmpeg/ff_audio_decoder.c Sat Apr 10 16:23:14 2010 +0200 @@ -219,6 +219,12 @@ this->context->extradata_size); break; } + case BUF_AUDIO_EAC3: + case BUF_AUDIO_A52: + { + this->context->request_channels = 2; + break; + } default: xprintf(this->stream->xine, XINE_VERBOSITY_LOG, "ffmpeg_audio_dec: unknown header with buf type 0x%X\n", codec_type);