| Message ID | 201009302227.52837.jareguero@telefonica.net |
|---|---|
| State | New |
| Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.69) (envelope-from <jareguero@telefonica.net>) id 1P1PjQ-0000K8-My for vdr@linuxtv.org; Thu, 30 Sep 2010 22:27:57 +0200 X-tubIT-Incoming-IP: 213.4.138.1 Received: from impaqm1.telefonica.net ([213.4.138.1]) by mail.tu-berlin.de (exim-4.69/mailfrontend-b) with esmtp for <vdr@linuxtv.org> id 1P1PjQ-0001Au-6g; Thu, 30 Sep 2010 22:27:56 +0200 Received: from IMPmailhost2.adm.correo ([10.20.102.39]) by IMPaqm1.telefonica.net with bizsmtp id CvlA1f01T0r0BT6018TvwC; Thu, 30 Sep 2010 22:27:55 +0200 Received: from jar.dominio ([80.25.230.35]) by IMPmailhost2.adm.correo with BIZ IMP id D8Tu1f00K0mULeg1i8TvU5; Thu, 30 Sep 2010 22:27:55 +0200 X-Brightmail-Tracker: AAAAAA== X-TE-authinfo: authemail="jareguero$telefonica.net" |auth_email="jareguero@telefonica.net" X-TE-AcuTerraCos: auth_cuTerraCos="cosuitnetc01" From: Jose Alberto Reguero <jareguero@telefonica.net> To: VDR Mailing List <vdr@linuxtv.org> Date: Thu, 30 Sep 2010 22:27:52 +0200 User-Agent: KMail/1.13.5 (Linux/2.6.35; KDE/4.4.5; x86_64; ; ) References: <4BAA4EBA.4030406@free.fr> <201009302010.54923.jareguero@telefonica.net> <201009302137.06902.dplu@free.fr> In-Reply-To: <201009302137.06902.dplu@free.fr> MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_ILPpMsGdw6Ne7Rc" Message-Id: <201009302227.52837.jareguero@telefonica.net> X-tubIT-Score: 0.0 () X-PMX-Version: 5.5.4.371499, Antispam-Engine: 2.7.1.369594, Antispam-Data: 2010.9.30.201815 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MIME_TEXT_ONLY_MP_MIXED 0.05, BODY_SIZE_6000_6999 0, BODY_SIZE_7000_LESS 0, FROM_NAME_PHRASE 0, WEBMAIL_RCVD 0, WEBMAIL_SOURCE 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __CTYPE_MULTIPART_MIXED 0, __HAS_MSGID 0, __INT_PROD_TV 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __USER_AGENT 0' X-LSpam-Score: -3.4 (---) X-LSpam-Report: No, score=-3.4 required=5.0 tests=AWL=0.200, BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1 autolearn=ham Subject: Re: [vdr] vdr xine-lib eac3 X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: VDR Mailing List <vdr@linuxtv.org> List-Id: VDR Mailing List <vdr.linuxtv.org> List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/options/vdr>, <mailto:vdr-request@linuxtv.org?subject=unsubscribe> List-Archive: <http://www.linuxtv.org/pipermail/vdr> List-Post: <mailto:vdr@linuxtv.org> List-Help: <mailto:vdr-request@linuxtv.org?subject=help> List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=subscribe> X-List-Received-Date: Thu, 30 Sep 2010 20:27:57 -0000 Status: O X-Status: X-Keywords: X-UID: 23592 |
Commit Message
Jose Alberto Reguero
Sept. 30, 2010, 8:27 p.m. UTC
The error you report doesn't matter. It is because there is no case for EAC3. I have an additional patch to use only two channels, and I don't have this error. You can use the patch and comment the line: this->context->request_channels = 2; and then you don't have the error. I try with the sample you give to me. If you want you can give me another sample. Jose Alberto El Jueves 30 Septiembre 2010, dplu escribió: > Hi > > In fact, I use a very recent ffmpeg (less than one month) and the very > latest xine-lib 1.2 with no patch except yours > > I found my error message in combined/ffmpeg/ff_audio_decoder.c > > This is strange that you cannot reproduce as long we (my colleague + me) > are able to have it every time and other user report this problem using > xlo plugin + sxfe (on French DVB forum) > > I can update my ffmpeg to the very latest release but not sure it will > change something (ffplay or mplayer works fine) > > Nobody else can test our sample please ? > > Have a nive evening > > Le Thursday 30 September 2010 20:10:54 Jose Alberto Reguero, vous avez écrit : > > I can change eac3 audio channel without problem. Perhaps you have > > additional patches that cause that. > > > > Jose Alberto > > > > El Miércoles 29 Septiembre 2010, Karim Afifi escribió: > > > Hello, > > > > > > Just to confirm that I've the same crash that dplu is talking about, > > > with xineliboutput here. It occurs : > > > - **Every time** I try to change audio track on "HD e-ac3" channel. > > > - Many time when I zap from "SD" to on "HD e-ac3" channel. > > > - Many time when I zap from HD "e-ac3" to on HD "e-ac3" channel. > > > - No problem when using "SD" and "HD no e-ac3" channels. > > > > > > Guys, many thanks for your job, I hope vdr will soon remain as stable > > > on "HD e-ac3" that with "SD" and "HD non e-ac3" channels. > > > > > > > > > Karim > > > > > > -----Message d'origine----- > > > De : vdr-bounces@linuxtv.org [mailto:vdr-bounces@linuxtv.org] De la > > > part de dplu > > > Envoyé : mercredi 29 septembre 2010 15:05 > > > À : VDR Mailing List > > > Objet : Re: [vdr] vdr xine-lib eac3 > > > > > > > > > Hi > > > > > > Thanks for the patch, works nice now. Did you try to change audio > > > channel ? I > > > have a strange error reported also by french colleague : > > > > > > ffmpeg_audio_dec: augmentation du buffer à 98304 pour éviter sa > > > saturation. (translation) => Increasing buffer size to 98304 to prevent > > > overflow ffmpeg_audio_dec: unknown header with buf type 0x3410000 > > > > > > and xine-ui crash ... error in xiTK > > > > > > It happen when switching from fra to qaa (both e-ac3) and also when > > > switching > > > from ac3 live channels (like Einfestival HD or ITV HD) to records > > > having e-ac3 tracks. It is Ok when coming from a mpeg audio channel > > > (SD broadcast) > > > > > > I don't know if it is a xine problem sending bad information to ffmpeg > > > or a bug in ffmpeg ... changing audio track (with # key) do not crash > > > mplayer when > > > playing the TS file > > > > > > By the way, many thanks for your work ;o)) > > > > > > Best regards > > > > > > > > > Le Wednesday 29 September 2010 02:07:11 Jose Alberto Reguero, vous avez > > > > > > écrit : > > > > Here is a new version of the patch. Now it works with the sample. > > > > There > > > > > > was > > > > > > > a bug in the last patch. > > > > > > > > Jose Alberto > > > > > > > > El Lunes 27 Septiembre 2010, dplu escribió: > > > > > Thanks for the test, In fact I am not in covered area so I work > > > > > with sample given by a colleague who live in good area on our > > > > > forum > > > > > > > > > > The sample is very fresh and works perfectly with xineliboutput + > > > > > vdr-sxfe with patch xineliboutputeac3_4.diff plus patch > > > > > ff_audio_decoder to downmix 5.1 to 2.0 > > > > > > > > > > Maybe is there "something" in TS who is different from your > > > > > country. It should be also interesting to have report from Italian > > > > > users who experiment this audio encoding (not all are xbmc user I > > > > > hope) > > > > > > > > > > Have a nice evening > > > > > > > > > > Best regards > > > > > > > > > > Le Monday 27 September 2010 22:42:06 Jose Alberto Reguero, vous > > > > > avez > > > > > > écrit : > > > > > > I try the sample and don't work. I look into it. But you must try > > > > > > live tv or samples made with the patches, to see if it work. I > > > > > > try here > > > > > > with > > > > > > > > > a channel whith eac3 with spectral extention and it work well. > > > > > > > > > > > > Jose Alberto > > > > > > > > > > _______________________________________________ > > > > > vdr mailing list > > > > > vdr@linuxtv.org > > > > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > > > _______________________________________________ > > > vdr mailing list > > > vdr@linuxtv.org > > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > > > > > > __________ Information provenant d'ESET Smart Security, version de la > > > base des signatures de virus 5488 (20100929) __________ > > > > > > Le message a été vérifié par ESET Smart Security. > > > > > > http://www.eset.com > > > > > > > > > > > > > > > _______________________________________________ > > > vdr mailing list > > > vdr@linuxtv.org > > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > _______________________________________________ > > vdr mailing list > > vdr@linuxtv.org > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > _______________________________________________ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Comments
I will add this patch to my xine-lib and rebuild all Here are two more samples to test given by colleague, I will also wait the answer from Karim Afifi to have comparative tests http://dl.free.fr/mE6yTLPnx http://dl.free.fr/u2dWSU5R8 Other idea : may it comes from my xine-ui version ? did you use a fresh one from http://hg.debian.org/hg/xine-lib/xine-ui/ Many thanks for your help and have a nice evening Le Thursday 30 September 2010 22:27:52 Jose Alberto Reguero, vous avez écrit : > The error you report doesn't matter. It is because there is no case for > EAC3. I have an additional patch to use only two channels, and I don't have > this error. You can use the patch and comment the line: > this->context->request_channels = 2; > and then you don't have the error. > I try with the sample you give to me. If you want you can give me another > sample. > > Jose Alberto > > El Jueves 30 Septiembre 2010, dplu escribió: > > Hi > > > > In fact, I use a very recent ffmpeg (less than one month) and the very > > latest xine-lib 1.2 with no patch except yours > > > > I found my error message in combined/ffmpeg/ff_audio_decoder.c > > > > This is strange that you cannot reproduce as long we (my colleague + me) > > are able to have it every time and other user report this problem using > > xlo plugin + sxfe (on French DVB forum) > > > > I can update my ffmpeg to the very latest release but not sure it will > > change something (ffplay or mplayer works fine) > > > > Nobody else can test our sample please ? > > > > Have a nive evening > > > > Le Thursday 30 September 2010 20:10:54 Jose Alberto Reguero, vous avez > > écrit : > > > I can change eac3 audio channel without problem. Perhaps you have > > > additional patches that cause that. > > > > > > Jose Alberto > > > > > > El Miércoles 29 Septiembre 2010, Karim Afifi escribió: > > > > Hello, > > > > > > > > Just to confirm that I've the same crash that dplu is talking about, > > > > with xineliboutput here. It occurs : > > > > - **Every time** I try to change audio track on "HD e-ac3" channel. > > > > - Many time when I zap from "SD" to on "HD e-ac3" channel. > > > > - Many time when I zap from HD "e-ac3" to on HD "e-ac3" channel. > > > > - No problem when using "SD" and "HD no e-ac3" channels. > > > > > > > > Guys, many thanks for your job, I hope vdr will soon remain as stable > > > > on "HD e-ac3" that with "SD" and "HD non e-ac3" channels. > > > > > > > > > > > > Karim > > > > > > > > -----Message d'origine----- > > > > De : vdr-bounces@linuxtv.org [mailto:vdr-bounces@linuxtv.org] De la > > > > part de dplu > > > > Envoyé : mercredi 29 septembre 2010 15:05 > > > > À : VDR Mailing List > > > > Objet : Re: [vdr] vdr xine-lib eac3 > > > > > > > > > > > > Hi > > > > > > > > Thanks for the patch, works nice now. Did you try to change audio > > > > channel ? I > > > > have a strange error reported also by french colleague : > > > > > > > > ffmpeg_audio_dec: augmentation du buffer à 98304 pour éviter sa > > > > saturation. (translation) => Increasing buffer size to 98304 to > > > > prevent overflow ffmpeg_audio_dec: unknown header with buf type > > > > 0x3410000 > > > > > > > > and xine-ui crash ... error in xiTK > > > > > > > > It happen when switching from fra to qaa (both e-ac3) and also when > > > > switching > > > > from ac3 live channels (like Einfestival HD or ITV HD) to records > > > > having e-ac3 tracks. It is Ok when coming from a mpeg audio channel > > > > (SD broadcast) > > > > > > > > I don't know if it is a xine problem sending bad information to > > > > ffmpeg or a bug in ffmpeg ... changing audio track (with # key) do > > > > not crash mplayer when > > > > playing the TS file > > > > > > > > By the way, many thanks for your work ;o)) > > > > > > > > Best regards > > > > > > > > > > > > Le Wednesday 29 September 2010 02:07:11 Jose Alberto Reguero, vous > > > > avez > > > > > > > > écrit : > > > > > Here is a new version of the patch. Now it works with the sample. > > > > > There > > > > > > > > was > > > > > > > > > a bug in the last patch. > > > > > > > > > > Jose Alberto > > > > > > > > > > El Lunes 27 Septiembre 2010, dplu escribió: > > > > > > Thanks for the test, In fact I am not in covered area so I work > > > > > > with sample given by a colleague who live in good area on our > > > > > > forum > > > > > > > > > > > > The sample is very fresh and works perfectly with xineliboutput + > > > > > > vdr-sxfe with patch xineliboutputeac3_4.diff plus patch > > > > > > ff_audio_decoder to downmix 5.1 to 2.0 > > > > > > > > > > > > Maybe is there "something" in TS who is different from your > > > > > > country. It should be also interesting to have report from > > > > > > Italian users who experiment this audio encoding (not all are > > > > > > xbmc user I hope) > > > > > > > > > > > > Have a nice evening > > > > > > > > > > > > Best regards > > > > > > > > > > > > Le Monday 27 September 2010 22:42:06 Jose Alberto Reguero, vous > > > > > > avez > > > > > > > > écrit : > > > > > > > I try the sample and don't work. I look into it. But you must > > > > > > > try live tv or samples made with the patches, to see if it > > > > > > > work. I try here > > > > > > > > with > > > > > > > > > > > a channel whith eac3 with spectral extention and it work well. > > > > > > > > > > > > > > Jose Alberto > > > > > > > > > > > > _______________________________________________ > > > > > > vdr mailing list > > > > > > vdr@linuxtv.org > > > > > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > > > > > _______________________________________________ > > > > vdr mailing list > > > > vdr@linuxtv.org > > > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > > > > > > > > > __________ Information provenant d'ESET Smart Security, version de la > > > > base des signatures de virus 5488 (20100929) __________ > > > > > > > > Le message a été vérifié par ESET Smart Security. > > > > > > > > http://www.eset.com > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > vdr mailing list > > > > vdr@linuxtv.org > > > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > > > _______________________________________________ > > > vdr mailing list > > > vdr@linuxtv.org > > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > _______________________________________________ > > vdr mailing list > > vdr@linuxtv.org > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
diff -r 9679028a161b src/combined/ffmpeg/ff_audio_decoder.c --- a/src/combined/ffmpeg/ff_audio_decoder.c Wed Jul 21 15:52:00 2010 +0000 +++ b/src/combined/ffmpeg/ff_audio_decoder.c Thu Sep 30 20:05:45 2010 +0200 @@ -219,6 +220,11 @@ this->context->extradata_size); break; } + case BUF_AUDIO_EAC3: + { + this->context->request_channels = 2; + break; + } default: xprintf(this->stream->xine, XINE_VERBOSITY_LOG, "ffmpeg_audio_dec: unknown header with buf type 0x%X\n", codec_type);