What about vdr-1.6.1?

Message ID 200906161203.00074.zzam@gentoo.org
State New
Headers

Commit Message

Matthias Schwarzott June 16, 2009, 10:02 a.m. UTC
  On Dienstag, 16. Juni 2009, Joachim Welker wrote:
> Hi Klaus,
> I see you are very busy in developing the new vdr-1.7.* (thanks for your
> great work !). But what about stable vdr-1.6.0? You released two patches
> which should result in version vdr-1.6.1. AFAIR there were no complaints
> about these patches, so I think it's save to release vdr-1.6.1 in order to
> rule off the last stable version.
>
Well, if the goal is to release a vdr-1.6.1 version,
I suggest to first collect further patches needed to compile it on recent 
systems:
* compiling with gcc-4.4 and glibc-2.10: fixing some variable const issues and 
some other warnings
* compiling against linux-headers with s2api (api version 5)

The gentoo versions of these patches are attached.
The gcc-4.4 patch is based on Ludwig Nussels version plus improvments of 
Klaus. The last const_cast is replaced by using the fileName member of 
cRecording as cRecordings is a friend class.

I don't know if more fixes are floating around that need to be applied.

Regards
Matthias
  

Comments

VDRU VDRU June 16, 2009, 1:14 p.m. UTC | #1
The patch vdr-dvb-api-5-is-fine.diff is not a proper "fix" iirc.
  
Matthias Schwarzott June 16, 2009, 7:08 p.m. UTC | #2
On Dienstag, 16. Juni 2009, VDR User wrote:
> The patch vdr-dvb-api-5-is-fine.diff is not a proper "fix" iirc.
Ok, so where is the problem, and how should a proper fix look like?

Regards
Matthias
  

Patch

diff -ru vdr-1.6.0-orig/dvbdevice.h vdr-1.6.0/dvbdevice.h
--- vdr-1.6.0-orig/dvbdevice.h	2009-01-12 14:05:10.000000000 +0100
+++ vdr-1.6.0/dvbdevice.h	2009-01-12 14:05:52.000000000 +0100
@@ -15,7 +15,7 @@ 
 #include "device.h"
 #include "dvbspu.h"
 
-#if DVB_API_VERSION != 3
+#if (DVB_API_VERSION != 3) && (DVB_API_VERSION != 5)
 #error VDR requires Linux DVB driver API version 3!
 #endif