TeVii S650 missing remote keys PATCH

  On 13 June 2009 14:19:57 gimli wrote:
> Perfect ;)
>
> you need a :
>
> signed-off-by: Edgar Hucek < gimli at dark-green dot com >
>
> ?
>
> > On 13 June 2009 13:35:04 gimli wrote:
> >> Hi,
> >>
> >> i use the TeVii Firmware from the TeVii driver package :
> >> http://tevii.com/Tevii_linuxdriver_0815.rar
> >>
> >> dvb-fe-cx24116.fw and dvb-usb-s650.fw renamed to dvb-usb-dw2104.fw.
> >>
> >> You where right about the double mapping, this line can be removed.
> >> basicly it should not harm the existing mapping since you loop over and
> >> break on the first occurance.
> >
> > So, I will remove the line.
> >
> >> cu
> >>
> >> Edgar (gimli) Hucek
> >>
> >> > On 12 June 2009 21:50:15 gimli wrote:
> >> >> Hi,
> >> >>
> >> >> the attached patch is against :
> >> >> http://mercurial.intuxication.org/hg/s2-liplianin
> >> >>
> >> >> It adds the missing remote keys found on the TeVii Remote for the
> >>
> >> S650
> >>
> >> >> usb
> >> >> device.
> >> >>
> >> >> Now i have the remote fully working ;)
> >> >>
> >> >> cu
> >> >>
> >> >> Edgar (gimli) Hucek
> >> >
> >> > Hi Edgar,
> >> > Found bug, you are remapping already mapped key 0x1e
> >> > It breaks non-TeVii remotes.
> >> > Look at snip of your patch:
> >> >
> >> >  	{ 0xf8, 0x1e, KEY_W },		/*tvmode*/
> >> >  	{ 0xf8, 0x1b, KEY_B },		/*recall*/
> >> >
> >> > +	/* Keys the TeVii S650 provides */
> >> > +
> >> > +        { 0xf8, 0x1e, KEY_REWIND },
> >> >
> >> > BTW, which USB fimware are you using?
> >> >
> >> > Igor
> >>
> >> _______________________________________________
> >> vdr mailing list
> >> vdr@linuxtv.org
> >> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
> >
> > --
> > Igor M. Liplianin
> > Microsoft Windows Free Zone - Linux used for all Computing Tasks
I corrected you patch. Look at it, before I commit it.
  

> On 13 June 2009 14:19:57 gimli wrote:
>> Perfect ;)
>>
>> you need a :
>>
>> signed-off-by: Edgar Hucek < gimli at dark-green dot com >
>>
>> ?
>>
>> > On 13 June 2009 13:35:04 gimli wrote:
>> >> Hi,
>> >>
>> >> i use the TeVii Firmware from the TeVii driver package :
>> >> http://tevii.com/Tevii_linuxdriver_0815.rar
>> >>
>> >> dvb-fe-cx24116.fw and dvb-usb-s650.fw renamed to dvb-usb-dw2104.fw.
>> >>
>> >> You where right about the double mapping, this line can be removed.
>> >> basicly it should not harm the existing mapping since you loop over
>> and
>> >> break on the first occurance.
>> >
>> > So, I will remove the line.
>> >
>> >> cu
>> >>
>> >> Edgar (gimli) Hucek
>> >>
>> >> > On 12 June 2009 21:50:15 gimli wrote:
>> >> >> Hi,
>> >> >>
>> >> >> the attached patch is against :
>> >> >> http://mercurial.intuxication.org/hg/s2-liplianin
>> >> >>
>> >> >> It adds the missing remote keys found on the TeVii Remote for the
>> >>
>> >> S650
>> >>
>> >> >> usb
>> >> >> device.
>> >> >>
>> >> >> Now i have the remote fully working ;)
>> >> >>
>> >> >> cu
>> >> >>
>> >> >> Edgar (gimli) Hucek
>> >> >
>> >> > Hi Edgar,
>> >> > Found bug, you are remapping already mapped key 0x1e
>> >> > It breaks non-TeVii remotes.
>> >> > Look at snip of your patch:
>> >> >
>> >> >  	{ 0xf8, 0x1e, KEY_W },		/*tvmode*/
>> >> >  	{ 0xf8, 0x1b, KEY_B },		/*recall*/
>> >> >
>> >> > +	/* Keys the TeVii S650 provides */
>> >> > +
>> >> > +        { 0xf8, 0x1e, KEY_REWIND },
>> >> >
>> >> > BTW, which USB fimware are you using?
>> >> >
>> >> > Igor
>> >>
>> >> _______________________________________________
>> >> vdr mailing list
>> >> vdr@linuxtv.org
>> >> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
>> >
>> > --
>> > Igor M. Liplianin
>> > Microsoft Windows Free Zone - Linux used for all Computing Tasks
> I corrected you patch. Look at it, before I commit it.
>
> --
> Igor M. Liplianin
> Microsoft Windows Free Zone - Linux used for all Computing Tasks
>

Checked the patch and it's fine for me ;)

cu

Edgar (gimli) Hucek