From patchwork Fri Jan 2 22:35:01 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Ville_Skytt=C3=A4?= X-Patchwork-Id: 12689 Received: from smtp5.welho.com ([213.243.153.39]) by www.linuxtv.org with esmtp (Exim 4.63) (envelope-from ) id 1LIsbi-0004yQ-2H for vdr@linuxtv.org; Fri, 02 Jan 2009 23:35:07 +0100 Received: from viper.bobcat.mine.nu (cs181072155.pp.htv.fi [82.181.72.155]) by smtp5.welho.com (Postfix) with ESMTP id 8E23B5BC009 for ; Sat, 3 Jan 2009 00:35:02 +0200 (EET) From: Ville =?iso-8859-1?q?Skytt=E4?= To: VDR Mailing List Date: Sat, 3 Jan 2009 00:35:01 +0200 User-Agent: KMail/1.9.10 References: <200901021912.09103.ville.skytta@iki.fi> <495E5106.2070801@willies.info> In-Reply-To: <495E5106.2070801@willies.info> MIME-Version: 1.0 Message-Id: <200901030035.02510.ville.skytta@iki.fi> X-LSpam-Score: -2.2 (--) X-LSpam-Report: No, score=-2.2 required=5.0 tests=AWL=0.350, BAYES_00=-2.599 autolearn=ham Subject: Re: [vdr] [ANNOUNCE] vdr-dxr3 0.2.9 X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.9 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jan 2009 22:35:07 -0000 Status: O X-Status: X-Keywords: X-UID: 18985 On Friday 02 January 2009, Jan Willies wrote: > Is there a way to apply the brightness/contrast settings on VDR-start? > Currently I have to go to Menu->System->Plugins->Dxr3 and press OK after > every start of VDR. Hm, the configured values do get saved but I have no idea why there's no code to apply them at startup. The attached patch should fix that. > And, can I apply these settings without starting > VDR, maybe via an entry in /sys/class/em8300 (like the zoom stuff)? I don't think so. But I suppose it would be fairly easy to implement in the driver - post a request for enhancement to the dxr3-devel mailing list? Index: dxr3interface.c =================================================================== RCS file: /cvsroot/dxr3plugin/dxr3/dxr3interface.c,v retrieving revision 1.4.2.39 diff -u -r1.4.2.39 dxr3interface.c --- dxr3interface.c 29 Dec 2008 21:21:31 -0000 1.4.2.39 +++ dxr3interface.c 2 Jan 2009 22:28:01 -0000 @@ -1046,6 +1046,17 @@ exit(1); } + // set brightness/contrast/saturation + m_bcs.brightness = cDxr3ConfigData::Instance().GetBrightness(); + m_bcs.contrast = cDxr3ConfigData::Instance().GetContrast(); + m_bcs.saturation = cDxr3ConfigData::Instance().GetSaturation(); + dsyslog("dxr3: configure: brightness=%d,contrast=%d,saturation=%d", + m_bcs.brightness, m_bcs.contrast, m_bcs.saturation); + if (ioctl(m_fdControl, EM8300_IOCTL_SETBCS, &m_bcs) < 0) + { + esyslog("dxr3: unable to set brightness/contrast/saturation: %m"); + } + ConfigureDeviceAudio(); }