From patchwork Tue Dec 23 08:14:37 2008
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Wolfgang Rohdewald <wolfgang@rohdewald.de>
X-Patchwork-Id: 12687
Received: from mo-p00-ob.rzone.de ([81.169.146.162])
	by www.linuxtv.org with esmtp (Exim 4.63)
	(envelope-from <wolfgang@rohdewald.de>) id 1LF2R3-0005Ci-Fv
	for vdr@linuxtv.org; Tue, 23 Dec 2008 09:16:14 +0100
X-RZG-CLASS-ID: mo00
X-RZG-AUTH: :O2MIc0epdfgAjoV+frHI3UhxNCLBO5P+YS73lHhJYRD2uAuzaM+5N8MTp/b1LXul
Received: from notebook.localnet (p5B3E2A40.dip0.t-ipconnect.de
	[91.62.42.64]) by post.strato.de (mrclete mo15) (RZmta 18.4)
	with ESMTP id U05c71kBN7ca1R for <vdr@linuxtv.org>;
	Tue, 23 Dec 2008 09:16:09 +0100 (MET)
From: Wolfgang Rohdewald <wolfgang@rohdewald.de>
To: vdr@linuxtv.org
Date: Tue, 23 Dec 2008 09:14:37 +0100
User-Agent: KMail/1.10.3 (Linux/2.6.27-9-generic; KDE/4.1.3; i686; ; )
References: <200812212055.55826.wolfgang@rohdewald.de>
	<49500B46.7000203@gmx.de> <495018B6.2080208@cadsoft.de>
In-Reply-To: <495018B6.2080208@cadsoft.de>
MIME-Version: 1.0
Message-Id: <200812230914.37690.wolfgang@rohdewald.de>
X-LSpam-Score: -2.6 (--)
X-LSpam-Report: No, score=-2.6 required=5.0 tests=AWL=0.000,
	BAYES_00=-2.599 autolearn=ham
Subject: Re: [vdr] incompatibiliy between radio plugin and all mp3 plugins
X-BeenThere: vdr@linuxtv.org
X-Mailman-Version: 2.1.9
Precedence: list
Reply-To: wolfgang@rohdewald.de, VDR Mailing List <vdr@linuxtv.org>
List-Id: VDR Mailing List <vdr.linuxtv.org>
List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=unsubscribe>
List-Archive: <http://www.linuxtv.org/pipermail/vdr>
List-Post: <mailto:vdr@linuxtv.org>
List-Help: <mailto:vdr-request@linuxtv.org?subject=help>
List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Dec 2008 08:16:14 -0000
Status: O
X-Status: 
X-Keywords: 
X-UID: 18912

On Montag, 22. Dezember 2008, Klaus Schmidinger wrote:
> On 22.12.2008 22:48, Stefan Huelswitt wrote:
> > 
> > Wolfgang Rohdewald schrieb:
> > 
> > Hello,
> > 
> >> in cPluginRadio::Replaying(), radio.c expects the replayed recording
> >> to be
> >> a VDR record. But mp3plugins like mp3, music, muggle use this
> >> mechanism for
> >> simple audio files.
> > 
> > Klaus, could you clarify if the filename passed to
> > cStatus:MsgReplaying() is supposed to be a VDR recording only or if it
> > may be the filename of any kind of media file involved?
> 
> It's not limited to VDR recordings:

The radio plugin author Uwe already sent me a private mail with a fix
for his plugin. Attached.

diff -ru radio-0.2.4.org/radio.c radio-0.2.4/radio.c
--- radio-0.2.4.org/radio.c	2007-10-09 18:15:35.000000000 +0200
+++ radio-0.2.4/radio.c	2008-12-22 11:44:16.000000000 +0100
@@ -710,6 +710,9 @@
     bool isRadio = false;
 
     if (On && FileName != NULL) {
+    	char *vdrfile;
+	asprintf(&vdrfile, "%s/001.vdr", FileName);
+	if (file_exists(vdrfile)) {			// check only VDR-Recordings
 		cFileName fn(FileName, false, true);
 		cUnbufferedFile *f = fn.Open();
 		if (f) {
@@ -719,6 +722,8 @@
 		    isRadio = (b[0] == 0x00) && (b[1] == 0x00) && (b[2] == 0x01) && (0xc0 <= b[3] && b[3] <= 0xdf);
 		    }
 		}
+	free(vdrfile);
+	}
 
     if (isRadio) {
 		if (!file_exists(ReplayFile))