From patchwork Sun Apr 13 08:29:49 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stefan Lucke X-Patchwork-Id: 12647 Received: from einhorn.in-berlin.de ([192.109.42.8] ident=root) by www.linuxtv.org with esmtp (Exim 4.63) (envelope-from ) id 1Jkxb4-0005Ee-CK for vdr@linuxtv.org; Sun, 13 Apr 2008 10:29:59 +0200 X-Envelope-From: stefan@lucke.in-berlin.de X-Envelope-To: Received: from jarada.farpoint.de (p57BB6E35.dip.t-dialin.net [87.187.110.53]) (authenticated bits=0) by einhorn.in-berlin.de (8.13.6/8.13.6/Debian-1) with ESMTP id m3D8ToJt026002 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sun, 13 Apr 2008 10:29:50 +0200 From: Stefan Lucke To: vdr@linuxtv.org Date: Sun, 13 Apr 2008 10:29:49 +0200 User-Agent: KMail/1.9.7 References: <4FC68593-C763-41F2-9F19-16FF01436604@gmail.com> <200804090854.56839.stefan@lucke.in-berlin.de> <4800C2EE.3010802@cadsoft.de> In-Reply-To: <4800C2EE.3010802@cadsoft.de> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200804131029.49780.stefan@lucke.in-berlin.de> X-Scanned-By: MIMEDefang_at_IN-Berlin_e.V. on 192.109.42.8 X-MIME-Autoconverted: from 8bit to quoted-printable by einhorn.in-berlin.de id m3D8ToJt026002 X-LSpam-Score: -2.6 (--) X-LSpam-Report: No, score=-2.6 required=5.0 tests=BAYES_00=-2.599 autolearn=ham Subject: Re: [vdr] VDR 1.5.17 - pre 1.3.19 compatibility mode problems X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.9 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Apr 2008 08:29:59 -0000 Status: O X-Status: X-Keywords: X-UID: 16470 On Saturday 12 April 2008, Klaus Schmidinger wrote: > On 04/09/08 08:54, Stefan Lucke wrote: > > On Wednesday 05 March 2008, Klaus Schmidinger wrote: > >> On 03/04/08 10:58, Tero Siironen wrote: > >>> Hi, > >>> > >>> I upgraded from VDR 1.4.7 to 1.5.17 and noticed that some of my old > >>> recordings won't play decently with this new version. Here's a syslog > >>> entry and example clip can be found from http://kotisivu.suomi.net/izero/vdr-darwin/ddmode_example.zip > >>> (9MB) > >>> > >>> Those problematic recordings were done with some 1.3.x series VDR with > >>> ttxtsubs plugin in fall 2004. Plays fine with VDR 1.4.7, but playback > >>> stutters when playing with VDR 1.5.17. My system has DVB-C FF 2.1 and > >>> DVB-C budget cards. Running on Fedora 5. > >> My guess would be that the offending data comes from the ttxtsubs plugin. > >> Maybe you need to patch VDR to become aware of this. > > > > My guess is that this is introduced by vdr-1.5.11 > > > > Original vdr-1.6.0: > > Apr 9 08:29:38 jarada vdr: [7997] replay /net_data/video/Extra/Enterprise_1/%1-01_Aufbruch_ins_Unbekannte_-_Teil_1/2004-01-31.19:05.99.99.rec > > Apr 9 08:29:38 jarada vdr: [7997] playing '/net_data/video/Extra/Enterprise_1/%1-01_Aufbruch_ins_Unbekannte_-_Teil_1/2004-01-31.19:05.99.99.rec/001.vdr' > > Apr 9 08:29:38 jarada vdr: [7997] loading /net_data/video/Extra/Enterprise_1/%1-01_Aufbruch_ins_Unbekannte_-_Teil_1/2004-01-31.19:05.99.99.rec//marks.vdr > > Apr 9 08:29:38 jarada vdr: [8019] dvbplayer thread started (pid=7997, tid=8019) > > Apr 9 08:29:38 jarada vdr: [8020] non blocking file reader thread started (pid=7997, tid=8020) > > Apr 9 08:29:38 jarada vdr: [8019] unknown PS1 packet, substream id = EB (counter is at 0) > > Apr 9 08:29:38 jarada vdr: [8019] unknown PS1 packet, substream id = 0B (counter is at 1) > > Attached pach fixes this problem for me. > > Your patch changed two things: the MIN_PRE_1_3_19_PRIVATESTREAM stuff, which merely > made detection of pre 1.3.19 Dolby Digital data more reliable, and the (Data[7] & 0x01) > check in "// Compatibility mode for old subtitles plugin:". I assume that the latter one > is what's causing your problems. > > Can you please reinstate the MIN_PRE_1_3_19_PRIVATESTREAM stuff and check whether just > leaving out the (Data[7] & 0x01) check is enough to fix this? I guess you meant the following change only: With this change it is still the same issue: no sound at all. Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 62 (counter is at 8) Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = DA (counter is at 9) Apr 13 09:48:11 jarada vdr: [7765] switching to pre 1.3.19 Dolby Digital compatibility mode - substream id = DA Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = DA (counter is at 0) Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 41 (counter is at 0) Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 0B (counter is at 1) Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = D6 (counter is at 2) Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = C6 (counter is at 2) Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 5A (counter is at 3) Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 0B (counter is at 4) Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 6C (counter is at 4) Wondering why the are different substream ids are reported with the same counter value ;-). > > This additional check was suggested by Marco Schlüßler, so maybe he can comment > on this and maybe find out why this is interfering with the pre 1.3.19 Dolby Digital > detection? > Stefan Lucke --- device.c.orig 2008-03-09 11:03:34.000000000 +0100 +++ device.c 2008-04-12 17:30:45.000000000 +0200 @@ -1265,7 +1265,7 @@ int PayloadOffset = Data[8] + 9; // Compatibility mode for old subtitles plugin: - if ((Data[7] & 0x01) && (Data[PayloadOffset - 3] & 0x81) == 0x01 && Data[PayloadOffset - 2] == 0x81) + if ((Data[PayloadOffset - 3] & 0x81) == 1 && Data[PayloadOffset - 2] == 0x81) PayloadOffset--; uchar SubStreamId = Data[PayloadOffset];