From patchwork Mon Jan 21 22:44:55 2008
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: =?utf-8?q?Ville_Skytt=C3=A4?= <ville.skytta@iki.fi>
X-Patchwork-Id: 12586
Received: from smtp4.pp.htv.fi ([213.243.153.38])
	by www.linuxtv.org with esmtp (Exim 4.63)
	(envelope-from <ville.skytta@iki.fi>) id 1JH5Nx-000650-Kv
	for vdr@linuxtv.org; Mon, 21 Jan 2008 23:44:57 +0100
Received: from viper.bobcat.mine.nu (cs181043142.pp.htv.fi [82.181.43.142])
	by smtp4.pp.htv.fi (Postfix) with ESMTP id D02525BC02C;
	Tue, 22 Jan 2008 00:44:56 +0200 (EET)
From: Ville =?iso-8859-1?q?Skytt=E4?= <ville.skytta@iki.fi>
To: vdr@linuxtv.org
Date: Tue, 22 Jan 2008 00:44:55 +0200
User-Agent: KMail/1.9.6 (enterprise 0.20071204.744707)
References: <4794F2F2.6020501@heiligenmann.net>
In-Reply-To: <4794F2F2.6020501@heiligenmann.net>
MIME-Version: 1.0
Message-Id: <200801220044.56496.ville.skytta@iki.fi>
Subject: Re: [vdr] [ANNOUNCE] WAPD Plugin 0.9
X-BeenThere: vdr@linuxtv.org
X-Mailman-Version: 2.1.9
Precedence: list
Reply-To: VDR Mailing List <vdr@linuxtv.org>
List-Id: VDR Mailing List <vdr.linuxtv.org>
List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=unsubscribe>
List-Archive: <http://www.linuxtv.org/pipermail/vdr>
List-Post: <mailto:vdr@linuxtv.org>
List-Help: <mailto:vdr-request@linuxtv.org?subject=help>
List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Jan 2008 22:44:57 -0000
Status: O
X-Status: 
X-Keywords: 
X-UID: 15233

On Monday 21 January 2008, Thomas Heiligenmann wrote:
> A new version of the plugin is available:
>
> Download: http://www.heiligenmann.de/vdr/download/
> Filename: vdr-wapd-0.9.tgz
> Filesize: 31975
>
> See HISTORY and README for details. Thanks to all, who have provided
> ideas and patches.

Here are some small patches for the next version:

- i18n: fixes some missing translatable strings, adds missing/improves
  existing Finnish translations
- headers: adds missing HTTP headers to the "access denied" response
- signedness: fixes (un)signedness of source port format conversion
  in "connect from" log message - ntohs returns an uint16_t

diff -up wapd-0.9/access.c~ wapd-0.9/access.c
--- wapd-0.9/access.c~	2008-01-13 14:41:21.000000000 +0200
+++ wapd-0.9/access.c	2008-01-22 00:14:46.000000000 +0200
@@ -217,7 +217,7 @@ int cWapSocket::Accept(void)
            close(newsock);
            newsock = -1;
         }
-        isyslog("WAPD: connect from %s, port %hd - %s", inet_ntoa(clientname.sin_addr), ntohs(clientname.sin_port), accepted ? "accepted" : "DENIED");
+        isyslog("WAPD: connect from %s, port %hu - %s", inet_ntoa(clientname.sin_addr), ntohs(clientname.sin_port), accepted ? "accepted" : "DENIED");
      } else if (errno != EINTR && errno != EAGAIN)
         LOG_ERROR;
      return newsock;