Help - can't get dvd-plugin to compile!

Message ID 200712192126.24158.ville.skytta@iki.fi
State New
Headers

Commit Message

Ville Skyttä Dec. 19, 2007, 7:26 p.m. UTC
  On Wednesday 19 December 2007, Simon Baxter wrote:
> Can anyone please help?  I had no response to my last posting - thought I'd
> try again!
>
> I've now rebuilt (again) now with 2.6.23.1-49.fc8   (Fedora Core 8)
>
> I'm now getting a new error trying to build vdr-dvd (see below)
>
> I did find this error:
> http://qa.mandriva.com/show_bug.cgi?id=35140
>
> but I can't work out what I need to add the "#include <inttypes.h>"  ?
>
> Can anyone help?

Did you also try to add -D__STDC_LIMIT_MACROS into CXXFLAGS like the bug 
report you quote advices?  Works for me that way, but I think DEFINES is more 
appropriate for that than CXXFLAGS, see attached patch.
  

Comments

Linux TV Dec. 20, 2007, 2:39 a.m. UTC | #1
> On Wednesday 19 December 2007, Simon Baxter wrote:
>> Can anyone please help?  I had no response to my last posting - thought
>> I'd
>> try again!
>>
>> I've now rebuilt (again) now with 2.6.23.1-49.fc8   (Fedora Core 8)
>>
>> I'm now getting a new error trying to build vdr-dvd (see below)
>>
>> I did find this error:
>> http://qa.mandriva.com/show_bug.cgi?id=35140
>>
>> but I can't work out what I need to add the "#include <inttypes.h>"  ?
>>
>> Can anyone help?
>
> Did you also try to add -D__STDC_LIMIT_MACROS into CXXFLAGS like the bug
> report you quote advices?  Works for me that way, but I think DEFINES is
> more
> appropriate for that than CXXFLAGS, see attached patch.

Thanks.  Latest cvs and your suggested changes, and I'm good.
  

Patch

Index: Makefile
===================================================================
RCS file: /cvsroot/dvdplugin/dvd/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- Makefile	2 May 2006 17:52:46 -0000	1.5
+++ Makefile	19 Dec 2007 19:21:45 -0000
@@ -43,7 +43,7 @@ 
 
 INCLUDES += -I$(VDRDIR)/include -I$(NAVDIR)
 
-DEFINES += -D_GNU_SOURCE -DPLUGIN_NAME_I18N='"$(PLUGIN)"'
+DEFINES += -D_GNU_SOURCE -DPLUGIN_NAME_I18N='"$(PLUGIN)"' -D__STDC_LIMIT_MACROS
 
 # to use xine videoout:
 ifdef POLLTIMEOUTS_BEFORE_DEVICECLEAR
Index: player-dvd.h
===================================================================
RCS file: /cvsroot/dvdplugin/dvd/player-dvd.h,v
retrieving revision 1.32
diff -u -r1.32 player-dvd.h
--- player-dvd.h	17 Sep 2007 19:04:43 -0000	1.32
+++ player-dvd.h	19 Dec 2007 19:21:46 -0000
@@ -11,6 +11,8 @@ 
 #ifndef __PLAYER_DVD_H
 #define __PLAYER_DVD_H
 
+#include <inttypes.h>
+
 #include <dvdnav/dvdnav.h>
 #include <dvdnav/dvdnav_events.h>