Fix Pid not available error in the streamdev plugin VDR-VDR connection

Message ID 200712151548.21587.jareguero@telefonica.net
State New
Headers

Commit Message

Jose Alberto Reguero Dec. 15, 2007, 2:48 p.m. UTC
  This patch fix the error "Pid xxx not available" in the streamdev plugin with 
VDR-VDR connection, that cause not tunning to the channel.
The problem is that sometimes, when cConnectionVTP::CmdADDP is called, 
m_LiveStreamer is NULL, and then return an errorr.
m_LiveStreamer became null in cConnectionVTP::CmdABRT that is called from 
cStreamdevDevice::CloseDvrInt called from cStreamdevDevice::CloseDvr.

Jose Alberto
  

Comments

Frank Schmirler Dec. 17, 2007, 4:24 p.m. UTC | #1
On Sat, 15 Dec 2007 15:48:21 +0100, Jose Alberto Reguero wrote
> This patch fix the error "Pid xxx not available" in the streamdev 
> plugin with VDR-VDR connection, that cause not tunning to the 
> channel. The problem is that sometimes, when cConnectionVTP::CmdADDP 
> is called, m_LiveStreamer is NULL, and then return an errorr. 
> m_LiveStreamer became null in cConnectionVTP::CmdABRT that is called 
> from cStreamdevDevice::CloseDvrInt called from cStreamdevDevice::CloseDvr.

Guess you refer to this problem:
http://www.vdr-developer.org/mantisbt/view.php?id=255

I finally commited a workaround to CVS last week. The problem is caused by VDR
1.5.x clients, so I'd rather see this fixed on the client side. But thanks for
your efforts nevertheless! I added a reference to your posting in the bugreport.

Frank
  

Patch

Index: server/connectionVTP.c
===================================================================
RCS file: /var/cvsroot/streamdev/server/connectionVTP.c,v
retrieving revision 1.15
diff -u -r1.15 connectionVTP.c
--- server/connectionVTP.c	21 Sep 2007 12:45:31 -0000	1.15
+++ server/connectionVTP.c	15 Dec 2007 14:34:15 -0000
@@ -840,7 +840,8 @@ 
 
 	switch (id) {
 	case siLive: 
-		DELETENULL(m_LiveStreamer); 
+		m_LiveStreamer->Stop();
+//		DELETENULL(m_LiveStreamer); 
 		DELETENULL(m_LiveSocket);
 		break;