From patchwork Mon Jul 10 19:00:08 2006 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans-Werner Hilse X-Patchwork-Id: 12356 Received: from gabriel.sub.uni-goettingen.de ([134.76.163.126]) by www.linuxtv.org with esmtp (Exim 4.50) id 1G00zW-0000hB-Pf for vdr@linuxtv.org; Mon, 10 Jul 2006 21:00:22 +0200 Received: by gabriel.sub.uni-goettingen.de (Postfix, from userid 8) id 58E6AED70B; Mon, 10 Jul 2006 21:00:22 +0200 (CEST) Received: from localhost (unknown [134.76.161.221]) by gabriel.sub.uni-goettingen.de (Postfix) with ESMTP id 4CEF6ED706 for ; Mon, 10 Jul 2006 21:00:21 +0200 (CEST) Date: Mon, 10 Jul 2006 21:00:08 +0200 From: Hans-Werner Hilse To: vdr@linuxtv.org Subject: Re: [vdr] warning - cannot set dumpable: Invalid argument Message-Id: <20060710210008.de1eb995.hilse@web.de> In-Reply-To: <20060710182053.GA16014@section_eight.mops.rwth-aachen.de> References: <20060710182053.GA16014@section_eight.mops.rwth-aachen.de> X-Mailer: Sylpheed version 2.2.5 (GTK+ 2.8.19; i586-pc-linux-gnu) Mime-Version: 1.0 X-Spam-Details: No, hits=0.0 required=5.0 tests=none autolearn=ham version=2.64 X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on gabriel.sub.uni-goettingen.de X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jul 2006 19:00:22 -0000 Status: O X-Status: X-Keywords: X-UID: 10046 Hi, On Mon, 10 Jul 2006 20:20:53 +0200 Sebastian Kemper wrote: > I installed kernel 2.6.16.24 lately and get this warning when starting > vdr. The same should happen with 2.6.17.4 since both share the same > Changelog: (Part of?) the according patch is this: http://www.kernel.org/diff/diffview.cgi?file=%2Fpub%2Flinux%2Fkernel%2Fv2.6%2Fpatch-2.6.17.4.bz2;z=17 > So I was wondering if you could adapt vdr's dumpfile > handling to the new situation and put the changes in vdr-1.4.2 in > order to get rid of the warning, please. That would be getting rid of dump file "handling" at all, I think, since PR_SET_DUMPABLE=1 is probably _not_ wanted since it reintroduces the problems why =2 was made before. So basically this means: No core dumps when s{u,g}id'ing. A quick patch is appended. -hwh --- vdr-1.4.1.O/vdr.c 2006-06-04 11:04:47.000000000 +0200 +++ vdr-1.4.1/vdr.c 2006-07-10 20:58:14.619325064 +0200 @@ -102,10 +102,6 @@ fprintf(stderr, "vdr: cannot set user id %u: %s\n", (unsigned int)user->pw_uid, strerror(errno)); return false; } - if (prctl(PR_SET_DUMPABLE, 2, 0, 0, 0) < 0) { - fprintf(stderr, "vdr: warning - cannot set dumpable: %s\n", strerror(errno)); - // always non-fatal, and will not work with kernel < 2.6.13 - } } return true; }