From patchwork Sat Apr 29 10:46:34 2006 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prakash Punnoor X-Patchwork-Id: 12288 Received: from mail-in-07.arcor-online.net ([151.189.21.47]) by www.linuxtv.org with esmtp (Exim 4.50) id 1FZmyB-0005gK-Ue for vdr@linuxtv.org; Sat, 29 Apr 2006 12:46:35 +0200 Received: from mail-in-06-z2.arcor-online.net (mail-in-06-z2.arcor-online.net [151.189.8.18]) by mail-in-07.arcor-online.net (Postfix) with ESMTP id A9AD615EC80 for ; Sat, 29 Apr 2006 12:46:35 +0200 (CEST) Received: from mail-in-07.arcor-online.net (mail-in-07.arcor-online.net [151.189.21.47]) by mail-in-06-z2.arcor-online.net (Postfix) with ESMTP id 6B06419D299 for ; Sat, 29 Apr 2006 12:46:35 +0200 (CEST) Received: from lalala (p5086385D.dip0.t-ipconnect.de [80.134.56.93]) (Authenticated sender: prakashp@arcor.de) by mail-in-07.arcor-online.net (Postfix) with ESMTP id EF0B815ECEA for ; Sat, 29 Apr 2006 12:46:34 +0200 (CEST) From: Prakash Punnoor To: vdr@linuxtv.org Subject: Re: [vdr] [ANNOUNCE] VDR developer version 1.3.49 Date: Sat, 29 Apr 2006 12:46:34 +0200 User-Agent: KMail/1.9.1 References: <44521D96.3060101@cadsoft.de> <200604291238.42711.prakash@punnoor.de> In-Reply-To: <200604291238.42711.prakash@punnoor.de> MIME-Version: 1.0 Message-Id: <200604291246.34505.prakash@punnoor.de> X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Apr 2006 10:46:36 -0000 Status: O X-Status: X-Keywords: X-UID: 9137 Am Samstag April 29 2006 12:38 schrieb Prakash Punnoor: > attached patch fixes that vdr (the executable and the static lib libpsi) > get compiled with fPIC. Only shared libs need PIC, thus add this flag only > when building plug-ins. Furthermore I added -g and -Wall to CFLAGS, as > well, because of reasons of symmetry. Updated patch: I forgot to add -g -Wall to Make.conf.template... diff -urd vdr-1.3.49/libsi/Makefile vdr-1.3.49.n/libsi/Makefile --- vdr-1.3.49/libsi/Makefile 2005-05-29 13:47:12.000000000 +0200 +++ vdr-1.3.49.n/libsi/Makefile 2006-04-29 12:13:59.000000000 +0200 @@ -6,7 +6,7 @@ ### The C++ compiler and options: CXX ?= g++ -CXXFLAGS ?= -fPIC -O2 -g -Wall -Woverloaded-virtual +CXXFLAGS ?= -O2 -g -Wall -Woverloaded-virtual AR = ar ARFLAGS = ru RANLIB = ranlib diff -urd vdr-1.3.49/Make.config.template vdr-1.3.49.n/Make.config.template --- vdr-1.3.49/Make.config.template 2006-04-15 14:28:03.000000000 +0200 +++ vdr-1.3.49.n/Make.config.template 2006-04-29 12:41:21.000000000 +0200 @@ -11,10 +11,10 @@ ### The C compiler and options: CC = gcc -CFLAGS = -O2 +CFLAGS = -g -O2 -Wall CXX = g++ -CXXFLAGS = -fPIC -g -O2 -Wall -Woverloaded-virtual +CXXFLAGS = -g -O2 -Wall -Woverloaded-virtual ### The directory environment: diff -urd vdr-1.3.49/Makefile vdr-1.3.49.n/Makefile --- vdr-1.3.49/Makefile 2006-04-24 19:18:06.000000000 +0200 +++ vdr-1.3.49.n/Makefile 2006-04-29 12:33:23.000000000 +0200 @@ -9,10 +9,10 @@ .DELETE_ON_ERROR: CC ?= gcc -CFLAGS ?= -O2 +CFLAGS ?= -g -O2 -Wall CXX ?= g++ -CXXFLAGS ?= -fPIC -g -O2 -Wall -Woverloaded-virtual +CXXFLAGS ?= -g -O2 -Wall -Woverloaded-virtual LSIDIR = ./libsi MANDIR = /usr/local/man @@ -175,6 +175,8 @@ # Plugins: plugins: include-dir + CFLAGS="-fPIC $(CFLAGS)" + CXXFLAGS="-fPIC $(CXXFLAGS)" @failed="";\ noapiv="";\ for i in `ls $(PLUGINDIR)/src | grep -v '[^a-z0-9]'`; do\