SourceCaps patch for VDR 1.3.32.

Message ID 200510052017.26481.zzam@gmx.de
State New
Headers

Commit Message

Matthias Schwarzott Oct. 5, 2005, 6:17 p.m. UTC
  On Wednesday 05 October 2005 13:23, Frank wrote:
> Hello,
>
> I have 2 DVB cards in my VDR system
>
> 1) FF card for Astra 19.2E and Eutelsat 13.0E.
>
> 2) budget card for Astra 19.2E
>
> > I am using the following entries for that in my setup.conf:
> >
> > SourceCaps = 1 S19.2E S13.0E
> > SourceCaps = 2 S19.2E
>
> With vdr 1.3.22 - included patch for vdr 1.3.18 - sourcecaps-patch works
> fine (only the automatic scan for new channels produced mistakes).
>
> Now i have tested this patch with vdr 1.3.34, but the first entry of
> SourceCaps in setup.conf will be ignored and is deleted after shutdown vdr.
>
> Any suggestions?
>

Hi!

I had the same problem and now found out that old sourcecaps patches changed 
cSource::fromString with attached patch, which is missing in newest 
sourcecaps-patch. With it applied everything works as expected.

Matthias
  

Comments

Carsten Koch Oct. 5, 2005, 6:25 p.m. UTC | #1
Matthias Schwarzott wrote:
...
> I had the same problem and now found out that old sourcecaps patches changed 
> cSource::fromString with attached patch, which is missing in newest 
> sourcecaps-patch. With it applied everything works as expected.

Thanks for the info.
For my setup (one sat per card) that code was not needed
and I also have doubts that it should go into a global function.
But apparaently it was not OK to remove it.
I will fix this with the 1.3.35 version of the patch.

Carsten.
  
Frank Oct. 15, 2005, 8:37 p.m. UTC | #2
>> I am using the following entries for that in my setup.conf:
>>
>> SourceCaps = 1 S19.2E S13.0E
>> SourceCaps = 2 S19.2E

> I had the same problem and now found out that old sourcecaps patches
changed
> cSource::fromString with attached patch, which is missing in newest
> sourcecaps-patch. With it applied everything works as expected.
>
> Matthias
>

Sorry for the late response.
I have not tested your patch, because now i have patched 1.3.34 with the
patch for 1.3.18, was only for some tests, works good, but automatic search
for new channels will find channels on eutelsat, which will only receive on
astra.

Is this fixed in your patch?

Frank
  

Patch

diff -Nur vdr-1.3.21/sources.c vdr-1.3.21-SC/sources.c
--- vdr-1.3.21/sources.c	2004-12-26 12:58:52.000000000 +0100
+++ vdr-1.3.21-SC/sources.c	2005-02-16 00:29:02.652355896 +0100
@@ -68,7 +68,7 @@ 
      int pos = 0;
      bool dot = false;
      bool neg = false;
-     while (*++s) {
+     while (*++s && !isblank(*s)) {
            switch (toupper(*s)) {
              case '0' ... '9': pos *= 10;
                                pos += *s - '0';