From patchwork Sun Jun 26 18:29:44 2005 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian X-Patchwork-Id: 11924 Received: from imap.gmx.net ([213.165.64.20] helo=mail.gmx.net) by www.linuxtv.org with smtp (Exim 4.34) id 1DmbtY-0008Sm-Cf for vdr@linuxtv.org; Sun, 26 Jun 2005 20:30:16 +0200 Received: (qmail invoked by alias); 26 Jun 2005 18:29:45 -0000 Received: from 0-009.vpn.RWTH-Aachen.DE (EHLO gmx.net) [134.130.240.9] by mail.gmx.net (mp028) with SMTP; 26 Jun 2005 20:29:45 +0200 X-Authenticated: #24128601 Received: by gmx.net (nbSMTP-0.99) for uid 1000 (using TLSv1/SSLv3 with cipher DHE-RSA-AES256-SHA (256/256 bits)) sebastian_ml@gmx.net; Sun, 26 Jun 2005 20:29:44 +0200 (CEST) Date: Sun, 26 Jun 2005 20:29:44 +0200 From: Sebastian To: Klaus Schmidinger's VDR Subject: Re: [vdr] Dolby digital - recording and DVD plugin Message-ID: <20050626182944.GA20946@hell_awaits.mops.rwth-aachen.de> Mail-Followup-To: Klaus Schmidinger's VDR References: <20050625173431.GI16831@server.idefix.loc> <42BE10B5.1010107@gmail.com> <42BEF275.2020304@dev0.sytes.net> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: <42BEF275.2020304@dev0.sytes.net> User-Agent: Mutt/1.5.8i X-Y-GMX-Trusted: 0 X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Klaus Schmidinger's VDR List-Id: Klaus Schmidinger's VDR List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jun 2005 18:30:16 -0000 Status: O X-Status: X-Keywords: X-UID: 3260 How about this patch? I use it with vdr 1.3.27. On So, Jun 26, 2005 at 08:22:45 +0200, devzero wrote: > Anssi Hannula schrieb: > > Well, I have the same problem, but there is no way atm I think. > I think the last VDR version where u can select "Record AC3 or so" is > 1.3.17, there is a patch for newer ones in vdr-portal, but this doesnt > work for me.. any one else suggestions? > > >Matthias Fechner wrote: > > > >>Hi, > >> > >>i checked the documentation now and i found, if i set Use Dolby > >>Digital to no, no dolby digital audio is recorded anymore. > >> > >>But to see a dvd with DD without DD equipment, it seems that i need to > >>disable it. > >> > >>Is it possible to record movies with DD, but dont replay it with DD? > >>(maybe a new option in VDR?) > >> > > > >The Dolby Digital switch in the options does just that. > > > >However dvd plugin uses this wrong, and it should be fixed. It should > >offer the audio tracks (DD and non-DD) for the vdr as different > >tracks, so that vdr could choose the right one. > > > > > > > _______________________________________________ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > diff -Nur vdr-1.3.24_old/config.c vdr-1.3.24/config.c --- vdr-1.3.24_old/config.c 2005-02-20 13:52:59.000000000 +0100 +++ vdr-1.3.24/config.c 2005-05-26 21:38:53.000000000 +0200 @@ -283,6 +283,7 @@ VideoFormat = 0; UpdateChannels = 4; UseDolbyDigital = 1; + UseDolbyInRecordings = 1; ChannelInfoPos = 0; ChannelInfoTime = 5; OSDLeft = 54; @@ -440,6 +441,7 @@ else if (!strcasecmp(Name, "VideoFormat")) VideoFormat = atoi(Value); else if (!strcasecmp(Name, "UpdateChannels")) UpdateChannels = atoi(Value); else if (!strcasecmp(Name, "UseDolbyDigital")) UseDolbyDigital = atoi(Value); + else if (!strcasecmp(Name, "UseDolbyInRecordings")) UseDolbyInRecordings = atoi(Value); else if (!strcasecmp(Name, "ChannelInfoPos")) ChannelInfoPos = atoi(Value); else if (!strcasecmp(Name, "ChannelInfoTime")) ChannelInfoTime = atoi(Value); else if (!strcasecmp(Name, "OSDLeft")) OSDLeft = atoi(Value); @@ -504,6 +506,7 @@ Store("VideoFormat", VideoFormat); Store("UpdateChannels", UpdateChannels); Store("UseDolbyDigital", UseDolbyDigital); + Store("UseDolbyInRecordings", UseDolbyInRecordings); Store("ChannelInfoPos", ChannelInfoPos); Store("ChannelInfoTime", ChannelInfoTime); Store("OSDLeft", OSDLeft); diff -Nur vdr-1.3.24_old/config.h vdr-1.3.24/config.h --- vdr-1.3.24_old/config.h 2005-05-05 13:04:18.000000000 +0200 +++ vdr-1.3.24/config.h 2005-05-26 21:39:03.000000000 +0200 @@ -241,6 +241,7 @@ int VideoFormat; int UpdateChannels; int UseDolbyDigital; + int UseDolbyInRecordings; int ChannelInfoPos; int ChannelInfoTime; int OSDLeft, OSDTop, OSDWidth, OSDHeight; diff -Nur vdr-1.3.24_old/menu.c vdr-1.3.24/menu.c --- vdr-1.3.24_old/menu.c 2005-03-20 16:14:51.000000000 +0100 +++ vdr-1.3.24/menu.c 2005-05-26 21:39:09.000000000 +0200 @@ -2168,6 +2168,7 @@ cMenuSetupRecord::cMenuSetupRecord(void) { SetSection(tr("Recording")); + Add(new cMenuEditBoolItem( tr("Setup.Recording$Record Dolby"), &data.UseDolbyInRecordings)); Add(new cMenuEditIntItem( tr("Setup.Recording$Margin at start (min)"), &data.MarginStart)); Add(new cMenuEditIntItem( tr("Setup.Recording$Margin at stop (min)"), &data.MarginStop)); Add(new cMenuEditIntItem( tr("Setup.Recording$Primary limit"), &data.PrimaryLimit, 0, MAXPRIORITY)); diff -Nur vdr-1.3.24_old/recorder.c vdr-1.3.24/recorder.c --- vdr-1.3.24_old/recorder.c 2005-01-16 13:53:17.000000000 +0100 +++ vdr-1.3.24/recorder.c 2005-05-26 21:39:15.000000000 +0200 @@ -128,7 +128,7 @@ } cRecorder::cRecorder(const char *FileName, int Ca, int Priority, int VPid, const int *APids, const int *DPids, const int *SPids) -:cReceiver(Ca, Priority, VPid, APids, Setup.UseDolbyDigital ? DPids : NULL, SPids) +:cReceiver(Ca, Priority, VPid, APids, Setup.UseDolbyInRecordings ? DPids : NULL, SPids) ,cThread("recording") { active = false; @@ -139,7 +139,7 @@ ringBuffer = new cRingBufferLinear(RECORDERBUFSIZE, TS_SIZE * 2, true, "Recorder"); ringBuffer->SetTimeouts(0, 100); - remux = new cRemux(VPid, APids, Setup.UseDolbyDigital ? DPids : NULL, SPids, true); + remux = new cRemux(VPid, APids, Setup.UseDolbyInRecordings ? DPids : NULL, SPids, true); writer = new cFileWriter(FileName, remux); }