diff mbox

Dolby digital - recording and DVD plugin

Message ID 20050626182944.GA20946@hell_awaits.mops.rwth-aachen.de
State New
Headers

Commit Message

Sebastian June 26, 2005, 6:29 p.m. UTC 
  How about this patch? I use it with vdr 1.3.27.

On So, Jun 26, 2005 at 08:22:45 +0200, devzero wrote:
> Anssi Hannula schrieb:
> 
> Well, I have the same problem, but there is no way atm I think.
> I think the last VDR version where u can select "Record AC3 or so" is 
> 1.3.17, there is a patch for newer ones in vdr-portal, but this doesnt 
> work for me.. any one else suggestions?
> 
> >Matthias Fechner wrote:
> >
> >>Hi,
> >>
> >>i checked the documentation now and i found, if i set Use Dolby
> >>Digital to no, no dolby digital audio is recorded anymore.
> >>
> >>But to see a dvd with DD without DD equipment, it seems that i need to
> >>disable it.
> >>
> >>Is it possible to record movies with DD, but dont replay it with DD?
> >>(maybe a new option in VDR?)
> >>
> >
> >The Dolby Digital switch in the options does just that.
> >
> >However dvd plugin uses this wrong, and it should be fixed. It should 
> >offer the audio tracks (DD and non-DD) for the vdr as different 
> >tracks, so that vdr could choose the right one.
> >
> >
> 
> 
> _______________________________________________
> vdr mailing list
> vdr@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
>

Comments

devzero June 26, 2005, 6:36 p.m. UTC | #1 
Sebastian schrieb:

>How about this patch? I use it with vdr 1.3.27.
>
>  
>

mmmh, maybe I don't know about this patch - is this the patch from Frank 
on vdr-portal or another (newer one?)
I think I'll give it a try.
Sebastian June 26, 2005, 7:27 p.m. UTC | #2 
:) No, it's from me.

On So, Jun 26, 2005 at 08:36:00 +0200, devzero wrote:
> Sebastian schrieb:
> 
> >How about this patch? I use it with vdr 1.3.27.
> >
> > 
> >
> 
> mmmh, maybe I don't know about this patch - is this the patch from Frank 
> on vdr-portal or another (newer one?)
> I think I'll give it a try.
> 
> 
> _______________________________________________
> vdr mailing list
> vdr@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
>
diff mbox

Patch

diff -Nur vdr-1.3.24_old/config.c vdr-1.3.24/config.c
--- vdr-1.3.24_old/config.c	2005-02-20 13:52:59.000000000 +0100
+++ vdr-1.3.24/config.c	2005-05-26 21:38:53.000000000 +0200
@@ -283,6 +283,7 @@ 
   VideoFormat = 0;
   UpdateChannels = 4;
   UseDolbyDigital = 1;
+  UseDolbyInRecordings = 1;
   ChannelInfoPos = 0;
   ChannelInfoTime = 5;
   OSDLeft = 54;
@@ -440,6 +441,7 @@ 
   else if (!strcasecmp(Name, "VideoFormat"))         VideoFormat        = atoi(Value);
   else if (!strcasecmp(Name, "UpdateChannels"))      UpdateChannels     = atoi(Value);
   else if (!strcasecmp(Name, "UseDolbyDigital"))     UseDolbyDigital    = atoi(Value);
+  else if (!strcasecmp(Name, "UseDolbyInRecordings")) UseDolbyInRecordings = atoi(Value);
   else if (!strcasecmp(Name, "ChannelInfoPos"))      ChannelInfoPos     = atoi(Value);
   else if (!strcasecmp(Name, "ChannelInfoTime"))     ChannelInfoTime    = atoi(Value);
   else if (!strcasecmp(Name, "OSDLeft"))             OSDLeft            = atoi(Value);
@@ -504,6 +506,7 @@ 
   Store("VideoFormat",        VideoFormat);
   Store("UpdateChannels",     UpdateChannels);
   Store("UseDolbyDigital",    UseDolbyDigital);
+  Store("UseDolbyInRecordings", UseDolbyInRecordings);
   Store("ChannelInfoPos",     ChannelInfoPos);
   Store("ChannelInfoTime",    ChannelInfoTime);
   Store("OSDLeft",            OSDLeft);
diff -Nur vdr-1.3.24_old/config.h vdr-1.3.24/config.h
--- vdr-1.3.24_old/config.h	2005-05-05 13:04:18.000000000 +0200
+++ vdr-1.3.24/config.h	2005-05-26 21:39:03.000000000 +0200
@@ -241,6 +241,7 @@ 
   int VideoFormat;
   int UpdateChannels;
   int UseDolbyDigital;
+  int UseDolbyInRecordings;
   int ChannelInfoPos;
   int ChannelInfoTime;
   int OSDLeft, OSDTop, OSDWidth, OSDHeight;
diff -Nur vdr-1.3.24_old/menu.c vdr-1.3.24/menu.c
--- vdr-1.3.24_old/menu.c	2005-03-20 16:14:51.000000000 +0100
+++ vdr-1.3.24/menu.c	2005-05-26 21:39:09.000000000 +0200
@@ -2168,6 +2168,7 @@ 
 cMenuSetupRecord::cMenuSetupRecord(void)
 {
   SetSection(tr("Recording"));
+  Add(new cMenuEditBoolItem( tr("Setup.Recording$Record Dolby"),     &data.UseDolbyInRecordings));
   Add(new cMenuEditIntItem( tr("Setup.Recording$Margin at start (min)"),     &data.MarginStart));
   Add(new cMenuEditIntItem( tr("Setup.Recording$Margin at stop (min)"),      &data.MarginStop));
   Add(new cMenuEditIntItem( tr("Setup.Recording$Primary limit"),             &data.PrimaryLimit, 0, MAXPRIORITY));
diff -Nur vdr-1.3.24_old/recorder.c vdr-1.3.24/recorder.c
--- vdr-1.3.24_old/recorder.c	2005-01-16 13:53:17.000000000 +0100
+++ vdr-1.3.24/recorder.c	2005-05-26 21:39:15.000000000 +0200
@@ -128,7 +128,7 @@ 
 }
 
 cRecorder::cRecorder(const char *FileName, int Ca, int Priority, int VPid, const int *APids, const int *DPids, const int *SPids)
-:cReceiver(Ca, Priority, VPid, APids, Setup.UseDolbyDigital ? DPids : NULL, SPids)
+:cReceiver(Ca, Priority, VPid, APids, Setup.UseDolbyInRecordings ? DPids : NULL, SPids)
 ,cThread("recording")
 {
   active = false;
@@ -139,7 +139,7 @@ 
 
   ringBuffer = new cRingBufferLinear(RECORDERBUFSIZE, TS_SIZE * 2, true, "Recorder");
   ringBuffer->SetTimeouts(0, 100);
-  remux = new cRemux(VPid, APids, Setup.UseDolbyDigital ? DPids : NULL, SPids, true);
+  remux = new cRemux(VPid, APids, Setup.UseDolbyInRecordings ? DPids : NULL, SPids, true);
   writer = new cFileWriter(FileName, remux);
 }