dvd-plugin cvs: unchecked access to SPUdecoder

Message ID 200503121013.54136.stefan@lucke.in-berlin.de
State New
Headers

Commit Message

Stefan Lucke March 12, 2005, 9:13 a.m. UTC
  Hi,

cvs version of dvd-plugin has one unckecked access to spu decoder.
this causes segfaults if attached device has none. See attached diff.
  

Patch

Index: player-dvd.c
===================================================================
RCS file: /cvsroot/dvdplugin/dvd/player-dvd.c,v
retrieving revision 1.89
diff -U3 -r1.89 player-dvd.c
--- player-dvd.c	13 Feb 2005 19:51:04 -0000	1.89
+++ player-dvd.c	12 Mar 2005 09:09:45 -0000
@@ -1045,7 +1045,7 @@ 
 		    ev->logical, ev->logical,
 	            currentNavSubpStreamUsrLocked, !changeNavSubpStreamOnceInSameCell);
 
-            if( IsInMenuDomain() || IsDvdNavigationForced() || !currentNavSubpStreamUsrLocked || changeNavSubpStreamOnceInSameCell ) {
+            if(SPUdecoder && ( IsInMenuDomain() || IsDvdNavigationForced() || !currentNavSubpStreamUsrLocked || changeNavSubpStreamOnceInSameCell )) {
                 cSpuDecoder::eScaleMode mode = SPUdecoder->getScaleMode();
 
                 /* !!! Bit 7 set means hide, and only let Forced display show (see vm.c from libdvdnav) */