From patchwork Tue Jun 12 20:54:14 2007 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Riedel X-Patchwork-Id: 12475 Received: from mailout03.sul.t-online.com ([194.25.134.81]) by www.linuxtv.org with esmtp (Exim 4.63) (envelope-from ) id 1HyDNi-0004UM-Qn for vdr@linuxtv.org; Tue, 12 Jun 2007 22:54:26 +0200 Received: from fwd34.aul.t-online.de by mailout03.sul.t-online.com with smtp id 1HyDNi-0003R9-01; Tue, 12 Jun 2007 22:54:26 +0200 Received: from localhost (r1dO4vZVZeksCpXIVRGwJmxg5s0iJdAGqy3DqfQ5gfFiM5t8UY+7E2@[172.20.101.250]) by fwd34.aul.t-online.de with esmtp id 1HyDNW-0kaPiq0; Tue, 12 Jun 2007 22:54:14 +0200 MIME-Version: 1.0 In-Reply-To: <2a954dbc0706121135m1b1db033g73208b25aa4e7a8b@mail.gmail.com> References: <2a954dbc0706101243j182f46f0m57a786874f3c84de@mail.gmail.com> <466EDC28.8070307@gmx.de> <2a954dbc0706121135m1b1db033g73208b25aa4e7a8b@mail.gmail.com> Date: Tue, 12 Jun 2007 22:54:14 +0200 To: "VDR Mailing List" X-UMS: email X-Mailer: TOI Kommunikationscenter V7-7-2 From: "alexander-riedel@t-online.de" Message-ID: <1HyDNW-0kaPiq0@fwd34.aul.t-online.de> X-ID: r1dO4vZVZeksCpXIVRGwJmxg5s0iJdAGqy3DqfQ5gfFiM5t8UY+7E2@t-dialin.net X-TOI-MSGID: 64c64b03-552f-4859-8570-d5a073f87a77 Subject: Re: [vdr] vdr-1.5.3 - issue with translations out of plugins X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.9 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2007 20:54:27 -0000 Status: O X-Status: X-Keywords: X-UID: 13202 Hi, please try both patches together. I have also problems after ma first patch with softdevice translations, but now with Christian's patch is OK. -----Original Message----- Date: Tue, 12 Jun 2007 20:35:29 +0200 Subject: Re: [vdr] vdr-1.5.3 - issue with translations out of plugins From: "Joachim Wilke" To: "VDR Mailing List" 2007/6/12, Christian Wieninger : > I still had crashes even when using Alexanders patch. > I think the fix should look like this (diff against plain 1.5.3): Hi, I'm sorry but neither the first nor the second patch do work here. I still get an segfault when lcdproc tries to translate "Volume ". Regards, Joachim. --- /home/riedel/GENS/orig-vdr/vdr-1.5.3.orig/i18n.c 2007-06-09 10:44:54.000000000 +0200 +++ /home/riedel/GENS/orig-vdr/vdr-1.5.3/i18n.c 2007-06-12 22:47:38.000000000 +0200 @@ -6820,7 +6820,7 @@ *Converted = new tI18nPhrase[NumPhrases + 1]; memset(*Converted, 0, sizeof(tI18nPhrase) * (NumPhrases + 1)); } - if (!(*Converted)[NrPhrase][NrLanguage]) { + if (!(*Converted)[NrPhrase][NrLanguage] && Original[NrPhrase][NrLanguage]) { cCharSetConv csc(Phrases[1][NrLanguage], cCharSetConv::SystemCharacterTable()); (*Converted)[NrPhrase][NrLanguage] = strdup(csc.Convert(Original[NrPhrase][NrLanguage])); } @@ -6851,7 +6851,7 @@ return t; } } - p = Phrases; + p = OriginalPhrases = Phrases; } esyslog("%s%sno translation found for '%s' in language %d (%s)", Plugin ? Plugin : "", Plugin ? ": " : "", s, Setup.OSDLanguage, Phrases[0][Setup.OSDLanguage]); }