From patchwork Sat Jul 2 09:00:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard F X-Patchwork-Id: 34979 Received: from localhost ([127.0.0.1] helo=www.linuxtv.org) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJGmY-0001Ba-6y; Sat, 02 Jul 2016 09:00:10 +0000 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJGmU-0001BO-0R for vdr@linuxtv.org; Sat, 02 Jul 2016 09:00:06 +0000 X-tubIT-Incoming-IP: 94.126.40.179 Received: from out-mta12.ai270.net ([94.126.40.179] helo=out-mta10.ai270.net) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-8) with esmtps [TLSv1.2:DHE-RSA-AES128-SHA:128] for id 1bJGmR-00062j-mB; Sat, 02 Jul 2016 11:00:05 +0200 Received: from [94.126.40.187] (helo=outscan1.ai270.net) by out-mta10.ai270.net with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1bJGmQ-0004vf-UL for vdr@linuxtv.org; Sat, 02 Jul 2016 10:00:02 +0100 Received: from mail.lcn.com (mail.lcn.com [94.126.40.131]) by outscan1.ai270.net (8.14.4/8.14.4/Debian-8) with ESMTP id u62902OM029217 for ; Sat, 2 Jul 2016 10:00:02 +0100 Received: from 234.162.200.146.dyn.plus.net ([146.200.162.234] helo=m.keynet-technology.com) by mail.lcn.com with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1bJGmQ-0004u4-AC for vdr@linuxtv.org; Sat, 02 Jul 2016 10:00:02 +0100 Received: from localhost (localhost [127.0.0.1]) by m.keynet-technology.com (Postfix) with ESMTP id E03458648B66 for ; Sat, 2 Jul 2016 10:00:01 +0100 (BST) Received: from m.keynet-technology.com ([127.0.0.1]) by localhost (m.keynet-technology.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 95riAmLn_cqX for ; Sat, 2 Jul 2016 10:00:00 +0100 (BST) Received: from localhost (localhost [127.0.0.1]) by m.keynet-technology.com (Postfix) with ESMTP id 82CF78648B83 for ; Sat, 2 Jul 2016 10:00:00 +0100 (BST) DKIM-Filter: OpenDKIM Filter v2.9.2 m.keynet-technology.com 82CF78648B83 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=keynet-technology.com; s=AFD4F4C2-A54C-11E4-9384-6EC1616F5293; t=1467450000; bh=5c/IHJfviqBNpT8UzpgW6A5wmgamYGskIiCjJWz1qz0=; h=Date:From:To:Message-ID:Subject:MIME-Version:Content-Type; b=dhqoXLV2WMQX3lcEtbVH4AhGIwPKJafIj0xtltLiw8iTWcAbbW8MFq3lOhbxBzaGa Pzc9FE3fVvJTHE8dLLVDKaIoMssCxcOJebrJGj4Xq/2UimJ3aTvZ4WUsXLzYDUDjRR FADyWWKY/HrQdNZqXYFdtOG7q4t3vXPqobUrGF/M= X-Virus-Scanned: amavisd-new at keynet-technology.com Received: from m.keynet-technology.com ([127.0.0.1]) by localhost (m.keynet-technology.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id SRRMiuK0fYVS for ; Sat, 2 Jul 2016 10:00:00 +0100 (BST) Received: from m.keynet-technology.com (localhost [127.0.0.1]) by m.keynet-technology.com (Postfix) with ESMTP id 4B4D58648B66 for ; Sat, 2 Jul 2016 10:00:00 +0100 (BST) Date: Sat, 2 Jul 2016 10:00:00 +0100 (BST) From: Richard F To: vdr@linuxtv.org Message-ID: <1393174701.6943.1467304151192.JavaMail.zimbra@keynet-technology.com> MIME-Version: 1.0 X-Mailer: Zimbra 8.6.0_GA_1194 Thread-Topic: vdr --genindex fails on radio recording Thread-Index: Dtd7xUzKW4oUlnwQIuVbGpV8PXbZjQ== X-AI-Sender: rf@keynet-technology.com X-Bayes-Prob: 0.0001 (Score -1, tokens from: LCNPOST, base:default, @@RPTN) X-Spam-Score: -1.00 () [Hold at 5.50] HTML_MESSAGE:0.001,Bayes(0.0001:-1.0) X-CanIt-Geo: ip=94.126.40.131; country=GB; latitude=51.4964; longitude=-0.1224; http://maps.google.com/maps?q=51.4964,-0.1224&z=6 X-CanItPRO-Stream: base:LCNPOST (inherits from base:default) X-Canit-Stats-ID: 02RdJ0212 - af071e01a967 - 20160702 X-Scanned-By: CanIt (www . roaringpenguin . com) X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.7.2.85117 X-PMX-Spam: Gauge=X, Probability=10%, Report=' TO_IN_SUBJECT 0.5, BODYTEXTH_SIZE_10000_LESS 0, BODYTEXTH_SIZE_3000_MORE 0, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_6000_6999 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __CTYPE_MULTIPART_ALT 0, __FORGED_RCVD_X2_HOST 0, __HAS_FROM 0, __HAS_HTML 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HTML_AHREF_TAG 0, __HTTPS_URI 0, __MIME_HTML 0, __MIME_VERSION 0, __MULTIPLE_URI_TEXT 0, __RATWARE_SIGNATURE_3_N1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TAG_EXISTS_HTML 0, __TO_IN_SUBJECT2 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0' X-LSpam-Score: 2.6 (++) X-LSpam-Report: No, score=2.6 required=5.0 tests=HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, RDNS_NONE=1.274, T_DKIM_INVALID=0.01 autolearn=no autolearn_force=no Subject: Re: [vdr] vdr --genindex fails on radio recording X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: VDR Mailing List Errors-To: vdr-bounces@linuxtv.org Sender: "vdr" Hi Thomas, The patch is a tiny bit different for VDR 2.2.0 - in remux.c - see below There's a small issue with audio types also: Here, AAC (ADTS) per ISO/IEC 13818-7 or AAC (LATM) per ISO/IEC 14496-3 is regularly used for audio in HD broadcasts - my suggestion is that these streams should be handled too. For example, I transcode radio/audio to AAC in m4a or AAC_LATM in .ts files. Arguably the newer ATSC, DTS, Dolby true HD... streams should be added too ( https://en.wikipedia.org/wiki/Program-specific_information#Elementary_stream_types ) For now my audioparser line looks like this, which works for both flavours of AAC, and they play on Kodi and VLC. else if (type == 0x03 || type == 0x04 || type == 0x06 || type == 0x0F || type == 0x11) // MPEG2,4 AAC, AC3 audio The original audio-only .ts (MP2 codec) actually doesn't play in VLC, but plays in ffplay. Patch: On 27/06/2016 06:46, Thomas Reufer wrote: Hi Richard I observed the same behavior two weeks ago when I wanted to replay an edited radio recording. Please find my proposed fix attached, maybe Klaus will take it into the next VDR developer release. Regards, Thomas Quoting Richard F : --- remux.c.orig 2016-06-30 14:16:52.530155071 +0100 +++ remux.c 2016-06-30 14:36:09.028232179 +0100 @@ -604,6 +604,7 @@ void cPatPmtParser::Reset(void) { + completed = false; pmtSize = 0; patVersion = pmtVersion = -1; pmtPids[0] = 0; @@ -893,6 +894,7 @@ } } pmtVersion = Pmt.getVersionNumber(); + completed = true; } else esyslog("ERROR: can't parse PMT"); @@ -1464,7 +1466,7 @@ parser = new cMpeg2Parser; else if (type == 0x1B) parser = new cH264Parser; - else if (type == 0x04 || type == 0x06) // MPEG audio or AC3 audio + else if (type == 0x03 || type == 0x04 || type == 0x06 || type == 0x0F || type == 0x11) // MPEG2,4 AAC, AC3 audio parser = new cAudioParser; else if (type != 0) esyslog("ERROR: unknown stream type %d (PID %d) in frame detector", type, pid);