From patchwork Sun Apr 3 21:06:21 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Menzel X-Patchwork-Id: 12882 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.69) (envelope-from ) id 1Q6UV6-0007H3-6w for vdr@linuxtv.org; Sun, 03 Apr 2011 23:06:24 +0200 X-tubIT-Incoming-IP: 188.40.100.199 Received: from mail.gw90.de ([188.40.100.199]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtps [TLSv1:AES256-SHA:256] for id 1Q6UV5-0005BO-JL; Sun, 03 Apr 2011 23:06:24 +0200 Received: from f053041173.adsl.alicedsl.de ([78.53.41.173] helo=[192.168.178.21]) by mail.gw90.de with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1Q6UV5-0002gU-8i for vdr@linuxtv.org; Sun, 03 Apr 2011 21:06:23 +0000 From: Paul Menzel To: vdr@linuxtv.org Date: Sun, 03 Apr 2011 23:06:21 +0200 Message-ID: <1301864781.12068.34.camel@mattotaupa> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2011.4.3.205718 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1900_1999 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, INVALID_MSGID_NO_FQDN 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __MIME_VERSION 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_PATH 0, __URI_NO_WWW 0, __URI_NS ' X-LSpam-Score: -3.3 (---) X-LSpam-Report: No, score=-3.3 required=5.0 tests=AWL=0.295, BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1 autolearn=ham Subject: [vdr] [PATCH] PLUGINS/src/dvbsddevice/dvbsdffosd.c: remove superflous variable `Bitmap` X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Apr 2011 21:06:24 -0000 Status: O X-Status: X-Keywords: X-UID: 24615 Date: Fri, 4 Feb 2011 14:58:23 +0100 Cppcheck reports the following. cppcheck: (style) Variable 'Bitmap' is assigned a value that is never used Therefore remove the variable `Bitmap` for stylistic reasons since the compiler probably optimized that out anyway. Signed-off-by: Paul Menzel CC: Klaus Schmidinger --- PLUGINS/src/dvbsddevice/dvbsdffosd.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/PLUGINS/src/dvbsddevice/dvbsdffosd.c b/PLUGINS/src/dvbsddevice/dvbsdffosd.c index 4b60ef5..8be1d25 100644 --- a/PLUGINS/src/dvbsddevice/dvbsdffosd.c +++ b/PLUGINS/src/dvbsddevice/dvbsdffosd.c @@ -73,8 +73,7 @@ void cDvbSdFfOsd::SetActive(bool On) Flush(); } else if (shown) { - cBitmap *Bitmap; - for (int i = 0; (Bitmap = GetBitmap(i)) != NULL; i++) { + for (int i = 0; GetBitmap(i) != NULL; i++) { Cmd(OSD_SetWindow, 0, i + 1); Cmd(OSD_Close); } @@ -108,8 +107,7 @@ eOsdError cDvbSdFfOsd::CanHandleAreas(const tArea *Areas, int NumAreas) eOsdError cDvbSdFfOsd::SetAreas(const tArea *Areas, int NumAreas) { if (shown) { - cBitmap *Bitmap; - for (int i = 0; (Bitmap = GetBitmap(i)) != NULL; i++) { + for (int i = 0; GetBitmap(i) != NULL; i++) { Cmd(OSD_SetWindow, 0, i + 1); Cmd(OSD_Close); }