From patchwork Sun Dec 12 17:31:38 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paul Menzel X-Patchwork-Id: 12849 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.69) (envelope-from ) id 1PRpls-00043C-ID for vdr@linuxtv.org; Sun, 12 Dec 2010 18:31:41 +0100 X-tubIT-Incoming-IP: 188.40.100.199 Received: from mail.gw90.de ([188.40.100.199]) by mail.tu-berlin.de (exim-4.69/mailfrontend-a) with esmtps [TLSv1:AES256-SHA:256] for id 1PRpls-0004HO-AD; Sun, 12 Dec 2010 18:31:40 +0100 Received: from f053045090.adsl.alicedsl.de ([78.53.45.90] helo=[192.168.178.21]) by mail.gw90.de with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1PRplr-0001rx-LR for vdr@linuxtv.org; Sun, 12 Dec 2010 17:31:39 +0000 From: Paul Menzel To: vdr@linuxtv.org In-Reply-To: <18510219806.20100925131528@websitec.de> References: <4C961777.504@tvdr.de> <18510219806.20100925131528@websitec.de> Date: Sun, 12 Dec 2010 18:31:38 +0100 Message-ID: <1292175098.13905.58.camel@mattotaupa> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 X-PMX-Version: 5.5.4.371499, Antispam-Engine: 2.7.1.369594, Antispam-Data: 2010.12.12.171815 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' BODY_PARA_IS_SENTENCE_URL 0.1, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, INVALID_MSGID_NO_FQDN 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __MIME_VERSION 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0' X-LSpam-Score: -3.2 (---) X-LSpam-Report: No, score=-3.2 required=5.0 tests=AWL=0.357, BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1 autolearn=ham Subject: [vdr] [PATCH] Makefile: pass `LDFLAGS` to compiler X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: VDR Mailing List List-Id: VDR Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Dec 2010 17:31:41 -0000 Status: O X-Status: X-Keywords: X-UID: 23964 Dear Jörg, Am Samstag, den 25.09.2010, 13:15 +0200 schrieb Joerg Bornkessel: […] > we have an open bug [1] to all versions of VDR on gentoo > > we changed any weeks befor our default profiles to use LDFLAGS > on compile prozesses. > > > > -Wl,--as-needed has been added to the default profile's LDFLAGS. > > This option optimizes the linking process, only linking binaries to > libraries that are trully needed. This way, fewer libraries are loaded > at runtime and fewer packages need to be rebuilt after library updates. > > > > For more information on --as-needed, read [2]. > > Plz. let us check is it possible to add a fix generally to the > Makefile to respect the LDFLAGS or should i fixed always localy on > gentoo Disti. > > fixed should it be in this part of Makefile > > -# The main program: > - > -vdr: $(OBJS) $(SILIB) > - $(CXX) $(CXXFLAGS) -rdynamic $(OBJS) $(LIBS) $(LIBDIRS) $(SILIB) -o vdr > > +# The main program: > + > +vdr: $(OBJS) $(SILIB) > + $(CXX) $(CXXFLAGS) -rdynamic $(LDFLAGS) $(OBJS) $(LIBS) $(LIBDIRS) $(SILIB) -o vdr > > > [1] http://bugs.gentoo.org/show_bug.cgi?id=333493 > [2] http://www.gentoo.org/proj/en/qa/asneeded.xml Should `LDFLAGS` also be passed to the compiler when building the plugins? I made a patch from your message which does not include any changes to the plugins. Thanks, Paul 8<-------------------------------------------------------------------->8 Date: Sun, 12 Dec 2010 18:19:42 +0100 Some distributions pass special flags to the linker [1][2]. Respect those by using `LDFLAGS`. [1] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/vdr/vdr-1.7.10/linkerflags.patch [2] http://www.linuxtv.org/pipermail/vdr/2010-September/023623.html Signed-off-by: Paul Menzel --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index cca4d55..e12e2b2 100644 --- a/Makefile +++ b/Makefile @@ -95,7 +95,7 @@ $(DEPFILE): Makefile # The main program: vdr: $(OBJS) $(SILIB) - $(CXX) $(CXXFLAGS) -rdynamic $(OBJS) $(LIBS) $(LIBDIRS) $(SILIB) -o vdr + $(CXX) $(CXXFLAGS) -rdynamic $(LDFLAGS) $(OBJS) $(LIBS) $(LIBDIRS) $(SILIB) -o vdr # The libsi library: