Commit Message
Kimmo Taskinen wrote:
> Hi,
>
> Couple of issues I reported earlier (see below) have now merged to xineliboutput-plugin.
[...]
> > 1. Cropping is not reseted if I switch to 16:9 channel that has the same resolution as 4:3 channel that has turned on the cropping.
> > 2. DVB subtitles are not positioned correctly during cropping if vdr-sxfe is used to show subtitles. Vertical alignment is about at half of the screen.
Are you using vdpau ?
Does the attached patch fix issue 2 ?
- Petri
Comments
>> Couple of issues I reported earlier (see below) have now merged to xineliboutput-plugin.
> [...]
>>> 1. Cropping is not reseted if I switch to 16:9 channel that has the same resolution as 4:3 channel that has turned on the cropping.
>>> 2. DVB subtitles are not positioned correctly during cropping if vdr-sxfe is used to show subtitles. Vertical alignment is about at half of the screen.
>
> Are you using vdpau ?
>
> Does the attached patch fix issue 2 ?
I am also having problems with the subtitle text size and position with
vdr-1.7.10 and latest xineliboutputs. (and your patch did not help.)
With vdr-1.6.0, subtitles plugin and xineliboutput 1.0.4 things works ok.
If I watch vdr-sxfe just from a small window, the subtitle and text are
positioned correctly with a good looking font size to bottom of the
screen. But if I watch finish "yle 1" channel which uses dvb subtitles
from fullscreen vdr-sxfe, the subtitle font is small and text is
positioned about to middle of the screen. (Left position is correct)
Usually if I change from small window to fullsize, the first subtitle text
is showed with good looking font size and position in the bottom-left
position but next subtitle texts after that are positioned in the
middle-left.
Mika
Hi,
Yes, I'm using VDPAU.
And YES the patch seemed to fix issue 2, at least subtitles are much better positioned during cropping. Thanks.
Issue 1 still remains. The problem is easy to notice at Welho network (Helsinki) when switching channel between "TV5MONDE" (often 4:3 letterbox) and "Deutsche Welle" (16:9). DW remains cropped when switched from TV5MONDE and the cropping was turned on for it.
- Kimmo
On 03 Jan 2010, at 22:30, Petri Hintukainen wrote:
> Kimmo Taskinen wrote:
>> Hi,
>>
>> Couple of issues I reported earlier (see below) have now merged to xineliboutput-plugin.
> [...]
>>> 1. Cropping is not reseted if I switch to 16:9 channel that has the same resolution as 4:3 channel that has turned on the cropping.
>>> 2. DVB subtitles are not positioned correctly during cropping if vdr-sxfe is used to show subtitles. Vertical alignment is about at half of the screen.
>
> Are you using vdpau ?
>
> Does the attached patch fix issue 2 ?
>
>
> - Petri
> <autocrop_spu_overlay.diff>_______________________________________________
> vdr mailing list
> vdr@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
===================================================================
RCS file: /cvsroot/xineliboutput/vdr-xineliboutput/xine_post_autocrop.c,v
retrieving revision 1.36
@@ -1459,6 +1512,12 @@
case 0:
/* regular subtitle */
/* Subtitle overlays must be coming somewhere inside xine engine */
+#ifdef VO_CAP_CUSTOM_EXTENT_OVERLAY
+ /* Do not move overlay if video_out has independent video and OSD resolutions */
+ if (event->object.overlay->extent_width > 0 &&
+ event->object.overlay->extent_height > 0)
+ break;
+#endif
if (use_driver_crop) {
if(this->has_driver_crop) {
if(!event->object.overlay->unscaled || !this->has_unscaled_overlay) {