Use a string for options if value zero

Message ID 1145298629.7031.9.camel@wopr.deltab.de
State New
Headers

Commit Message

Andreas Brachold April 17, 2006, 6:30 p.m. UTC
  Hi,

here for vdr-1.3.47 as small enhance, 
use strings for options if value zero.

* Min. user inactivity (min) => none
* EPG scan timeout (h) => none

Maybe is a other text better descriptive,
like "off" or "inactive"

Andreas
  

Comments

Klaus Schmidinger April 22, 2006, 9:38 a.m. UTC | #1
Andreas Brachold wrote:
> Hi,
> 
> here for vdr-1.3.47 as small enhance, 
> use strings for options if value zero.
> 
> * Min. user inactivity (min) => none
> * EPG scan timeout (h) => none
> 
> Maybe is a other text better descriptive,
> like "off" or "inactive"

This would most likely introduce new I18N strings, which
I'd like to avoid at the moment.

Maybe in version 1.5.x...

Klaus
  

Patch

--- menu.c.orig	2006-04-16 14:20:46.000000000 +0200
+++ menu.c	2006-04-17 20:08:30.000000000 +0200
@@ -2235,7 +2235,7 @@ 
 
   Clear();
 
-  Add(new cMenuEditIntItem( tr("Setup.EPG$EPG scan timeout (h)"),      &data.EPGScanTimeout));
+  Add(new cMenuEditIntItem( tr("Setup.EPG$EPG scan timeout (h)"),      &data.EPGScanTimeout, 0, 999, tr("none")));
   Add(new cMenuEditIntItem( tr("Setup.EPG$EPG bugfix level"),          &data.EPGBugfixLevel, 0, MAXEPGBUGFIXLEVEL));
   Add(new cMenuEditIntItem( tr("Setup.EPG$EPG linger time (min)"),     &data.EPGLinger, 0));
   Add(new cMenuEditBoolItem(tr("Setup.EPG$Set system time"),           &data.SetSystemTime));
@@ -2590,7 +2590,7 @@ 
 {
   SetSection(tr("Miscellaneous"));
   Add(new cMenuEditIntItem( tr("Setup.Miscellaneous$Min. event timeout (min)"),   &data.MinEventTimeout));
-  Add(new cMenuEditIntItem( tr("Setup.Miscellaneous$Min. user inactivity (min)"), &data.MinUserInactivity));
+  Add(new cMenuEditIntItem( tr("Setup.Miscellaneous$Min. user inactivity (min)"), &data.MinUserInactivity, 0, 999, tr("none")));
   Add(new cMenuEditIntItem( tr("Setup.Miscellaneous$SVDRP timeout (s)"),          &data.SVDRPTimeout));
   Add(new cMenuEditIntItem( tr("Setup.Miscellaneous$Zap timeout (s)"),            &data.ZapTimeout));
   Add(new cMenuEditChanItem(tr("Setup.Miscellaneous$Initial channel"),            &data.InitialChannel, tr("Setup.Miscellaneous$as before")));