From patchwork Tue Sep 20 14:41:44 2005
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Patchwork-Submitter: =?utf-8?q?Ville_Skytt=C3=A4?= <vskytta@gmail.com>
X-Patchwork-Id: 12033
Received: from smtp1.pp.htv.fi ([213.243.153.37])
	by www.linuxtv.org with esmtp (Exim 4.50) id 1EHjJa-0004uZ-Oz
	for vdr@linuxtv.org; Tue, 20 Sep 2005 16:41:46 +0200
Received: from [192.168.2.4] (cs168006.pp.htv.fi [213.243.168.6])
	by smtp1.pp.htv.fi (Postfix) with ESMTP id 5892C7FC5E
	for <vdr@linuxtv.org>; Tue, 20 Sep 2005 17:41:45 +0300 (EEST)
Subject: Re: [vdr] [bug] vdr-burn-0.0.6h - badly mixed up multiple
	recordings when requanting
From: Ville =?ISO-8859-1?Q?Skytt=E4?= <vskytta@gmail.com>
To: Klaus Schmidinger's VDR <vdr@linuxtv.org>
In-Reply-To: <432FBB39.6010206@calidae.net>
References: <432F5ED1.7030602@users.sourceforge.net>
	<432FB5AE.1040103@teledetection.fr>  <432FBB39.6010206@calidae.net>
Date: Tue, 20 Sep 2005 17:41:44 +0300
Message-Id: <1127227304.13731.16.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) 
X-BeenThere: vdr@linuxtv.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Klaus Schmidinger's VDR <vdr@linuxtv.org>
List-Id: Klaus Schmidinger's VDR <vdr.linuxtv.org>
List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=unsubscribe>
List-Archive: <http://www.linuxtv.org/pipermail/vdr>
List-Post: <mailto:vdr@linuxtv.org>
List-Help: <mailto:vdr-request@linuxtv.org?subject=help>
List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Sep 2005 14:41:46 -0000
Status: O
X-Status: 
X-Keywords: 
X-UID: 5079

On Tue, 2005-09-20 at 09:33 +0200, Leo Márquez wrote:

> I have compiled the 0.0.6h plugin version correctly with vdr-1.3.31 but 
> when I try to use it fails. In dvd.log I see:
> 
> Parameter validation not complete yet
> Initialising and analysing the streams....
> Can not open /video/Passatgers/2005-09-08.22:00.99.99.rec001.vdr: File 
> not exists

That error smells like it's coming from vdrsync.

All the examples in "vdrsync.pl --help" have trailing slashes in
recording dir names and in fact in the 050322 version, at least
get_file_list() (the latter in the file, in the VDRRECORDING package)
looks like it'll break if the path to the recording dir does not end
with a slash.

The attached patch could help (untested).

--- vdrsync.pl~	2005-03-22 21:45:40.000000000 +0200
+++ vdrsync.pl	2005-09-20 17:34:55.000000000 +0300
@@ -5561,13 +5561,13 @@
     closedir $DIR;
 	my @files =   sort (grep { /\d{3}.vdr$/  } @allfiles);
 
-	$self->{summary_file} = $indir . "summary.vdr" if (-e "$indir/summary.vdr");
-	$self->{marks_file} = $indir . "marks.vdr" if (-e "$indir/marks.vdr");
-	$self->{index_file} = $indir . "index.vdr" if (-e "$indir/index.vdr");
-	$self->{chapter_marks_file} = $indir . "chapter_marks.vdr" if (-e "$indir/chapter_marks.vdr");
+	$self->{summary_file} = "$indir/summary.vdr" if (-e "$indir/summary.vdr");
+	$self->{marks_file} = "$indir/marks.vdr" if (-e "$indir/marks.vdr");
+	$self->{index_file} = "$indir/index.vdr" if (-e "$indir/index.vdr");
+	$self->{chapter_marks_file} = "$indir/chapter_marks.vdr" if (-e "$indir/chapter_marks.vdr");
     
 	foreach (@files) {
-		$_ = $indir . $_;
+		$_ = "$indir/$_";
 		#print "trying to open $_\n";
 		my $DUMMYFH;
 		open $DUMMYFH, "$_" or die "Can not open $_: $!\n";