From patchwork Sat Jul 16 19:21:24 2005
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Mikko Salo <mikko.salo@ppe.inet.fi>
X-Patchwork-Id: 11946
Received: from fep18.inet.fi ([194.251.242.243])
	by www.linuxtv.org with esmtp (Exim 4.34) id 1DtsE1-000801-K8
	for vdr@linuxtv.org; Sat, 16 Jul 2005 21:21:25 +0200
Received: from dsl-hmlgw1ffc6.dial.inet.fi ([80.220.250.198])
	by fep18.inet.fi with ESMTP id
	<20050716192125.RVNR15841.fep18.inet.fi@dsl-hmlgw1ffc6.dial.inet.fi>
	for <vdr@linuxtv.org>; Sat, 16 Jul 2005 22:21:25 +0300
Subject: Re: [vdr] Bug #4: Green button does not work without menu
From: Mikko Salo <mikko.salo@ppe.inet.fi>
To: Klaus Schmidinger's VDR <vdr@linuxtv.org>
In-Reply-To: <1121541214.27647.5.camel@localhost.localdomain>
References: <42D806CE.6000701@iki.fi> <42D831C5.2030107@gmx.de>
	<42D8C0D9.7060506@gmx.net> <42D8E020.8090302@iki.fi>
	<42D9463E.9060303@gmail.com>
	<1121541214.27647.5.camel@localhost.localdomain>
Date: Sat, 16 Jul 2005 22:21:24 +0300
Message-Id: <1121541684.27647.11.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.2.3 
X-BeenThere: vdr@linuxtv.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Klaus Schmidinger's VDR <vdr@linuxtv.org>
List-Id: Klaus Schmidinger's VDR <vdr.linuxtv.org>
List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=unsubscribe>
List-Archive: <http://www.linuxtv.org/pipermail/vdr>
List-Post: <mailto:vdr@linuxtv.org>
List-Help: <mailto:vdr-request@linuxtv.org?subject=help>
List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>,
	<mailto:vdr-request@linuxtv.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Jul 2005 19:21:25 -0000
Status: O
X-Status: 
X-Keywords: 
X-UID: 3580

> > >>> Pasi Juppo wrote:
> > >>>
> > >>>> VDR: Green button does not work without menu
> > >>>> -When watching TV broadcast it is not possible to view or change the
> > >>>> audio channels without going first to menu
> > >>>>
> > >>>
> > >>> When watching TV broadcasts, the green button is assigned by the
> > >>> keymacros.conf file, only if the main menu is opened, the green key is
> > >>> permanently assigned to the audio channel menu.
> > >>>
> > >>> If you want the green key assigned to the audio menu, add this line to
> > >>> keymacros.conf:
> > >>>
> > >>>   Green     Menu Green
> > >>>
> > >> or:
> > >>    Green   Audio
> > > 
> > > 
> > > Thanks! Works like a charm. One "bug" down - 11 to go :)
> > > 
> > 
> > Actually, this _is_ a bug. IIRC when there are subtitles (by
> > subtitles-plugin) on the screen, I'm unable to go to the Audio menu,
> > neither from Menu->Green or with Audio button.
> > 
> 
> ...and I belive it was fixed in vdr-1.3.27, it works fine now anyway.
> 

My mistake!

Allways should double check what is going to say, it really wasn't in
vanilla vdr, it was this patch that fixed it. :)

diff -Nru vdr-1.3.26-vanilla/vdr.c vdr-1.3.26-osd-fix/vdr.c
--- vdr-1.3.26-vanilla/vdr.c	2005-05-26 13:45:29.000000000 +0300
+++ vdr-1.3.26-osd-fix/vdr.c	2005-06-13 23:11:20.000000000 +0300
@@ -702,7 +702,7 @@
                   }
                else
                   cDevice::PrimaryDevice()->SetVolume(NORMALKEY(key) == kVolDn ? -VOLUMEDELTA : VOLUMEDELTA);
-               if (!Menu && !cOsd::IsOpen())
+               if (!Menu /*&& !cOsd::IsOpen()*/)
                   Menu = Temp = cDisplayVolume::Create();
                cDisplayVolume::Process(key);
                key = kNone; // nobody else needs to see these keys
@@ -715,7 +715,7 @@
                   DELETENULL(Menu);
                   Temp = NULL;
                   }
-               if (!Menu && !cOsd::IsOpen())
+               if (!Menu /*&& !cOsd::IsOpen()*/)
                   Menu = Temp = cDisplayTracks::Create();
                else
                   cDisplayTracks::Process(key);