From patchwork Thu Apr 7 19:18:07 2005 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Ville_Skytt=C3=A4?= X-Patchwork-Id: 11850 Received: from smtp1.pp.htv.fi ([213.243.153.37]) by www.linuxtv.org with esmtp (Exim 4.34) id 1DJcVj-00064d-5A for vdr@linuxtv.org; Thu, 07 Apr 2005 21:17:51 +0200 Received: from cs78130200.pp.htv.fi (cs78130200.pp.htv.fi [62.78.130.200]) by smtp1.pp.htv.fi (Postfix) with ESMTP id 6F2E87FCB3 for ; Thu, 7 Apr 2005 22:18:07 +0300 (EEST) Subject: Re: [vdr] vdr-xine: what's wrong with this piece of code-- threadingissue? From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: vdr@linuxtv.org In-Reply-To: <424496B3.7060009@gmx.de> References: <1378040502EA7F46A1EB0DB1A826D7A53CC80B@ad-atlas.teklaad.tekla.com> <424496B3.7060009@gmx.de> Date: Thu, 07 Apr 2005 22:18:07 +0300 Message-Id: <1112901487.5228.13.camel@bobcat.mine.nu> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 (2.0.4-2) X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Klaus Schmidinger's VDR List-Id: Klaus Schmidinger's VDR List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2005 19:17:51 -0000 Status: O X-Status: X-Keywords: X-UID: 1477 On Fri, 2005-03-25 at 23:54 +0100, Reinhard Nissl wrote: > Hi, > > Rantanen Teemu wrote: > > >>This typically happens when moving cutting marks, and I'm > >>investigating this already. > >> > >>Expect it for 0.8.0, but the next release will still be 0.7.3. > > > > Looking forward to both 0.8.0 and 0.7.3 ... > > > > In my experience the most problems I've had are starting/ending > > recording, and all rewinds. At these points may happen that xine > > disconnects. Not very often but sometimes. When xine disconnects VDR > > will "play" the recording really fast and it's minutes past the place > > when xine reconnects. I've had no problems with cutting marks... > > Please apply the attached patch to vdr-1.3.23 and tell me, whether there > is any improvement. At least there was one for me ;-) Definitely improves fast forward, rewind, and stuck still picture issues here with DXR3. But, so does the attached patch from the old DXR3 plugin, the functionality with yours or the attached patch seems identical here. Any comments? Workaround for I-frame display problems when cutting (still picture not updating) and/or fast forward/backward in some streams. Apply to: VDR sources More info: http://www.schluenss.de/history.html --- recording.c.orig 2005-02-12 12:17:47.000000000 +0200 +++ recording.c 2005-03-14 23:01:32.370785864 +0200 @@ -1017,8 +1017,8 @@ FileOffset = &index[Index].offset; if (Length) { // all recordings end with a non-I_FRAME, so the following should be safe: - int fn = index[Index + 1].number; - int fo = index[Index + 1].offset; + int fn = index[Index + 2].number; + int fo = index[Index + 2].offset; if (fn == *FileNumber) *Length = fo - *FileOffset; else {