From patchwork Mon Nov 11 11:46:24 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michal Nazarewicz X-Patchwork-Id: 20714 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1Vfpwy-0002Wp-Fa; Mon, 11 Nov 2013 12:46:36 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-5) with esmtp id 1Vfpwv-00026O-9C; Mon, 11 Nov 2013 12:46:36 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753348Ab3KKLq3 (ORCPT + 1 other); Mon, 11 Nov 2013 06:46:29 -0500 Received: from mail-ee0-f44.google.com ([74.125.83.44]:41539 "EHLO mail-ee0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752996Ab3KKLq2 convert rfc822-to-8bit (ORCPT ); Mon, 11 Nov 2013 06:46:28 -0500 Received: by mail-ee0-f44.google.com with SMTP id d51so274993eek.3 for ; Mon, 11 Nov 2013 03:46:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:organization:references :user-agent:face:date:message-id:mime-version:content-type :content-transfer-encoding; bh=JT8K7W8dbKB3XsDWtzr1dQazzr1t/+GjZ/ODozBVBs0=; b=XKlykuo6uri6DYb5QzvXH1wbbXBe2R3TwJ/dj0oLnVwHlPJqqY2MCcH1bcBfIkbOKr xkANKLTvV1hgE4sCG+2STNWO59/q6hYbSUm+1T2OfJtkPdl5fCVCPx9BeEOK/829uIQS WEmE2Peqonnz8b+8Resp9xMKv+kzX2mlhZUlPYqG7Q7zhkiCz2PTm746NYUD28+FYFfB GttvbGRditaYXzyI/9RJ4f1UclxJHOozIxN1ASsVcq6LewsLsi4PcOHozxnn+rW5ynQz 5eilV0YoSxkxuy50Ctob1QsD3jL5JVNl9lPDpoyt2HxChsiim1uco1B4YQ1Lip7vdG9V V6Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to :organization:references:user-agent:face:date:message-id :mime-version:content-type:content-transfer-encoding; bh=JT8K7W8dbKB3XsDWtzr1dQazzr1t/+GjZ/ODozBVBs0=; b=Aas2fK+M+G04SO8M5zH6Ur1AHpSmtJ9Z5Fi56sHLGrWxKyNgMRkrQ8dbAwW1RubGNX rU3YQI+Akl85KcclbXD/+S4xYOZu42fjAtU/NXGJ3FIS1MqitUiQxJH3EoWhJ9f/wA7S jb95eYOtryMBTTWPmyYHqNenqJM7vJsBypRFQNSSYUoA8uEddjbp+Y6wy3D7tH/0TCTr hcBBpVu1DHCQKYRwTwI3vW+eGzaN1A6B0drKZPRpOSLZupXcDl1ycVyhsrUXcTsdd7ic dSI2xY7z+x8NC9RdtmpYBSbV7WXCq/GAU9x+GGfczSAuIdBAybkxYA4H17FYE1fRCR9X kn2Q== X-Gm-Message-State: ALoCoQlMQRCx61EHFfZ70pibfnquWIrFFonUTbcERwTh7blCZPBTjcwBFMbYkny/Cc4pTksQFQZg/LgTpfNNKfaHgiQE5EO6QL0dN/I7l+zDSPvV3wRd7d/d18pwhanU+0jOHdx33J5hsfsxlAVCLRgID9ms6/+FLbUcKAjbamUeHJSPoWcmbSbfoH+OgPCARyWFmCxylIOyfDkYxLrRMVXenE2Js+rOJw== X-Received: by 10.15.54.199 with SMTP id t47mr8500468eew.46.1384170387064; Mon, 11 Nov 2013 03:46:27 -0800 (PST) Received: from mpn-glaptop.roam.corp.google.com ([2620:0:105f:311:f52d:f795:45b0:ff8d]) by mx.google.com with ESMTPSA id v45sm61762771eef.11.2013.11.11.03.46.25 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 11 Nov 2013 03:46:26 -0800 (PST) From: Michal Nazarewicz To: Dan Carpenter Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-media@vger.kernel.org, Hans Verkuil , linux-kernel@vger.kernel.org, Mauro Carvalho Chehab Subject: [PATCHv2] staging: go7007: fix use of uninitialised pointer In-Reply-To: <20131110210647.GA5302@mwanda> Organization: http://mina86.com/ References: <1384108677-23476-1-git-send-email-mpn@google.com> <20131110185210.GA9633@kroah.com> <87fvr480o9.fsf@mina86.com> <20131110210647.GA5302@mwanda> User-Agent: Notmuch/0.15.2+55~geb6e9d8 (http://notmuchmail.org) Emacs/24.3.50.1 (x86_64-unknown-linux-gnu) X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd; KFrfMCylc}gc??'U2j,!8%xdD Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:131111:m.chehab@samsung.com::wZ6+4HlIltROikeZ:000000000000000000000000000000000000000000FdK X-Hashcash: 1:20:131111:dan.carpenter@oracle.com::knAyvAbyDioa1Oey:000000000000000000000000000000000000026Tb X-Hashcash: 1:20:131111:gregkh@linuxfoundation.org::2GAju+MCG5LRnJzW:000000000000000000000000000000000002ZRD X-Hashcash: 1:20:131111:devel@driverdev.osuosl.org::mTBQkAvan4mGO5WI:0000000000000000000000000000000000028ax X-Hashcash: 1:20:131111:linux-kernel@vger.kernel.org::F+3JSlM4s2G+zbJG:0000000000000000000000000000000004QfE X-Hashcash: 1:20:131111:hans.verkuil@cisco.com::VLtzUmh7pAFYb+wX:0000000000000000000000000000000000000006+yU X-Hashcash: 1:20:131111:linux-media@vger.kernel.org::vrTWjoPwtGhIPo7Y:0000000000000000000000000000000000567N Date: Mon, 11 Nov 2013 12:46:24 +0100 Message-ID: MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.11.11.113914 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __INT_PROD_TV 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0, __YOUTUBE_RCVD 0' go variable is initialised only after the switch case so it cannot be dereferenced prior to that happening. Signed-off-by: Michal Nazarewicz --- drivers/staging/media/go7007/go7007-usb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) On Sun, Nov 10 2013, Dan Carpenter wrote: > There are 3 other uses before "go" gets initialized. Argh... Other occurrences of the letters “GO” deceived my eyes. Sorry about that and thanks. diff --git a/drivers/staging/media/go7007/go7007-usb.c b/drivers/staging/media/go7007/go7007-usb.c index 58684da..ee8ab89 100644 --- a/drivers/staging/media/go7007/go7007-usb.c +++ b/drivers/staging/media/go7007/go7007-usb.c @@ -1057,7 +1057,7 @@ static int go7007_usb_probe(struct usb_interface *intf, char *name; int video_pipe, i, v_urb_len; - dev_dbg(go->dev, "probing new GO7007 USB board\n"); + dev_dbg(&intf->dev, "probing new GO7007 USB board\n"); switch (id->driver_info) { case GO7007_BOARDID_MATRIX_II: @@ -1097,13 +1097,13 @@ static int go7007_usb_probe(struct usb_interface *intf, board = &board_px_tv402u; break; case GO7007_BOARDID_LIFEVIEW_LR192: - dev_err(go->dev, "The Lifeview TV Walker Ultra is not supported. Sorry!\n"); + dev_err(&intf->dev, "The Lifeview TV Walker Ultra is not supported. Sorry!\n"); return -ENODEV; name = "Lifeview TV Walker Ultra"; board = &board_lifeview_lr192; break; case GO7007_BOARDID_SENSORAY_2250: - dev_info(go->dev, "Sensoray 2250 found\n"); + dev_info(&intf->dev, "Sensoray 2250 found\n"); name = "Sensoray 2250/2251"; board = &board_sensoray_2250; break; @@ -1112,7 +1112,7 @@ static int go7007_usb_probe(struct usb_interface *intf, board = &board_ads_usbav_709; break; default: - dev_err(go->dev, "unknown board ID %d!\n", + dev_err(&intf->dev, "unknown board ID %d!\n", (unsigned int)id->driver_info); return -ENODEV; }