From patchwork Tue Feb 24 14:52:49 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Richter X-Patchwork-Id: 820 Return-path: X-OfflineIMAP-x1560540329-426f6d626164696c-494e424f582e6c696e75782d6d65646961: 1241182467-0191147067968-v6.0.3 X-OfflineIMAP-1993893170-4c6f63616c-496e667261646561642e6c696e75782d6d65646961: 1241138563-0503637515501-v6.0.3 Envelope-to: mchehab@infradead.org Delivery-date: Tue, 24 Feb 2009 14:53:39 +0000 Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1LbyfC-0006tf-Kv for mchehab@infradead.org; Tue, 24 Feb 2009 14:53:39 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758138AbZBXOxU (ORCPT ); Tue, 24 Feb 2009 09:53:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758135AbZBXOxU (ORCPT ); Tue, 24 Feb 2009 09:53:20 -0500 Received: from einhorn.in-berlin.de ([192.109.42.8]:45925 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758005AbZBXOxT (ORCPT ); Tue, 24 Feb 2009 09:53:19 -0500 X-Envelope-From: stefanr@s5r6.in-berlin.de Received: from stein ([83.221.231.7]) (authenticated bits=0) by einhorn.in-berlin.de (8.13.6/8.13.6/Debian-1) with ESMTP id n1OEqqDS022981; Tue, 24 Feb 2009 15:52:59 +0100 Date: Tue, 24 Feb 2009 15:52:49 +0100 (CET) From: Stefan Richter Subject: [PATCH update] firedtv: dvb_frontend_info for FireDTV S2, fix "frequency limits undefined" error To: Beat Michel Liechti cc: linux1394-devel@lists.sourceforge.net, linux-media@vger.kernel.org, Ben Backx , Henrik Kurelid In-Reply-To: Message-ID: References: <3e03d4060902231447r1df9f8d0pe65a50773af7fa67@mail.gmail.com> MIME-Version: 1.0 Content-Disposition: INLINE X-Scanned-By: MIMEDefang_at_IN-Berlin_e.V. on 192.109.42.8 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Beat Michel Liechti I found that the function fdtv_frontend_init in the file firedtv-fe.c was missing a case for FIREDTV_DVB_S2 which resulted in "frequency limits undefined" errors in syslog. Signed-off-by: Beat Michel Liechti Change by Stefan R: combine it with case case FIREDTV_DVB_S as originally suggested by Beat Michel. This enables FE_CAN_FEC_AUTO also for FireDTV-S2 devices which is possible as long as only DVB-S channels are used. FE_CAN_FEC_AUTO would be wrong for DVB-S2 channels, but those cannot be used yet since the driver is not yet converted to S2API. Signed-off-by: Stefan Richter --- If you don't mind, I commit this for now (want to send a mainline pull request later today) and we work out any remaining loose DVB-S2 ends from there. drivers/media/dvb/firewire/firedtv-fe.c | 1 + 1 file changed, 1 insertion(+) Index: linux/drivers/media/dvb/firewire/firedtv-fe.c =================================================================== --- linux.orig/drivers/media/dvb/firewire/firedtv-fe.c +++ linux/drivers/media/dvb/firewire/firedtv-fe.c @@ -185,6 +185,7 @@ void fdtv_frontend_init(struct firedtv * switch (fdtv->type) { case FIREDTV_DVB_S: + case FIREDTV_DVB_S2: fi->type = FE_QPSK; fi->frequency_min = 950000;