media: ti: cal: Constify struct media_entity_operations

Message ID fa248cf5c11c480e73a342ab3b3fb2aa93c21e47.1719174792.git.christophe.jaillet@wanadoo.fr (mailing list archive)
State New
Delegated to: Hans Verkuil
Headers
Series media: ti: cal: Constify struct media_entity_operations |

Commit Message

Christophe JAILLET June 24, 2024, 4:40 a.m. UTC
  'struct media_entity_operations' is not modified in this driver.

Constifying this structure moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig, as an example:
Before:
======
   text	   data	    bss	    dec	    hex	filename
  20694	   1394	     32	  22120	   5668	drivers/media/platform/ti/cal/cal-camerarx.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
  20726	   1362	     32	  22120	   5668	drivers/media/platform/ti/cal/cal-camerarx.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested-only
---
 drivers/media/platform/ti/cal/cal-camerarx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Patch

diff --git a/drivers/media/platform/ti/cal/cal-camerarx.c b/drivers/media/platform/ti/cal/cal-camerarx.c
index 4afc2ad00330..42dfe08b765f 100644
--- a/drivers/media/platform/ti/cal/cal-camerarx.c
+++ b/drivers/media/platform/ti/cal/cal-camerarx.c
@@ -798,7 +798,7 @@  static const struct v4l2_subdev_internal_ops cal_camerarx_internal_ops = {
 	.init_state = cal_camerarx_sd_init_state,
 };
 
-static struct media_entity_operations cal_camerarx_media_ops = {
+static const struct media_entity_operations cal_camerarx_media_ops = {
 	.link_validate = v4l2_subdev_link_validate,
 };