From patchwork Wed May 5 20:17:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 74087 X-Patchwork-Delegate: sakari.ailus@iki.fi Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1leNxU-005zPl-Vx; Wed, 05 May 2021 20:17:25 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234000AbhEEUST (ORCPT + 1 other); Wed, 5 May 2021 16:18:19 -0400 Received: from smtp08.smtpout.orange.fr ([80.12.242.130]:25361 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233948AbhEEUSS (ORCPT ); Wed, 5 May 2021 16:18:18 -0400 Received: from localhost.localdomain ([86.243.172.93]) by mwinf5d16 with ME id 18HL2500121Fzsu038HLyU; Wed, 05 May 2021 22:17:20 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Wed, 05 May 2021 22:17:20 +0200 X-ME-IP: 86.243.172.93 From: Christophe JAILLET To: prabhakar.csengg@gmail.com, mchehab@kernel.org, sakari.ailus@linux.intel.com, bparrot@ti.com, hans.verkuil@cisco.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH V2] media: i2c: ov2659: Fix an error message Date: Wed, 5 May 2021 22:17:17 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -7.4 (-------) X-LSpam-Report: No, score=-7.4 required=5.0 tests=BAYES_00=-1.9,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_HI=-5 autolearn=ham autolearn_force=no 'ret' is known to be 0 here and printing -ENODEV wouldn't be really helpful. So remove it from the error message. Signed-off-by: Christophe JAILLET Acked-by: Lad Prabhakar --- V2: Remove the Fixes tag. It doesn't really fix something, it just removes a useless information. Just remove ret. No need to add something else. --- drivers/media/i2c/ov2659.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c index 42f64175a6df..6bbbb94fdda4 100644 --- a/drivers/media/i2c/ov2659.c +++ b/drivers/media/i2c/ov2659.c @@ -1368,8 +1368,7 @@ static int ov2659_detect(struct v4l2_subdev *sd) id = OV265X_ID(pid, ver); if (id != OV2659_ID) { dev_err(&client->dev, - "Sensor detection failed (%04X, %d)\n", - id, ret); + "Sensor detection failed (%04X)\n", id); ret = -ENODEV; } else { dev_info(&client->dev, "Found OV%04X sensor\n", id);