From patchwork Sat Aug 26 08:05:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 94339 Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1qZoJ8-008FGw-6K; Sat, 26 Aug 2023 08:06:10 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231997AbjHZIFg (ORCPT + 1 other); Sat, 26 Aug 2023 04:05:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232158AbjHZIFV (ORCPT ); Sat, 26 Aug 2023 04:05:21 -0400 Received: from smtp.smtpout.orange.fr (smtp-20.smtpout.orange.fr [80.12.242.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D31641FF0 for ; Sat, 26 Aug 2023 01:05:14 -0700 (PDT) Received: from pop-os.home ([86.243.2.178]) by smtp.orange.fr with ESMTPA id ZoIAqIrNMOQiUZoIAqOb6j; Sat, 26 Aug 2023 10:05:13 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1693037113; bh=1Gj5BE4925dZFZIgp6qeJNN2Uh0t4RwmAE2vfWPWlHg=; h=From:To:Cc:Subject:Date; b=Mtc9wkbD2Qb8iaLZJqRusvwUfBsgZTlNj8sxJfPvYTXbiaFLTh6bJj15oKxTBvlgL TFu0tT6abzOIl5F3NdyJlvMd0NJ7GnAA6WcKavJec/bMe/i0+kXhxOxnmv5Zm8xQ0s R1wb24yQFsg8tEw2VpWL3dZAyFmsOA5SxDzfrbbuzc3V3dF7eP59f33eq6wm1KgMqA kGtTriSrJfCA8EGGGFjePAYk6JaCCh/tfyrXrzFD1iJx/13e3hZosTewFqufuriEzs 2ljWaf6jsM8O0GGLZ2UDTPJYXM12jfEiQaF0qoYz4Oeo7HXKPJF7eEIKNkrVoTrQYh GGl8ek4DCIstA== X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 26 Aug 2023 10:05:13 +0200 X-ME-IP: 86.243.2.178 From: Christophe JAILLET To: Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Nik?= =?utf-8?q?las_S=C3=B6derlund?= , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-media@vger.kernel.org Subject: [PATCH] media: i2c: rdacm2: Remove an incorrect fwnode_handle_put() call Date: Sat, 26 Aug 2023 10:05:06 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no The commit in Fixes has removed an fwnode_handle_put() call in the error handling path of the probe. Remove the same call from the remove function. Fixes: 1029939b3782 ("media: v4l: async: Simplify async sub-device fwnode matching") Signed-off-by: Christophe JAILLET Reviewed-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- /!\ This patch is highly speculative. Review with care. /!\ If it is correct, it is likely that other similar issue lurk in commit 1029939b3782. I've not looked in detail and my cocci script did not trigger on them but drivers/media/i2c/max9286.c also looks like a similar candidate. --- drivers/media/i2c/rdacm21.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c index a36a709243fd..3e22df36354f 100644 --- a/drivers/media/i2c/rdacm21.c +++ b/drivers/media/i2c/rdacm21.c @@ -608,7 +608,6 @@ static void rdacm21_remove(struct i2c_client *client) v4l2_async_unregister_subdev(&dev->sd); v4l2_ctrl_handler_free(&dev->ctrls); i2c_unregister_device(dev->isp); - fwnode_handle_put(dev->sd.fwnode); } static const struct of_device_id rdacm21_of_ids[] = {