[0/5] address W=1 warnings at staging/media/atomisp
| Message ID | cover.1599141140.git.mchehab+huawei@kernel.org (mailing list archive) |
|---|---|
| Headers |
Received: from vger.kernel.org ([23.128.96.18])
by www.linuxtv.org with esmtp (Exim 4.92)
(envelope-from <linux-media-owner@vger.kernel.org>)
id 1kDqhd-00D5mX-H0; Thu, 03 Sep 2020 14:59:06 +0000
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S1729390AbgICPEh (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other);
Thu, 3 Sep 2020 11:04:37 -0400
Received: from mail.kernel.org ([198.145.29.99]:47836 "EHLO mail.kernel.org"
rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
id S1728903AbgICN6Q (ORCPT <rfc822;linux-media@vger.kernel.org>);
Thu, 3 Sep 2020 09:58:16 -0400
Received: from mail.kernel.org (ip5f5ad5c3.dynamic.kabel-deutschland.de
[95.90.213.195])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by mail.kernel.org (Postfix) with ESMTPSA id 0FC3A208C7;
Thu, 3 Sep 2020 13:57:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
s=default; t=1599141456;
bh=JRCHmfWSpGS/adPTYfUKHsn7RfTWRGVyO5P/nq3YOkc=;
h=From:To:Cc:Subject:Date:From;
b=Idg4Rja7N7FMEZFZwiBpLmqRTEqC0YdAOZONfuamJvwWBO8Z0sOoQji7u1KPsJhaF
9LOk9B0Bqur1HyDPEZ8LGJVUGECpYDswhlp4vHva94hQQghMXG3FhKNsA0a97Kxj0c
rRoAlIZmJNBXYHh3WQBG4iBjdVALGd6YvFNEEMjc=
Received: from mchehab by mail.kernel.org with local (Exim 4.94)
(envelope-from <mchehab@kernel.org>)
id 1kDpk6-004T6i-2b; Thu, 03 Sep 2020 15:57:34 +0200
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
devel@driverdev.osuosl.org,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Anant Thazhemadam <anant.thazhemadam@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/5] address W=1 warnings at staging/media/atomisp
Date: Thu, 3 Sep 2020 15:57:27 +0200
Message-Id: <cover.1599141140.git.mchehab+huawei@kernel.org>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
To: unlisted-recipients:; (no To-header on input)
Sender: linux-media-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-media.vger.kernel.org>
X-Mailing-List: linux-media@vger.kernel.org
X-LSpam-Score: -2.8 (--)
X-LSpam-Report: No,
score=-2.8 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,MAILING_LIST_MULTI=-1,T_DKIM_INVALID=0.01
autolearn=ham autolearn_force=no
|
Message
Mauro Carvalho Chehab
Sept. 3, 2020, 1:57 p.m. UTC
The linux-media policy is to have zero warnings with W=1. However, when
I started using a Jenkins instance at https://builder.linuxtv.org to automate
such tests, I didn't notice that a bug at the scripts were just ignoring
warnings.
Now that this is fixed, we need to get rid of the warnings that got
re-introduced when the atomisp driver was reverted, as otherwise,
every time a common header is touched, we'll see messages like
those:
Error/warnings:
patches/0001-media-mxl5xx-remove-unused-including-linux-version.h.patch:
allyesconfig: return code #0:
../drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:164:2: warning: function ‘atomisp_css2_dbg_print’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
../drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:170:2: warning: function ‘atomisp_css2_dbg_ftrace_print’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
../drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:170:2: warning: function ‘atomisp_css2_dbg_ftrace_print’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
../drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:176:2: warning: function ‘atomisp_css2_err_print’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
../drivers/staging/media/atomisp/pci/atomisp_cmd.c:2814:31: warning: variable ‘stream_config’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/atomisp_cmd.c:2893:31: warning: variable ‘stream_config’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/atomisp_v4l2.c:1432:15: warning: variable ‘a0_max_id’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/sh_css_mipi.c:410:27: warning: variable ‘mipi_intermediate_info’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/sh_css.c:1366:24: warning: variable ‘stream’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/sh_css.c:2702:22: warning: variable ‘capture_pipe’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/sh_css.c:2831:7: warning: variable ‘continuous’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/sh_css.c:3534:15: warning: variable ‘num_output_pins’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/sh_css.c:3937:55: warning: variable ‘vf_pp_binary’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/sh_css.c:3937:38: warning: variable ‘preview_binary’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/sh_css.c:3937:24: warning: variable ‘copy_binary’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/sh_css.c:3936:26: warning: variable ‘me’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/sh_css.c:5749:24: warning: variable ‘copy_binary’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/sh_css.c:6013:7: warning: variable ‘continuous’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/sh_css.c:6012:7: warning: variable ‘memory’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/sh_css.c:7329:24: warning: variable ‘copy_binary’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/sh_css.c:7459:26: warning: variable ‘num_vf_pp_stage’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/sh_css.c:10420:22: warning: variable ‘pipe_id’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/sh_css_param_shading.c:239:4: warning: variable ‘padded_width’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/sh_css_params.c:1099:36: warning: variable ‘row_padding’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c:237:31: warning: variable ‘isp_data_ptr’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_2/ia_css_sdis2.host.c:119:28: warning: variable ‘ver_num_isp’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_2/ia_css_sdis2.host.c:119:15: warning: variable ‘hor_num_isp’ set but not used [-Wunused-but-set-variable]
../drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c:127:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable]
In file included from ../drivers/staging/media/atomisp//pci/hive_isp_css_include/input_formatter.h:34,
from ../drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c:55:
../drivers/staging/media/atomisp//pci/hive_isp_css_common/host/input_formatter_local.h:118:27: warning: ‘input_formatter_alignment’ defined but not used [-Wunused-const-variable=]
../drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c:244:7: warning: variable ‘succes’ set but not used [-Wunused-but-set-variable]
allyesconfig: return code #0:
../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:3204 video_put_user() warn: check that 'ev32' doesn't leak information (struct has a hole after 'type')
../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:3229 video_put_user() warn: check that 'vb32' doesn't leak information (struct has a hole after 'memory')
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2841 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1200 vivid_create_instance() parse error: turning off implications after 60 seconds
../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1531 vivid_create_instance() parse error: __split_smt: function too hairy. Giving up after 301 seconds
This series solve all atomisp W=1 warnings.
Mauro Carvalho Chehab (5):
media: atomisp: get rid of some cleanup leftovers
media: atomisp: print a warning if error while setting downscaler
media: atomisp: get rid of unused vars
media: atomisp: move a static constant out of a header file
media: atomisp: get rid of -Wsuggest-attribute=format warnings
.../staging/media/atomisp/pci/atomisp_cmd.c | 6 ---
.../media/atomisp/pci/atomisp_compat_css20.c | 20 ++------
.../staging/media/atomisp/pci/atomisp_v4l2.c | 3 --
.../host/input_formatter.c | 4 ++
.../host/input_formatter_local.h | 4 --
.../staging/media/atomisp/pci/ia_css_env.h | 4 +-
.../isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c | 3 --
.../kernels/sdis/sdis_2/ia_css_sdis2.host.c | 3 --
.../isp/kernels/vf/vf_1.0/ia_css_vf.host.c | 5 ++
.../atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 4 +-
drivers/staging/media/atomisp/pci/sh_css.c | 47 ++-----------------
.../staging/media/atomisp/pci/sh_css_mipi.c | 12 -----
.../media/atomisp/pci/sh_css_param_shading.c | 25 +++-------
.../staging/media/atomisp/pci/sh_css_params.c | 3 +-
14 files changed, 29 insertions(+), 114 deletions(-)