From patchwork Thu Jul 24 23:20:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugh Dickins X-Patchwork-Id: 25025 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1XASLM-0005fV-Dn; Fri, 25 Jul 2014 01:22:36 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-7) with esmtp id 1XASLI-0005RE-00; Fri, 25 Jul 2014 01:22:34 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935057AbaGXXWQ (ORCPT + 1 other); Thu, 24 Jul 2014 19:22:16 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:45148 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935008AbaGXXWO (ORCPT ); Thu, 24 Jul 2014 19:22:14 -0400 Received: by mail-pd0-f174.google.com with SMTP id fp1so4532989pdb.19 for ; Thu, 24 Jul 2014 16:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version:content-type; bh=z5kTkAT8rJITKF4BKea+8mZZQSpjbkOmiXMJ+0h9SGk=; b=NWNSciiLsZ46F54pbC4OWH47O6B6+K0qm0rQ9NOrpezDKafMwegXLUaaCVDRmIstJc cMHT2ZLpmEXnLZ3uYXwheTR8HrtH1Tf0CXxEyWj3PvBBr6UxWUl8yI6WaYi98ReoQz3E Ttp2iux64Qm52gDwrKfqNHmEknkyBdkl5alXazA5Wq0KBWJCTnSyE/tTBCRoYTww2Pkx 6G97yS9PJG8nU40sdEnGK91wMYTiZRdC7ARSIuFlFk0WhPY9ux1QR3/rNR1b4eZtb+nK LqRuTXFb1VvrrO/V28ZrHi+Rjqmwp1MQ/urPAVP59zwXV9wARk5AYX8obarbW7yjaIDh O12Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; bh=z5kTkAT8rJITKF4BKea+8mZZQSpjbkOmiXMJ+0h9SGk=; b=bcAwizQK0fmvsdsp9EgUrWiooYEEeNWNTBeXApwRy63pHRYcNCbVDKPf240IcM8Nhu tSv8xkIekLra8dhMKXyTyhTcjKW7FNxCNEtMbDrUrMjQeDX9N24KMN/oxkw7WF/WgRvy FUPPqcjV8p+owtJNr6HDflwJXa4u1N+kV9CKLqmRYb+ETqMsA6q77IM4Ijoj7GWZYXsU TCmZH2SXtpD1enmsLxR3rrdeqR6+bGyl/u9GDuIVBRbF71U6Q2ZE+NxWIYTXCjU7uawt 8CREH4jdUyrVV5HTai6ILA9du+bnd/4H6PkuG2bJD7dg4SbowfZqse/9FuFrMjUIU98X uSNA== X-Gm-Message-State: ALoCoQnFnfJr78YmZJrczpM00AzV9RVAddg43KekBQy5nMicIDet7BrqzuqezVnakt3g3ryD1Nvh X-Received: by 10.69.17.230 with SMTP id gh6mr14707423pbd.0.1406244134048; Thu, 24 Jul 2014 16:22:14 -0700 (PDT) Received: from [100.110.60.10] ([216.239.55.194]) by mx.google.com with ESMTPSA id fm12sm9005588pdb.46.2014.07.24.16.22.12 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 24 Jul 2014 16:22:13 -0700 (PDT) Date: Thu, 24 Jul 2014 16:20:25 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Martin Kepplinger cc: Daniel Vetter , Zhang Rui , "rjw@rjwysocki.net" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-media@vger.kernel.org Subject: Re: [BUG] rc1 rc2 rc3 not bootable - black screen after kernel loading In-Reply-To: <53D131E7.2090304@posteo.de> Message-ID: References: <53A6E72A.9090000@posteo.de> <744357E9AAD1214791ACBA4B0B90926301379B97@SHSMSX101.ccr.corp.intel.com> <53A81BF7.3030207@posteo.de> <1403529246.4686.6.camel@rzhang1-toshiba> <53A83DC7.1010606@posteo.de> <1403882067.16305.124.camel@rzhang1-toshiba> <53ADB359.4010401@posteo.de> <53ADCB24.9030206@posteo.de> <53ADECDA.60600@posteo.de> <53B11749.3020902@posteo.de> <1404116299.8366.0.camel@rzhang1-toshiba> <1404116444.8366.1.camel@rzhang1-toshiba> <53B12723.4080902@posteo.de> <53B13E4B.2080603@posteo.de> <53D131E7.2090304@posteo.de> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.7.24.230919 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, ECARD_KNOWN_DOMAINS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __FORWARDED_MSG 0, __FRAUD_REFNUM 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __INT_PROD_COMP 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0, __YOUTUBE_RCVD 0' On Thu, 24 Jul 2014, Martin Kepplinger wrote: > Am 2014-06-30 12:39, schrieb Martin Kepplinger: > > back to aaeb2554337217dfa4eac2fcc90da7be540b9a73 as the first bad > > commit. why is this not revertable exactly? how can I show a complete > > list of commits this merge introduces? > > > > It seems that _nobody_ is running a simple 32 bit i915 (acer) laptop. > rc6 is still unusable. Black screen directly after kernel-loading. no > change since rc1. > > Seems like I won't be able to use 3.16. I'm happy to test patches and am > happy for any advice what to do, when time permits. Martin, I know nothing about aaeb25543372 and why it should be relevant, but if you're having rc1..rc6 32-bit i915 black screens, please try this patch that Daniel Vetter put in his fixes queue on Monday, which I'm hoping will reach Linus for -rc7. Hugh [PATCH] drm/i915: fix freeze with blank screen booting highmem x86_64 boots and displays fine, but booting x86_32 with CONFIG_HIGHMEM has frozen with a blank screen throughout 3.16-rc on this ThinkPad T420s, with i915 generation 6 graphics. Fix 9d0a6fa6c5e6 ("drm/i915: add render state initialization"): kunmap() takes struct page * argument, not virtual address. Which the compiler kindly points out, if you use the appropriate u32 *batch, instead of silencing it with a void *. Why did bisection lead decisively to nearby 229b0489aa75 ("drm/i915: add null render states for gen6, gen7 and gen8")? Because the u32 deposited at that virtual address by the previous stub failed the PageHighMem test, and so caused no harm. Signed-off-by: Hugh Dickins --- drivers/gpu/drm/i915/i915_gem_render_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- 3.16-rc/drivers/gpu/drm/i915/i915_gem_render_state.c 2014-06-16 00:28:52.384076465 -0700 +++ linux/drivers/gpu/drm/i915/i915_gem_render_state.c 2014-07-21 20:10:03.824481521 -0700 @@ -31,7 +31,7 @@ struct i915_render_state { struct drm_i915_gem_object *obj; unsigned long ggtt_offset; - void *batch; + u32 *batch; u32 size; u32 len; }; @@ -80,7 +80,7 @@ free: static void render_state_free(struct i915_render_state *so) { - kunmap(so->batch); + kunmap(kmap_to_page(so->batch)); i915_gem_object_ggtt_unpin(so->obj); drm_gem_object_unreference(&so->obj->base); kfree(so);