From patchwork Mon Aug 16 16:27:47 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 4132 Return-path: Envelope-to: mchehab@pedra Delivery-date: Mon, 16 Aug 2010 13:31:01 -0300 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from ) id 1Ol2aR-00047P-Rs for mchehab@pedra; Mon, 16 Aug 2010 13:30:59 -0300 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.17) for (single-drop); Mon, 16 Aug 2010 13:30:59 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1Ol2ZT-0002vd-Hg; Mon, 16 Aug 2010 16:29:59 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755131Ab0HPQ1v (ORCPT + 1 other); Mon, 16 Aug 2010 12:27:51 -0400 Received: from mgw2.diku.dk ([130.225.96.92]:50803 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755115Ab0HPQ1t (ORCPT ); Mon, 16 Aug 2010 12:27:49 -0400 Received: from localhost (localhost [127.0.0.1]) by mgw2.diku.dk (Postfix) with ESMTP id 366B119BE21; Mon, 16 Aug 2010 18:27:48 +0200 (CEST) Received: from mgw2.diku.dk ([127.0.0.1]) by localhost (mgw2.diku.dk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 24017-19; Mon, 16 Aug 2010 18:27:47 +0200 (CEST) Received: from nhugin.diku.dk (nhugin.diku.dk [130.225.96.140]) by mgw2.diku.dk (Postfix) with ESMTP id 2D3B119BE5F; Mon, 16 Aug 2010 18:27:47 +0200 (CEST) Received: from ask.diku.dk (ask.diku.dk [130.225.96.225]) by nhugin.diku.dk (Postfix) with ESMTP id 936BA6DFCFF; Mon, 16 Aug 2010 18:26:20 +0200 (CEST) Received: by ask.diku.dk (Postfix, from userid 3767) id 1117E200C3; Mon, 16 Aug 2010 18:27:47 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by ask.diku.dk (Postfix) with ESMTP id 0889D200BD; Mon, 16 Aug 2010 18:27:47 +0200 (CEST) Date: Mon, 16 Aug 2010 18:27:47 +0200 (CEST) From: Julia Lawall To: Antoine Jacquet , Mauro Carvalho Chehab , linux-usb@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 11/16] drivers/media/video: Use available error codes Message-ID: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Sender: Mauro Carvalho Chehab From: Julia Lawall Error codes are stored in rc, but the return value is always 0. Return rc instead. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r@ local idexpression x; constant C; @@ if (...) { ... x = -C ... when != x ( return <+...x...+>; | return NULL; | return; | * return ...; ) } // Signed-off-by: Julia Lawall --- This changes the semantics of the function, but currently its return value is ignored. Alternatively, the function could be converted to return nothing. drivers/media/video/zr364xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/video/zr364xx.c b/drivers/media/video/zr364xx.c index a82b5bd..616c61f 100644 --- a/drivers/media/video/zr364xx.c +++ b/drivers/media/video/zr364xx.c @@ -572,7 +572,7 @@ static int zr364xx_got_frame(struct zr364xx_camera *cam, int jpgsize) DBG("wakeup [buf/i] [%p/%d]\n", buf, buf->vb.i); unlock: spin_unlock_irqrestore(&cam->slock, flags); - return 0; + return rc; } /* this function moves the usb stream read pipe data