From patchwork Mon Aug 16 16:26:13 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 4131 Return-path: Envelope-to: mchehab@pedra Delivery-date: Mon, 16 Aug 2010 13:27:32 -0300 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from ) id 1Ol2X6-00043Z-50 for mchehab@pedra; Mon, 16 Aug 2010 13:27:32 -0300 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.17) for (single-drop); Mon, 16 Aug 2010 13:27:31 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1Ol2WE-0002a3-9L; Mon, 16 Aug 2010 16:26:38 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754838Ab0HPQ0S (ORCPT + 1 other); Mon, 16 Aug 2010 12:26:18 -0400 Received: from mgw2.diku.dk ([130.225.96.92]:34747 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754722Ab0HPQ0Q (ORCPT ); Mon, 16 Aug 2010 12:26:16 -0400 Received: from localhost (localhost [127.0.0.1]) by mgw2.diku.dk (Postfix) with ESMTP id E35C819BE6B; Mon, 16 Aug 2010 18:26:14 +0200 (CEST) Received: from mgw2.diku.dk ([127.0.0.1]) by localhost (mgw2.diku.dk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 25262-10; Mon, 16 Aug 2010 18:26:13 +0200 (CEST) Received: from nhugin.diku.dk (nhugin.diku.dk [130.225.96.140]) by mgw2.diku.dk (Postfix) with ESMTP id E0AD719BE21; Mon, 16 Aug 2010 18:26:13 +0200 (CEST) Received: from ask.diku.dk (ask.diku.dk [130.225.96.225]) by nhugin.diku.dk (Postfix) with ESMTP id 550776DFBC6; Mon, 16 Aug 2010 18:24:47 +0200 (CEST) Received: by ask.diku.dk (Postfix, from userid 3767) id C672C200C3; Mon, 16 Aug 2010 18:26:13 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by ask.diku.dk (Postfix) with ESMTP id C1D60200BD; Mon, 16 Aug 2010 18:26:13 +0200 (CEST) Date: Mon, 16 Aug 2010 18:26:13 +0200 (CEST) From: Julia Lawall To: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 6/16] drivers/media: Use available error codes Message-ID: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Sender: Mauro Carvalho Chehab From: Julia Lawall In each case, error codes are stored in rc, but the return value is always 0. Return rc instead. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r@ local idexpression x; constant C; @@ if (...) { ... x = -C ... when != x ( return <+...x...+>; | return NULL; | return; | * return ...; ) } // Signed-off-by: Julia Lawall --- The changes change the semantics and are not tested. In the second case, the function is used in only one place and the return value is igored. drivers/media/dvb/frontends/drx397xD.c | 2 +- drivers/media/video/s2255drv.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/dvb/frontends/drx397xD.c b/drivers/media/dvb/frontends/drx397xD.c index f74cca6..a05007c 100644 --- a/drivers/media/dvb/frontends/drx397xD.c +++ b/drivers/media/dvb/frontends/drx397xD.c @@ -232,7 +232,7 @@ static int write_fw(struct drx397xD_state *s, enum blob_ix ix) exit_rc: read_unlock(&fw[s->chip_rev].lock); - return 0; + return rc; } /* Function is not endian safe, use the RD16 wrapper below */ diff --git a/drivers/media/video/s2255drv.c b/drivers/media/video/s2255drv.c index 8ec7c9a..8f74341 100644 --- a/drivers/media/video/s2255drv.c +++ b/drivers/media/video/s2255drv.c @@ -600,7 +600,7 @@ static int s2255_got_frame(struct s2255_channel *channel, int jpgsize) dprintk(2, "%s: [buf/i] [%p/%d]\n", __func__, buf, buf->vb.i); unlock: spin_unlock_irqrestore(&dev->slock, flags); - return 0; + return rc; } static const struct s2255_fmt *format_by_fourcc(int fourcc)