From patchwork Sun Nov 8 17:49:05 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 2026 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Sun, 08 Nov 2009 17:49:26 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra.chehab.org with IMAP (fetchmail-6.3.6) for (single-drop); Sun, 08 Nov 2009 15:53:37 -0200 (BRST) Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1N7BtF-0002eD-Ru; Sun, 08 Nov 2009 17:49:26 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754806AbZKHRtF (ORCPT + 1 other); Sun, 8 Nov 2009 12:49:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754668AbZKHRtE (ORCPT ); Sun, 8 Nov 2009 12:49:04 -0500 Received: from mgw2.diku.dk ([130.225.96.92]:59468 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754600AbZKHRtD (ORCPT ); Sun, 8 Nov 2009 12:49:03 -0500 Received: from localhost (localhost [127.0.0.1]) by mgw2.diku.dk (Postfix) with ESMTP id 856C419BBA1; Sun, 8 Nov 2009 18:49:07 +0100 (CET) Received: from mgw2.diku.dk ([127.0.0.1]) by localhost (mgw2.diku.dk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 07515-10; Sun, 8 Nov 2009 18:49:06 +0100 (CET) Received: from nhugin.diku.dk (nhugin.diku.dk [130.225.96.140]) by mgw2.diku.dk (Postfix) with ESMTP id 17B1419BB98; Sun, 8 Nov 2009 18:49:06 +0100 (CET) Received: from ask.diku.dk (ask.diku.dk [130.225.96.225]) by nhugin.diku.dk (Postfix) with ESMTP id 27F2E6DF823; Sun, 8 Nov 2009 18:46:01 +0100 (CET) Received: by ask.diku.dk (Postfix, from userid 3767) id F3CD6412E; Sun, 8 Nov 2009 18:49:05 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by ask.diku.dk (Postfix) with ESMTP id EB43B40CB; Sun, 8 Nov 2009 18:49:05 +0100 (CET) Date: Sun, 8 Nov 2009 18:49:05 +0100 (CET) From: Julia Lawall To: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drivers/media/video: correct initialization of audio_mode Message-ID: MIME-Version: 1.0 X-Virus-Scanned: amavisd-new at diku.dk Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Julia Lawall This initialization of the value of audio_mode is the one used if nothing matches in the subsequent switch. The variable audio_mode is subsequently assigned to constants such as TUNER_AUDIO_MONO and TUNER_AUDIO_STEREO. TUNER_AUDIO_STEREO has the same value as V4L2_TUNER_MODE_STEREO, so it would seem better to use that value here. Signed-off-by: Julia Lawall --- drivers/media/video/saa717x.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/video/saa717x.c b/drivers/media/video/saa717x.c index b15c409..a00fb25 100644 --- a/drivers/media/video/saa717x.c +++ b/drivers/media/video/saa717x.c @@ -1312,7 +1312,7 @@ static int saa717x_s_tuner(struct v4l2_subdev *sd, struct v4l2_tuner *vt) "MONO", "STEREO", "LANG1", "LANG2/SAP" }; - audio_mode = V4L2_TUNER_MODE_STEREO; + audio_mode = TUNER_AUDIO_STEREO; switch (vt->audmode) { case V4L2_TUNER_MODE_MONO: