From patchwork Sat Sep 19 19:48:17 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 1634 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Sat, 19 Sep 2009 19:48:35 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra.chehab.org with IMAP (fetchmail-6.3.6) for (single-drop); Sat, 19 Sep 2009 16:51:29 -0300 (BRT) Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1Mp5v8-0001aB-2d; Sat, 19 Sep 2009 19:48:34 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750747AbZISTsR (ORCPT + 1 other); Sat, 19 Sep 2009 15:48:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750879AbZISTsR (ORCPT ); Sat, 19 Sep 2009 15:48:17 -0400 Received: from mgw2.diku.dk ([130.225.96.92]:41320 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750747AbZISTsQ (ORCPT ); Sat, 19 Sep 2009 15:48:16 -0400 Received: from localhost (localhost [127.0.0.1]) by mgw2.diku.dk (Postfix) with ESMTP id 2E77D19BBA2; Sat, 19 Sep 2009 21:48:19 +0200 (CEST) Received: from mgw2.diku.dk ([127.0.0.1]) by localhost (mgw2.diku.dk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 19228-14; Sat, 19 Sep 2009 21:48:17 +0200 (CEST) Received: from nhugin.diku.dk (nhugin.diku.dk [130.225.96.140]) by mgw2.diku.dk (Postfix) with ESMTP id EE29A19BBA1; Sat, 19 Sep 2009 21:48:17 +0200 (CEST) Received: from ask.diku.dk (ask.diku.dk [130.225.96.225]) by nhugin.diku.dk (Postfix) with ESMTP id 292366DF835; Sat, 19 Sep 2009 21:46:20 +0200 (CEST) Received: by ask.diku.dk (Postfix, from userid 3767) id D4C6DF485; Sat, 19 Sep 2009 21:48:17 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by ask.diku.dk (Postfix) with ESMTP id CA7B4F017; Sat, 19 Sep 2009 21:48:17 +0200 (CEST) Date: Sat, 19 Sep 2009 21:48:17 +0200 (CEST) From: Julia Lawall To: mchehab@infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 1/5] drivers/media/video: remove duplicate structure field initialization Message-ID: MIME-Version: 1.0 X-Virus-Scanned: amavisd-new at diku.dk Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Julia Lawall The definition of tvaudio_tuner_ops initializes the s_tuner field twice. It appears that the second case should initialize the g_tuner field. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r@ identifier I, s, fld; position p0,p; expression E; @@ struct I s =@p0 { ... .fld@p = E, ...}; @s@ identifier I, s, r.fld; position r.p0,p; expression E; @@ struct I s =@p0 { ... .fld@p = E, ...}; @script:python@ p0 << r.p0; fld << r.fld; ps << s.p; pr << r.p; @@ if int(ps[0].line)!=int(pr[0].line) or int(ps[0].column)!=int(pr[0].column): cocci.print_main(fld,p0) // Signed-off-by: Julia Lawall --- drivers/media/video/tvaudio.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/video/tvaudio.c b/drivers/media/video/tvaudio.c index 0869baf..800fc1b 100644 --- a/drivers/media/video/tvaudio.c +++ b/drivers/media/video/tvaudio.c @@ -1919,7 +1919,7 @@ static const struct v4l2_subdev_tuner_ops tvaudio_tuner_ops = { .s_radio = tvaudio_s_radio, .s_frequency = tvaudio_s_frequency, .s_tuner = tvaudio_s_tuner, - .s_tuner = tvaudio_g_tuner, + .g_tuner = tvaudio_g_tuner, }; static const struct v4l2_subdev_audio_ops tvaudio_audio_ops = {