From patchwork Mon May 13 05:59:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 18383 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1UblnM-0006O1-Cq; Mon, 13 May 2013 07:59:36 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-5) with esmtp id 1UblnK-0005py-8O; Mon, 13 May 2013 07:59:36 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753392Ab3EMF7c (ORCPT + 1 other); Mon, 13 May 2013 01:59:32 -0400 Received: from mail-bk0-f50.google.com ([209.85.214.50]:57018 "EHLO mail-bk0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753115Ab3EMF7c (ORCPT ); Mon, 13 May 2013 01:59:32 -0400 Received: by mail-bk0-f50.google.com with SMTP id ik5so2195923bkc.23 for ; Sun, 12 May 2013 22:59:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to:cc :content-type; bh=wEKWCBMVwA4AaCBSW9qDi1xf6qkapwhPQQQ2oZjSF0I=; b=TkMwMnmSsxpTdmn9WWm1JJJAPm2BxRZQNeGmU9CD+FZ76yT48MhH4iXJ4hK6BaXsr1 jB9leVz58aFBaaZ5kWaYHnX2bAhuX72L58SvNHOzQzs9P/XJG2bMX+ZkvKhvxkLgM7XS 0oLVkCue94kap5zCh7pLKkLlQE3Ebz8addWCHzbOoNleXH8Y0JI3O4GHpmWHt/Cul5lB 1+cGnIYEpPxfZRJLgqaSBGdic39CuUT7MEo8PFwPK/lY7OzC/WerqzGIDBtM8n4kCypb LBSgxBaG6u4fBjM2T96tSXPDz9SGdmbLAi5+UulLG3xyI9ANcBRTzj3qbfdnmaWiI7nL nqbw== MIME-Version: 1.0 X-Received: by 10.205.101.65 with SMTP id cz1mr5106129bkc.124.1368424770977; Sun, 12 May 2013 22:59:30 -0700 (PDT) Received: by 10.204.199.129 with HTTP; Sun, 12 May 2013 22:59:30 -0700 (PDT) Date: Mon, 13 May 2013 13:59:30 +0800 Message-ID: Subject: [PATCH] [media] blackfin: fix error return code in bcap_probe() From: Wei Yongjun To: scott.jiang.linux@gmail.com, mchehab@redhat.com Cc: yongjun_wei@trendmicro.com.cn, uclinux-dist-devel@blackfin.uclinux.org, linux-media@vger.kernel.org Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.5.13.55119 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' CN_TLD 0.1, FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __DATE_TZ_HK 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_HTTP_RECEIVED 0, __PHISH_SPEAR_STRUCTURE_1 0, __PHISH_SPEAR_STRUCTURE_2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' From: Wei Yongjun Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/media/platform/blackfin/bfin_capture.c | 2 ++ 1 file changed, 2 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/platform/blackfin/bfin_capture.c b/drivers/media/platform/blackfin/bfin_capture.c index 0e55b08..2d1e032 100644 --- a/drivers/media/platform/blackfin/bfin_capture.c +++ b/drivers/media/platform/blackfin/bfin_capture.c @@ -1070,6 +1070,7 @@ static int bcap_probe(struct platform_device *pdev) if (!config->num_inputs) { v4l2_err(&bcap_dev->v4l2_dev, "Unable to work without input\n"); + ret = -EINVAL; goto err_unreg_vdev; } @@ -1079,6 +1080,7 @@ static int bcap_probe(struct platform_device *pdev) } else { v4l2_err(&bcap_dev->v4l2_dev, "Unable to register sub device\n"); + ret = -ENODEV; goto err_unreg_vdev; }