From patchwork Wed Jan 15 05:52:12 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 21602 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1W3JOm-0003bO-Nw; Wed, 15 Jan 2014 06:52:20 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-5) with esmtp id 1W3JOi-0002Bi-8L; Wed, 15 Jan 2014 06:52:20 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750754AbaAOFwO (ORCPT + 1 other); Wed, 15 Jan 2014 00:52:14 -0500 Received: from mail-bk0-f50.google.com ([209.85.214.50]:35201 "EHLO mail-bk0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750724AbaAOFwN (ORCPT ); Wed, 15 Jan 2014 00:52:13 -0500 Received: by mail-bk0-f50.google.com with SMTP id e11so557907bkh.37 for ; Tue, 14 Jan 2014 21:52:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=4P7luwO1XqapLW+IEZxcSGOm4CoWXcy+PS9nYeZc/UQ=; b=qqu41RgDejS18r4ULgVOeFQjhRAM0fRdNFbklLz2ztGXt0HLjDfpaHvq924xeuS0te eu0h71m+XVopSwAmVfEooBqH0yKjt34U322RKoMOjbVDy42b3/5kxUsBM/hERcGs6Eei HpcwFlPfP92u81548CN29GO5BbPmdjaBPbn/mMjtV5IKh2E10Vju6647nuLAnsNA6Omq VIKFmd5H9Jq++DmzqWorOPw292w6L7B9XgOiiJevL1e6nkTsfod7mME3h6q/B+UUBetX zX69HWl4m823DqX6KpqvozCz2tdACSg1IVIE+rFaVcwgBsRmDJn0z7ZQ748Qqjm1MeLp MHUw== MIME-Version: 1.0 X-Received: by 10.204.53.75 with SMTP id l11mr199139bkg.35.1389765132589; Tue, 14 Jan 2014 21:52:12 -0800 (PST) Received: by 10.204.74.130 with HTTP; Tue, 14 Jan 2014 21:52:12 -0800 (PST) Date: Wed, 15 Jan 2014 13:52:12 +0800 Message-ID: Subject: [PATCH -next] [media] em28xx-audio: remove needless check before usb_free_coherent() From: Wei Yongjun To: m.chehab@samsung.com Cc: yongjun_wei@trendmicro.com.cn, linux-media@vger.kernel.org Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.1.15.54218 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' CN_TLD 0.1, FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __DATE_TZ_HK 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_HTTP_RECEIVED 0, __PHISH_SPEAR_STRUCTURE_1 0, __PHISH_SPEAR_STRUCTURE_2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' From: Wei Yongjun usb_free_coherent() is safe with NULL addr and this check is not required. Signed-off-by: Wei Yongjun --- drivers/media/usb/em28xx/em28xx-audio.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/usb/em28xx/em28xx-audio.c b/drivers/media/usb/em28xx/em28xx-audio.c index f3e3200..287ce17 100644 --- a/drivers/media/usb/em28xx/em28xx-audio.c +++ b/drivers/media/usb/em28xx/em28xx-audio.c @@ -695,11 +695,9 @@ static void em28xx_audio_free_urb(struct em28xx *dev) if (!urb) continue; - if (dev->adev.transfer_buffer[i]) - usb_free_coherent(dev->udev, - urb->transfer_buffer_length, - dev->adev.transfer_buffer[i], - urb->transfer_dma); + usb_free_coherent(dev->udev, urb->transfer_buffer_length, + dev->adev.transfer_buffer[i], + urb->transfer_dma); usb_free_urb(urb); }