From patchwork Mon May 13 06:00:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 18385 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1Ublo9-0006Oq-8r; Mon, 13 May 2013 08:00:25 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1Ublo7-0000F2-4j; Mon, 13 May 2013 08:00:25 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753361Ab3EMGAP (ORCPT + 1 other); Mon, 13 May 2013 02:00:15 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:51902 "EHLO mail-bk0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753115Ab3EMGAM (ORCPT ); Mon, 13 May 2013 02:00:12 -0400 Received: by mail-bk0-f44.google.com with SMTP id jk13so2212667bkc.3 for ; Sun, 12 May 2013 23:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to:cc :content-type; bh=IqNqrEJPMvJd4NPJTftk3mon/Hp5AH//7z2c0Vf1VRg=; b=t/brBMytBJhFMrT5smok/Oj3lKeICJJMFEBb61JY5bqGVZAuE2GmsB33OfwSc35ITP Dz3qKvvoqAJ7wMOzlZFvtbFyyccBpGfrkPKJNfFX62EDwdknEFaRro9ysAwQjRXy4Qq6 KA9QT+y63eL5ryCCqGQ7tgZsHFU0xXT4FqnKUf9HimMJTZGWpBWAr9gylquX6gOOvrPz 2aQkTPjYlRRtWpnT75ixd2dogHWaM8b+3p6ZkUZVlNGkD6HDTVgIir+8Iw2QZA2y+9AN 35YfWjgAF+O+Mhfpfai58T6jXif9UKHVPBDn5GrCcYrUCT+zM9zxdyIwz6wB8wwSSM5n RWlQ== MIME-Version: 1.0 X-Received: by 10.204.172.80 with SMTP id k16mr5235703bkz.123.1368424810754; Sun, 12 May 2013 23:00:10 -0700 (PDT) Received: by 10.204.199.129 with HTTP; Sun, 12 May 2013 23:00:10 -0700 (PDT) Date: Mon, 13 May 2013 14:00:10 +0800 Message-ID: Subject: [PATCH] [media] ad9389b: fix error return code in ad9389b_probe() From: Wei Yongjun To: hans.verkuil@cisco.com, mchehab@redhat.com Cc: yongjun_wei@trendmicro.com.cn, linux-media@vger.kernel.org Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.5.13.55119 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' CN_TLD 0.1, FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __DATE_TZ_HK 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_HTTP_RECEIVED 0, __PHISH_SPEAR_STRUCTURE_1 0, __PHISH_SPEAR_STRUCTURE_2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' From: Wei Yongjun Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun Acked-by: Hans Verkuil --- drivers/media/i2c/ad9389b.c | 2 ++ 1 file changed, 2 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/i2c/ad9389b.c b/drivers/media/i2c/ad9389b.c index 58344b6..decef36 100644 --- a/drivers/media/i2c/ad9389b.c +++ b/drivers/media/i2c/ad9389b.c @@ -1251,12 +1251,14 @@ static int ad9389b_probe(struct i2c_client *client, const struct i2c_device_id * state->edid_i2c_client = i2c_new_dummy(client->adapter, (0x7e>>1)); if (state->edid_i2c_client == NULL) { v4l2_err(sd, "failed to register edid i2c client\n"); + err = -ENOMEM; goto err_entity; } state->work_queue = create_singlethread_workqueue(sd->name); if (state->work_queue == NULL) { v4l2_err(sd, "could not create workqueue\n"); + err = -ENOMEM; goto err_unreg; }