From patchwork Thu Dec 12 06:49:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 21065 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1Vr064-00028R-PI; Thu, 12 Dec 2013 07:50:08 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-7) with esmtp id 1Vr062-0005hG-1M; Thu, 12 Dec 2013 07:50:08 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752041Ab3LLGuB (ORCPT + 1 other); Thu, 12 Dec 2013 01:50:01 -0500 Received: from mail-bk0-f50.google.com ([209.85.214.50]:36517 "EHLO mail-bk0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751452Ab3LLGt4 (ORCPT ); Thu, 12 Dec 2013 01:49:56 -0500 Received: by mail-bk0-f50.google.com with SMTP id e11so709174bkh.37 for ; Wed, 11 Dec 2013 22:49:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=BZvqEglYIjvFAwpzyzCNMCzyiFAhzfFMhV66zXHtrwE=; b=B+SzRt7b4CK3vJM7K7NVfPmlK/NSTEh2lGT2td7+zPXgpQzfcyeaQqnEXh8Nmu0A+f bavUM0s1uhAiIuVUu2wAFuk1l3gCqWttEvMjcTWMg4QI01fthLIhr3ns506w1gOTjDL8 Zc7McSR9P6+o3tKmOkoGqX4XP7nEtebEjGzOwzTUyLQDc7KykAM+wQNu6b9eRPI7mXm9 yLRlpSScig+z6tSCBhWlE8yqPmiVHUIYTx9/o+95tXFDfuIdGzRwZKBjdzpwnhZde5/M H6EgMGQX3NV3d24gWCgRshKIGnvMWFFVDmvZsxofmERevHSs/ogoh46m5MfubERPyyue y5XQ== MIME-Version: 1.0 X-Received: by 10.204.165.79 with SMTP id h15mr786bky.148.1386830994419; Wed, 11 Dec 2013 22:49:54 -0800 (PST) Received: by 10.204.74.130 with HTTP; Wed, 11 Dec 2013 22:49:54 -0800 (PST) Date: Thu, 12 Dec 2013 14:49:54 +0800 Message-ID: Subject: [PATCH -next] [media] radio-bcm2048: fix missing unlock on error in bcm2048_rds_fifo_receive() From: Wei Yongjun To: m.chehab@samsung.com, gregkh@linuxfoundation.org, ext-eero.nurkkala@nokia.com, pali.rohar@gmail.com, hans.verkuil@cisco.com, joni.lapilainen@gmail.com Cc: yongjun_wei@trendmicro.com.cn, linux-media@vger.kernel.org, devel@driverdev.osuosl.org Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.12.12.63915 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' CN_TLD 0.1, FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __DATE_TZ_HK 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __MULTIPLE_RCPTS_TO_X5 0, __PHISH_SPEAR_HTTP_RECEIVED 0, __PHISH_SPEAR_STRUCTURE_1 0, __PHISH_SPEAR_STRUCTURE_2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' From: Wei Yongjun Add the missing unlock before return from function bcm2048_rds_fifo_receive() in the error handling case. Signed-off-by: Wei Yongjun --- drivers/staging/media/bcm2048/radio-bcm2048.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c index 494ec39..37ff899 100644 --- a/drivers/staging/media/bcm2048/radio-bcm2048.c +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c @@ -1767,6 +1767,7 @@ static void bcm2048_rds_fifo_receive(struct bcm2048_device *bdev) bdev->rds_info.radio_text, bdev->fifo_size); if (err != 2) { dev_err(&bdev->client->dev, "RDS Read problem\n"); + mutex_unlock(&bdev->mutex); return; }